Hi
First of all I'd like to say how impressed I am with geany. I ran it and it went KAPOW!! I've been using emacs for the past 7 years. Every once in while i try to break away and use something more modern like anjuta or codeblocks but I always revert to emacs. I've been using geany for a week now. So far no emacs =)
Anyways I saw a request for code navigation and I wanted it myself so I hacked up back and forward buttons. Right now, it only changes the history when you go to a definition or declaration from the context menu, but I'm open to suggestions on this. Also, if the file is no longer open, it removes it from the queue and goes nowhere.
If anyone is interested I'd be willing to polish this off and submit it for entry into geany.
dave
On 05/28/2007 06:39:32 AM, Dave Moore wrote:
Anyways I saw a request for code navigation and I wanted it myself so I hacked up back and forward buttons. Right now, it only changes the history when you go to a definition or declaration from the context menu, but I'm open to suggestions on this. Also, if the file is no longer open, it removes it from the queue and goes nowhere.
If anyone is interested I'd be willing to polish this off and submit it for entry into geany.
Sounds good, please do :) Just submit it when it's stable, then any further improvements in functionality can be sent separately.
Regards, Nick
OK. My code seems pretty stable now. I read the hackers guide and figured I should create a navqueue.c file and put the functionality in there. Its only five functions so it could easily be moved somewhere else if you feel thats appropriate. I've attached an svn diff and the two new files. I'm gonna tweak it out some more and and some options but that'll come later.
Also, I have about a billion and 3 different features I'd like to see in geany (and I'm willing to work on any/all of them). How should I go about proposing them all? Should I submit each of them into bug tracking or should I put it all into a mailing list post?
cheers, dave
On 5/28/07, Nick Treleaven nick.treleaven@btinternet.com wrote:
On 05/28/2007 06:39:32 AM, Dave Moore wrote:
Anyways I saw a request for code navigation and I wanted it myself so I hacked up back and forward buttons. Right now, it only changes the history when you go to a definition or declaration from the context menu, but I'm open to suggestions on this. Also, if the file is no longer open, it removes it from the queue and goes nowhere.
If anyone is interested I'd be willing to polish this off and submit it for entry into geany.
Sounds good, please do :) Just submit it when it's stable, then any further improvements in functionality can be sent separately.
Regards, Nick _______________________________________________ Geany mailing list Geany@uvena.de http://uvena.de/cgi-bin/mailman/listinfo/geany
On Thu, 31 May 2007 23:36:28 -0400, "Dave Moore" wrex006@gmail.com wrote:
Hi,
OK. My code seems pretty stable now. I read the hackers guide and figured I should create a navqueue.c file and put the functionality in there. Its only five functions so it could easily be moved somewhere else if you feel thats appropriate. I've attached an svn
Thank you very much. It applied smoothly, great. Added in SVN r1590. What I changed(in case someone is interested in): - moved the toolbar buttons to the right of the undo/redo buttons - added an option to hide the toolbar buttons - small code format changes in navqueue.c|h (nothing big) - moved locally used variables and definitions from navqueue.h to navqueue.c - before adding a new position(history entry), another one is created pointing to the current file before switching, I think this is more intuitive - all the other changes I forgot to mention ;-)
Also, I have about a billion and 3 different features I'd like to see in geany (and I'm willing to work on any/all of them). How should I go about proposing them all? Should I submit each of them into bug tracking or should I put it all into a mailing list post?
I think sending to this list is better because further discussions are easier and are read by more people. If you experience problems sending attachments, your mail will be hold in a queue and I get informed and I will accept the mail manually (happens with big attachments, IIRC bigger than 50Kb). So don't be afraid and be patient if your mail doesn't appear immediately on the list.
Regards, Enrico
Awesome. Thanks for adding this.
On 6/2/07, Enrico Tröger enrico.troeger@uvena.de wrote:
Thank you very much. It applied smoothly, great. Added in SVN r1590. What I changed(in case someone is interested in):
- moved the toolbar buttons to the right of the undo/redo buttons
- added an option to hide the toolbar buttons
- small code format changes in navqueue.c|h (nothing big)
- moved locally used variables and definitions from navqueue.h to
navqueue.c
- before adding a new position(history entry), another one is
created pointing to the current file before switching, I think this is more intuitive
- all the other changes I forgot to mention ;-)
Awesome! Adding the current position before switching is a good idea. I was planning to do it myself but I was debating on how to do it. A few other things I had in mind for it are: - check to see if the pos were adding is already at navq[0] (to avoid side by side duplicates) - allow back and forward to be keybound - add to nav queue when: - clicking on a file in the compiler msgs window - clicking on a symbol in the symbols list - clicking on a line in the search results - jumping to a line(?) - clicking on a file in the open files tree (?) - switching to a different tab(?) - searching within a file(?)
The ones with ? I'm not so sure about. Maybe the should be optionized. I will play around with it and see how they work.
dave
On Sat, 2 Jun 2007 18:12:58 -0400, "Dave Moore" wrex006@gmail.com wrote:
Hi,
Thank you very much. It applied smoothly, great. Added in SVN r1590.
it. A few other things I had in mind for it are:
- check to see if the pos were adding is already at navq[0] (to avoid
side by side duplicates)
I think this is what I meant with the TODO in navqueue_new_position()?
- allow back and forward to be keybound
I added keybindings in SVN r1593.
- add to nav queue when:
- clicking on a file in the compiler msgs window
- clicking on a symbol in the symbols list
- clicking on a line in the search results
Agree with the above ones. Would be very cool.
- jumping to a line(?) - clicking on a file in the open files tree (?) - switching to a different tab(?) - searching within a file(?)The ones with ? I'm not so sure about. Maybe the should be optionized. I will play around with it and see how they work.
I'm also not sure about these ones. Let's see if anyone else posts an opinion ;-).
If you need any help or have questions regarding the implementation, just ask.
Regards, Enrico
Just built Geany.exe (obviously on Windows). In order to get a build, I had to add navqueue.o to the list of objects in src/makefile.win32. Please add that to the ToDo list.
Haven't had time to try it out much, but the idea sounds wonderful.
chuck
Enrico Tröger wrote:
On Sat, 2 Jun 2007 18:12:58 -0400, "Dave Moore" wrex006@gmail.com wrote:
Hi,
Thank you very much. It applied smoothly, great. Added in SVN r1590.
it. A few other things I had in mind for it are:
- check to see if the pos were adding is already at navq[0] (to avoid
side by side duplicates)
I think this is what I meant with the TODO in navqueue_new_position()?
- allow back and forward to be keybound
I added keybindings in SVN r1593.
- add to nav queue when:
- clicking on a file in the compiler msgs window
- clicking on a symbol in the symbols list
- clicking on a line in the search results
Agree with the above ones. Would be very cool.
- jumping to a line(?) - clicking on a file in the open files tree (?) - switching to a different tab(?) - searching within a file(?)The ones with ? I'm not so sure about. Maybe the should be optionized. I will play around with it and see how they work.
I'm also not sure about these ones. Let's see if anyone else posts an opinion ;-).
If you need any help or have questions regarding the implementation, just ask.
Regards, Enrico
Geany mailing list Geany@uvena.de http://uvena.de/cgi-bin/mailman/listinfo/geany
No virus found in this incoming message. Checked by AVG Free Edition. Version: 7.5.467 / Virus Database: 269.8.7/829 - Release Date: 6/2/2007 5:26 PM
On Sun, 03 Jun 2007 09:41:06 -0700, chuck ctl@arrowtwins.com wrote:
Just built Geany.exe (obviously on Windows). In order to get a build, I had to add navqueue.o to the list of objects in src/makefile.win32. Please add that to the ToDo list.
Added in SVN r1595. I'm sorry I forgot to add it.
Regards, Enrico
On 06/02/2007 11:12:58 PM, Dave Moore wrote:
A few other things I had in mind for it are:
- check to see if the pos were adding is already at navq[0] (to avoid
side by side duplicates)
- allow back and forward to be keybound
- add to nav queue when:
- clicking on a file in the compiler msgs window
- clicking on a symbol in the symbols list
- clicking on a line in the search results
- jumping to a line(?)
- clicking on a file in the open files tree (?)
- switching to a different tab(?)
- searching within a file(?)
I've added symbol list support, and preventing duplicates in the queue. I guess adding compiler and search results support might be good, although would they clutter up the queue? They seem to be temporary items, whereas tags are more likely to be returned to.
Also we might want to limit the queue length - e.g. discard the earliest item once we reach say 25 items.
Regards, Nick
On Tue, 17 Jul 2007 17:24:24 +0100, Nick Treleaven nick.treleaven@btinternet.com wrote:
On 06/02/2007 11:12:58 PM, Dave Moore wrote:
A few other things I had in mind for it are:
- check to see if the pos were adding is already at navq[0] (to
avoid side by side duplicates)
- allow back and forward to be keybound
- add to nav queue when:
- clicking on a file in the compiler msgs window
- clicking on a symbol in the symbols list
- clicking on a line in the search results
- jumping to a line(?)
- clicking on a file in the open files tree (?)
- switching to a different tab(?)
- searching within a file(?)
I've added symbol list support, and preventing duplicates in the queue. I guess adding compiler and search results support might be good, although would they clutter up the queue? They seem to be temporary items, whereas tags are more likely to be returned to.
I'm not sure. Compiler messages could be nice but yes they are not that consistent. But maybe we could use some smart code which removes all navigation items in the queue from previous compiler messages. But to be able to do this, the queue items need some information about the source of the item. I don't know whether it is good idea at all. Seems like big overhead for little use.
Also we might want to limit the queue length - e.g. discard the earliest item once we reach say 25 items.
I think so too. 25 seems like a reasonable limit although form me personally it could be a bit lower or we just make as a preference.
Regards, Enrico
On 07/17/2007 05:37:17 PM, Enrico Tröger wrote:
On Tue, 17 Jul 2007 17:24:24 +0100, Nick Treleaven nick.treleaven@btinternet.com wrote:
On 06/02/2007 11:12:58 PM, Dave Moore wrote:
A few other things I had in mind for it are:
- check to see if the pos were adding is already at navq[0] (to
avoid side by side duplicates)
- allow back and forward to be keybound
- add to nav queue when:
- clicking on a file in the compiler msgs window
- clicking on a symbol in the symbols list
- clicking on a line in the search results
- jumping to a line(?)
- clicking on a file in the open files tree (?)
- switching to a different tab(?)
- searching within a file(?)
I've added symbol list support, and preventing duplicates in the queue. I guess adding compiler and search results support might be good, although would they clutter up the queue? They seem to be temporary items, whereas tags are more likely to be returned to.
I'm not sure. Compiler messages could be nice but yes they are not that consistent. But maybe we could use some smart code which removes all navigation items in the queue from previous compiler messages. But to be able to do this, the queue items need some information about the source of the item. I don't know whether it is good idea at all. Seems like big overhead for little use.
I think if we add Previous Message and Previous Error commands then these should be sufficient, and that would keep the queue clean.
Also we might want to limit the queue length - e.g. discard the earliest item once we reach say 25 items.
I think so too. 25 seems like a reasonable limit although form me personally it could be a bit lower or we just make as a preference.
OK. I think queue items don't use much memory.
Regards, Nick
Just got a chance to use Dave's code navigation functions. GREAT! That was one of the items on my "wanted features" list.
Thanks.
chuck
Dave Moore wrote:
OK. My code seems pretty stable now. I read the hackers guide and figured I should create a navqueue.c file and put the functionality in there. Its only five functions so it could easily be moved somewhere else if you feel thats appropriate. I've attached an svn diff and the two new files. I'm gonna tweak it out some more and and some options but that'll come later.
Also, I have about a billion and 3 different features I'd like to see in geany (and I'm willing to work on any/all of them). How should I go about proposing them all? Should I submit each of them into bug tracking or should I put it all into a mailing list post?
cheers, dave
OOPS! Sorry about the last post. Apparently sending tar balls causes your message to disappear but not the attachment?
My code seems pretty stable now. I read the hackers guide and figured I should create a navqueue.c file and put the functionality in there. Its only five functions so it could easily be moved somewhere else if you feel thats appropriate. I'll upload the files to the sourceforge enhancement request. I'm gonna tweak it out some more and and some options but that'll come later.
Also, I have about a billion and 3 different features I'd like to see in geany (and I'm willing to work on any/all of them). How should I go about proposing them all? Should I submit each of them into bug tracking or should I put it all into a mailing list post?
cheers, dave
On 5/28/07, Nick Treleaven nick.treleaven@btinternet.com wrote:
On 05/28/2007 06:39:32 AM, Dave Moore wrote:
Anyways I saw a request for code navigation and I wanted it myself so I hacked up back and forward buttons. Right now, it only changes the history when you go to a definition or declaration from the context menu, but I'm open to suggestions on this. Also, if the file is no longer open, it removes it from the queue and goes nowhere.
If anyone is interested I'd be willing to polish this off and submit it for entry into geany.
Sounds good, please do :) Just submit it when it's stable, then any further improvements in functionality can be sent separately.
Regards, Nick _______________________________________________ Geany mailing list Geany@uvena.de http://uvena.de/cgi-bin/mailman/listinfo/geany
On Fri, 1 Jun 2007 00:51:26 -0400, "Dave Moore" wrex006@gmail.com wrote:
OOPS! Sorry about the last post. Apparently sending tar balls causes your message to disappear but not the attachment?
Btw, what do you mean? Your previous post with the attachment looks fine here.
Regards, Enrico