[...]
The results are at https://github.com/unwind/geanyuniq, and I would love some feedback.
Whilst I don't think this is an everyday use plugin, I am sure it can occasionally be useful and will be worthwhile putting in plugins somewhere.
I am not sure if it is big enough for its own plugin, but I suspect its use will be uncommon enough that it should not be in add-ons, so I suppose by itself is fine for now.
[...]
[menu cleverness]
At least as far as I know this just wasn't under discussion by now. Its current just some kind of a stack.
I am not sure, but I believe that there are several reasons why adding items into other menus is not encouraged:
1. it means that the standard menus have to then be fixed, so you know where you are putting the new item. This is the case even if using a path or the path will be wrong. 2. what happens when several plugins all try the same place, could make lousy menus, and then it also changes the menu and violates item 1. 3. "hiding" the plugin menu item somewhere in the rest of the menus makes it hard to find
So keeping plugin menu items constrained is a good idea.
Not sure what you're referring to here. The Tools menu?
Ignoring the menu item issue, the command is by default bound to Shift+Control+D,
I'd remove default binding. E.g. I already have this one in another use.
Aha, that might be a good point, leaving the assigning of the key to the user.
Agree, plugins shouldn't set default keybindings without user input because of the possibility of clashing with other user definitions.
@Frank, can this be made a general recommendation somewhere about plugins?
It outputs a line of text to the Status window saying how many lines were deleted (if any were deleted), is that a good idea, or annoying/spammy?
I like that idea.
Cool.
Don't worry too much over using the status window, 90% of users don't seem to notice *anything* that comes up there anyway, me included :)
Are you thinking of adding it to geany-plugins project? ;)
Yes, this seems general-purpose enough to make sense for that project, and also since it was on the wishlist it might be useful/sought after.
To the people saying "you can just pipe through uniq/sort": yes, of course.
But on *ix only.
But that creates another process, and pipes the data (twice!) between the two. I haven't tested it, but I'd wager that doing it directly against the Scintilla widget is at least twice as fast, and uses way less memory too. That was the point, plus maybe making it a little bit more user-accessible (the mere existence of the item on the wishlist seems to signify that "most users" don't just think of piping through an external program). So I think it's worthwhile. :)
I wouldn't guarantee the performance stuff without trying it, remember Unix is made for piping stuff around processes. But it is irrelevant anyway for a rarely used function.
Seems like an occasionally useful plugin, thanks for your efforts.
Cheers Lex
Regards,
/Emil _______________________________________________ Geany mailing list Geany@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany