Hi
Today I desided to see if Arch linux can help me in building custom linux distributive, and I encounter pitfall.
Step to reproduce:
1) Install Arch 2) Install geany 3) run geany (It remember that my make_cmd is "" ;-) ) 4) Install make
After this step "make" support is still broken since make_cmd firmly set to "". Even more it dangerously try to execute "all" or any other custom build target in sh. I think it is not very nice.
Here is two patches, each solve the problem:
1) If we get "" from settings try to find default tool in path.
2) If tool cmd is not set in config just use default value without any manipulation with g_find_program_in_path() If we can find it with this function, then usage without full path will work too. So it should not be too smart.
As for me I like 2 solution better.
On Wed, 12 Mar 2008 13:16:47 +0200, Yura Siamashka yurand2@gmail.com wrote:
Hi
Today I desided to see if Arch linux can help me in building custom linux distributive, and I encounter pitfall.
Step to reproduce:
- Install Arch
- Install geany
- run geany (It remember that my make_cmd is "" ;-) )
- Install make
After this step "make" support is still broken since make_cmd firmly set to "". Even more it dangerously try to execute "all" or any other custom build target in sh. I think it is not very nice.
Here is two patches, each solve the problem:
If we get "" from settings try to find default tool in path.
If tool cmd is not set in config just use default value without any manipulation with g_find_program_in_path()
If we can find it with this function, then usage without full path will work too. So it should not be too smart.
Not really. This is basically true but only if the G_SPAWN_SEARCH_PATH flag is passed to g_spawn_* calls. This flag is passed in Geany where it is needed except one case in the Find in Files code but it should be fixed now.
Thanks a lot.
Regards, Enrico