Trying to toggle the case of a rectangular selection currently results in some rather strange results. This patch seems to solve the problem...
- Jeff
On Mon, 3 Mar 2008 17:46:33 -0600, "Jeff Pohlmeyer" yetanothergeek@gmail.com wrote:
Hi,
thanks for the patch. But I'm not sure whether we should use it because it will break case toggling of any non-Ascii characters. SCI_LOWERCASE and SCI_UPPERCASE don't work with Unicode characters[1] therefore we used GLib's lower/upper case functions. IMO Unicode support is more important than rectangular selection support (I guess there are much more problems with this).
What do you think?
One solution could be to detect whether we have a rectangular selection and then use the Scintilla commands and the GLib commands otherwise. So, rectangular selections will still work with toggle case even though Unicode characters are ignored. But this require that we know we have a rectangular selection.
[1] https://sourceforge.net/tracker/index.php?func=detail&aid=1276699&gr...
Regards, Enrico
Enrico Tröger enrico.troeger@uvena.de wrote:
Jeff Pohlmeyer yetanothergeek@gmail.com wrote:
IMO Unicode support is more important than rectangular selection support. What do you think?
IMO rectangular selection support is more important than Unicode support :-)
Okay, here is a second attempt that does that...
- Jeff
I have done this a long time ago. Have been using it very sucessfully in geany ( I build my own so this will work ) It may be out of date a bit, but should give you some hints.
see www.arrowtwins.com and look for the Editor.cxx link. It's all there. I tried to get this into Geany a year or so ago but there did not seem to be any interest.
chuck
Jeff Pohlmeyer wrote:
On Wed, 05 Mar 2008 17:30:15 -0800, chuck ctl@arrowtwins.com wrote:
To be honest: yes. I will have a look at your code and maybe we'll use it.
Regards, Enrico
Thanks, that would be great. I won't use an editor without column editing, than's why I build my own Geany.
To note: the patch on the website was submitted to the Scintilla project but was rejected because a zero-width rectangle does not have a visual indication that it exists. My rebuttal is that the user just constructed the rectangle, so should know that it exists. And it is not persistent; ie it only exists while doing the column edit thing.
Chuck
Enrico Tröger wrote:
On Thu, 06 Mar 2008 09:34:15 -0800, chuck ctl@arrowtwins.com wrote:
Thanks, that would be great. I won't use an editor without column editing, than's why I build my own Geany.
Unfortunately, your Editor.cxx is very old and completely incompatible with recent Scintilla versions(we use 1.75 in Geany). So, since you (hopefully) still what you have changed, could yo do these changes again on the Editor.cxx included in Geany's SVN version and send a patch? Thanks.
Regards, Enrico
On Wed, 5 Mar 2008 17:18:56 -0600, "Jeff Pohlmeyer" yetanothergeek@gmail.com wrote:
I have a slightly different opinion...:D.
Fine, thanks. So, toggle case works at least for Ascii characters while non-Ascii ones are just ignored in rectangular selections.
Regards, Enrico