Hello!
I made new plugin that includes almost all possible features concerned with brackets and quotes auto-closing. I just finished it and maybe you want to test it. If it is useful and good enoough I will make pull request.
Previously I made a patch for geany, but decided to put all code together inside one small plugin.
Here is it: https://github.com/scriptum/geany-plugins/tree/master/autoclose
Pavel <roshin@...> writes:
Hello!
I made new plugin that includes almost all possible features concerned with brackets and quotes auto-closing. I just finished it and maybe you want to test it. If it is useful and good enoough I will make pull request.
Previously I made a patch for geany, but decided to put all code together inside one small plugin.
Here is it: https://github.com/scriptum/geany-plugins/tree/master/autoclose
Thanks Pavel. The auto completion of curly brackets and the "improved auto indentation" features are useful for me. I often write short (~100 lines) C++/Java programs in Geany, and the default auto completion feature does not work for my usage (e.g. nested curly brackets).
There is one suggestion. Right now, after hitting enter in-between curly brackets -> "{|}", the new cursor position seems a bit off. In line 241 of the source code, why is it this way?
sci_set_current_position(sci, pos + 2 + start_indent / indent_width, TRUE);
Why not shift to the position where typing normally starts?
sci_set_current_position(sci, pos + 1 + start_indent + indent_width, TRUE);
Wed, 15 May 2013 12:32:12 +0000 (UTC) M Tian mwtian@gmail.com: writes:
Pavel <roshin@...> writes:
Hello!
I made new plugin that includes almost all possible features concerned with brackets and quotes auto-closing. I just finished it and maybe you want to test it. If it is useful and good enoough I will make pull request.
Previously I made a patch for geany, but decided to put all code together inside one small plugin.
Here is it: https://github.com/scriptum/geany-plugins/tree/master/autoclose
Thanks Pavel. The auto completion of curly brackets and the "improved auto indentation" features are useful for me. I often write short (~100 lines) C++/Java programs in Geany, and the default auto completion feature does not work for my usage (e.g. nested curly brackets).
There is one suggestion. Right now, after hitting enter in-between curly brackets -> "{|}", the new cursor position seems a bit off. In line 241 of the source code, why is it this way?
sci_set_current_position(sci, pos + 2 + start_indent / indent_width, TRUE);
Why not shift to the position where typing normally starts?
sci_set_current_position(sci, pos + 1 + start_indent + indent_width, TRUE);
Users mailing list Users@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/users
Thanks you, this was a bug: I guess you use spaces for indentation, but I tested it on tabs indentation.
I fixed it right now, check git please.
Hi Pavel,
Am 13.05.2013 19:23, schrieb Pavel:
I made new plugin that includes almost all possible features concerned with brackets and quotes auto-closing. I just finished it and maybe you want to test it. If it is useful and good enoough I will make pull request.
Did you check the other plugins already providing some autoclosing of bracket etc? Is there maybe some place to consolidate solutions a bit? Just wondering as I don't see it very useful having 3 plugins doing pretty similar things inside one project.
Cheers, Frank
Yes, of course, I there are similar functions in addons plugin, e.g. selection enclosing. Geany has similar feature.
Enclosing in addons plugin defenitely has bugs.
The idea is to make *one* plugin that does everything concerned with autoclosing. Also this plugin substitutes autoclose feature in Geany itself that works very strange too.
Also there are some plugins I saw in IRC and ML but your team didn't include them into Geany and noboby know about them.
Sun, 09 Jun 2013 16:22:23 +0200 сообщение от Frank Lanitz frank@frank.uvena.de:
Hi Pavel,
Am 13.05.2013 19:23, schrieb Pavel:
I made new plugin that includes almost all possible features concerned with brackets and quotes auto-closing. I just finished it and maybe you want to test it. If it is useful and good enoough I will make pull request.
Did you check the other plugins already providing some autoclosing of bracket etc? Is there maybe some place to consolidate solutions a bit? Just wondering as I don't see it very useful having 3 plugins doing pretty similar things inside one project.
Cheers, Frank _______________________________________________ Users mailing list Users@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/users
On 13 June 2013 20:26, Павел Рощин roshin@scriptumplus.ru wrote:
Yes, of course, I there are similar functions in addons plugin, e.g. selection enclosing. Geany has similar feature.
Enclosing in addons plugin defenitely has bugs.
Patches are welcome :)
The idea is to make *one* plugin that does everything concerned with autoclosing. Also this plugin substitutes autoclose feature in Geany itself that works very strange too.
(simple) patches are welcome :)
Also there are some plugins I saw in IRC and ML but your team didn't include them into Geany and noboby know about them.
I guess their devs didn't make a PR so its assumed that they didn't want to submit them.
Cheers Lex
Sun, 09 Jun 2013 16:22:23 +0200 сообщение от Frank Lanitz frank@frank.uvena.de:
Hi Pavel,
Am 13.05.2013 19:23, schrieb Pavel:
I made new plugin that includes almost all possible features concerned with brackets and quotes auto-closing. I just finished it and maybe you want to test it. If it is useful and good enoough I will make pull request.
Did you check the other plugins already providing some autoclosing of bracket etc? Is there maybe some place to consolidate solutions a bit? Just wondering as I don't see it very useful having 3 plugins doing pretty similar things inside one project.
Cheers, Frank _______________________________________________ Users mailing list Users@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/users
-- Best regards, Pavel Roschin _______________________________________________ Users mailing list Users@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/users
I made two patches. First patch adds all features into Geany. Second - feature-rich plugin with configurable preferences. I was discused this in IRC with b4n, we decided that it's better to have separate plugin that's simpler to maintain. I could be this maintainer because I use Geany for my work and I test its features much.
First patch: https://github.com/scriptum/geany-patches
Second (plugin): https://github.com/geany/geany-plugins/pull/106
For this plugin I sent pull request because nobody test it, nobody know about it:) I hope this plugin will increase Geany's usability. I noted that many people missing these features that they had in Eclipse, NB, Kate, Sublime Text and so on. I just added these missed features.
I wait for ur feedback. Maybe one plugin that contains all possible auto-closing code would replace currently scattered parts of sourcecode if it is suitable enough. If it is I'm planning to add more interesting capabilities to improve brackets handling.
Thu, 13 Jun 2013 21:04:41 +1000 сообщение от Lex Trotman elextr@gmail.com:
On 13 June 2013 20:26, Павел Рощин roshin@scriptumplus.ru wrote:
Yes, of course, I there are similar functions in addons plugin, e.g. selection enclosing. Geany has similar feature.
Enclosing in addons plugin defenitely has bugs.
Patches are welcome :)
The idea is to make *one* plugin that does everything concerned with autoclosing. Also this plugin substitutes autoclose feature in Geany itself that works very strange too.
(simple) patches are welcome :)
Also there are some plugins I saw in IRC and ML but your team didn't include them into Geany and noboby know about them.
I guess their devs didn't make a PR so its assumed that they didn't want to submit them.
Cheers Lex
Sun, 09 Jun 2013 16:22:23 +0200 сообщение от Frank Lanitz frank@frank.uvena.de:
Hi Pavel,
Am 13.05.2013 19:23, schrieb Pavel:
I made new plugin that includes almost all possible features concerned with brackets and quotes auto-closing. I just finished it and maybe you want to test it. If it is useful and good enoough I will make pull request.
Did you check the other plugins already providing some autoclosing of bracket etc? Is there maybe some place to consolidate solutions a bit? Just wondering as I don't see it very useful having 3 plugins doing pretty similar things inside one project.
Cheers, Frank _______________________________________________ Users mailing list Users@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/users
-- Best regards, Pavel Roschin _______________________________________________ Users mailing list Users@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/users
Am 13.06.2013 12:26, schrieb Павел Рощин:
Yes, of course, I there are similar functions in addons plugin, e.g. selection enclosing. Geany has similar feature.
Enclosing in addons plugin defenitely has bugs.
The idea is to make *one* plugin that does everything concerned with autoclosing. Also this plugin substitutes autoclose feature in Geany itself that works very strange too.
OK. I'll have a look at the PR and after a short review most likely I will merge them. But there is one this you have com promise: Please check with the other plugin authors here, maybe on PM, to consolidate the enclosing things. I don't want to have three or more plugins sharing the same features and none of them is working 100%.
Also there are some plugins I saw in IRC and ML but your team didn't include them into Geany and noboby know about them.
Unfortunately the old issue... There is a life beside Geany ;)D
Cheers, Frank
Am 14.06.2013 09:45, schrieb Frank Lanitz:
Am 13.06.2013 12:26, schrieb Павел Рощин:
Yes, of course, I there are similar functions in addons plugin, e.g. selection enclosing. Geany has similar feature.
Enclosing in addons plugin defenitely has bugs.
The idea is to make *one* plugin that does everything concerned with autoclosing. Also this plugin substitutes autoclose feature in Geany itself that works very strange too.
OK. I'll have a look at the PR and after a short review most likely I will merge them.
The options seems not to be persitent after restarting Geany. I loaded the plugin. Checked the configuration and test basic working of plugin. It does. But after I closed down Geany and restarted it, the plugin started to work after reloading it via the plugin manager. You should have a look over there.
Cheers, Frank
Could you tell me how to reproduce this? I tried to open/close/enable/disable plugin - all options work for me.
Fri, 14 Jun 2013 10:24:25 +0200 сообщение от Frank Lanitz frank@frank.uvena.de:
The options seems not to be persitent after restarting Geany. I loaded the plugin. Checked the configuration and test basic working of plugin. It does. But after I closed down Geany and restarted it, the plugin started to work after reloading it via the plugin manager. You should have a look over there.
The biggest one: Geany has its own autoclose feature. It's rough and simple and you cannot tune it well. There is lack of features, e.g. enclosing. It conflicts with this autoclose plugin.
Enclosing feature is in Addons plugin. This is solution with bugs: it does enclosing even when editor is outside focus (focus on terminal or search bar). I cannot find it's author mail (github.com/pzoxiuv).
I see that you are committer of both of them:)
I didn't see another plugins that offers autoclosing features in geany-plugins. But there are many around the world.
I hope plugin maintainers will read this discussion and maybe geany-plugins has another solutions I didn't noticed.
Fri, 14 Jun 2013 09:45:20 +0200 сообщение от Frank Lanitz frank@frank.uvena.de:
Am 13.06.2013 12:26, schrieb Павел Рощин:
Yes, of course, I there are similar functions in addons plugin, e.g. selection enclosing. Geany has similar feature.
Enclosing in addons plugin defenitely has bugs.
The idea is to make *one* plugin that does everything concerned with autoclosing. Also this plugin substitutes autoclose feature in Geany itself that works very strange too.
OK. I'll have a look at the PR and after a short review most likely I will merge them. But there is one this you have com promise: Please check with the other plugin authors here, maybe on PM, to consolidate the enclosing things. I don't want to have three or more plugins sharing the same features and none of them is working 100%.
Also there are some plugins I saw in IRC and ML but your team didn't include them into Geany and noboby know about them.
Unfortunately the old issue... There is a life beside Geany ;)D
Cheers, Frank
Users mailing list Users@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/users