Jay and Nick,
I used the scintilla176.tgz archive.
When I was trying to get things working, I did rearrange the define values for R files for some reason I no longer recall. I've updated the patch using the original order of R defines, tested that it applies to version 0.14, rebuilt Geany and verified syntax highlighting works. Same URL as the original patch.
Andrew
On Thu, 2008-09-25 at 10:04 -0700, Jason Oster wrote:
The defines in SciLexer.h should never change between Scintilla versions. This would cause API breakage, which I believe is [generally] against Niel's update policy.
Andrew, if you made any changes to those defines (other than additions) please consider reverting those changes back to the original settings.
I understand the problem from a personal perspective; I've been adding extra functionality to the CSS lexer, and it's a pain to see things like the style definitions and keyword lists all arranged out of any sort of logical order. But in practice, I have no choice but leaving those alone unless I want to risk breaking backward compatibility. :(
Jay
Nick Treleaven wrote:
On Fri, 19 Sep 2008 21:09:45 -0400 Andrew Rowland weibullguy@charter.net wrote:
The following is the resulting patch against version 0.14:
http://svn.cross-lfs.org/svn/repos/patches/geany/geany-0.14-R_highlighting-1...
Thanks, I'll look at porting it into SVN. BTW which version of Scintilla did you take LexR.cxx from? I'm a bit puzzled as to why some of the SciLexer.h define values have changed.
Regards, Nick _______________________________________________ Geany mailing list Geany@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany
Geany mailing list Geany@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany