On Mon, 3 Mar 2008 17:46:33 -0600, "Jeff Pohlmeyer" yetanothergeek@gmail.com wrote:
Hi,
Trying to toggle the case of a rectangular selection currently results in some rather strange results. This patch seems to solve the problem...
thanks for the patch. But I'm not sure whether we should use it because it will break case toggling of any non-Ascii characters. SCI_LOWERCASE and SCI_UPPERCASE don't work with Unicode characters[1] therefore we used GLib's lower/upper case functions. IMO Unicode support is more important than rectangular selection support (I guess there are much more problems with this).
What do you think?
One solution could be to detect whether we have a rectangular selection and then use the Scintilla commands and the GLib commands otherwise. So, rectangular selections will still work with toggle case even though Unicode characters are ignored. But this require that we know we have a rectangular selection.
[1] https://sourceforge.net/tracker/index.php?func=detail&aid=1276699&gr...
Regards, Enrico