On Tue, 19 Feb 2008 13:41:16 -0500, "Daniel Richard G." skunk@iSKUNK.ORG wrote:
Hi,
I just applied the patch, thanks.
On Tue, 2008 Feb 19 10:44:17 +0100, Enrico Tröger wrote:
- c.c: The cpp conditional should first check whether DEBUG_C is actually defined or not, before using it in a conditional expression. This change gets rid of the warning, but what you might want to do instead is just change the #if into an #ifdef. (I couldn't do that without knowing how DEBUG_C is used, so I leave that to you.)
This doesn't really matter. All debug cod in tagmanager isn't used at all. Or at least one have to manually define the DEBUG macros and then the code probably won't compile anymore or other problems may occur. In other words: just ignore everything inside any #ifdef DEBUG #endif contructs in all source files in the tagmanager directory.
Okay. You'll just want to change it to use #ifdef instead of #if, so that you don't get "DEBUG_C is not defined" warnings.
Yes, I changed it.
- prefs.c: No comma after that last entry.
Oops, I recently started doing that to avoid the extra comma change in diffs when appending items. Ah well, another thing to leave out until I'm D programming.
Good point, about the diffs. I suppose you could do something like
enum { FOO , BAR , BAZ }
Bahh, this is ugly. Even worse than having the additional line in a diff because of the comma.
Regards, Enrico