On Sat, 3 Nov 2007 23:59:51 +0200, Yura Siamashka yurand2@gmail.com wrote:
Hi
On Sat, Nov 03, 2007 at 06:57:52PM +0100, Enrico Tröger wrote:
On Sat, 3 Nov 2007 12:50:41 +0200, Yura Siamashka yurand2@gmail.com wrote:
Here is updated version of gitdiff. I had to add document_set_changed function to color tab as unmodified.
To geany devs: Can you commit plugin_add_set_text_changed_function.patch? Any chance to include gitdiff in geany?
I'll add the document_set_changed() to the API, no problem.
Nice, thanks.
Done in SVn r2014.
I'm not sure we should include your plugin, maybe you can just make a tarball and put it on some webspace, similar to how Jeff has it done for his Lua plugin. Maybe, we'll add some autotools stuff to ease work with external plugins.
I guess I will do that. git diff still need some works. (For example don't add anything to menu if you don't have git installed, gray button if you are not in git repositary)
You should also use plugin_fields->flags = PLUGIN_IS_DOCUMENT_SENSITIVE; in init() to automatically disable the menu item if there are no open tabs.
Btw, I like the idea of re-using the already created tab for a new diff on the same file. Maybe this should be ported to the svndiff plugin.
Here is patch. It depend on plugin_add_set_text_changed_function.patch.
Well, I'll leave this to Frank. The plugin was written by him and he should decide whether to use it or not, thanks anyway.
Regards, Enrico