On Fri, 20 Jul 2007 12:51:35 +0200, Enrico Tröger enrico.troeger@uvena.de wrote:
On Thu, 19 Jul 2007 17:45:02 +0100, Nick Treleaven nick.treleaven@btinternet.com wrote:
On 07/19/2007 05:06:58 PM, Enrico Tröger wrote:
On Thu, 19 Jul 2007 17:57:08 +0200, Jean-François Wauthy pollux@xfce.org wrote:
Le jeudi 19 juillet 2007 à 16:47 +0100, Nick Treleaven a écrit :
As a side question, why do you parse the string stored in the treeview instead of simply adding a column storing the line number (as an integer) associated with the symbol in the model and not showing in tree ?
I find it's sometimes useful to see the line number of tags.
Yeah me too but what i meant is the fact that the code of geany
parses
the string instead of simply directly retrieving the line number
from
the tree model, which is quicker. Of course, this requires some changes in the code but should be easy.
Yes it is easy to change. I don't know why I didn't ntoiced this earlier but the code to parse the line number is very old and probably wasn't touched since it was written ;-). Will be changed.
Well, maybe it would make the code a bit neater, but it isn't really going to make a difference in terms of speed, and it saves memory if the line number is already stored in the string. The time it takes Gtk/Scintilla to scroll to the tag line dwarfs the time it takes to parse the string. But I don't mean to start an argument, just my
Sure, the improvement in execution time probably won't be even measurable but I think it is at least cleaner and more readable if we store the line number in the tree store.
Done in SVN r1731.
Regards, Enrico