Hi there i made a patch to implement the highlighter to the lisp language, i would like to know how i can send it for checking and implementing.
thanks.
Hi,
On Mon, 4 Oct 2010 10:30:46 +0100 Mário Silva sharelider@gmail.com wrote:
Hi there i made a patch to implement the highlighter to the lisp language, i would like to know how i can send it for checking and implementing.
There's already a Lisp lexer in the Scintilla project - src/LexLisp.cxx. Maybe you would like to adapt your patch to use it?
Also see: http://geany.org/manual/dev/hacking.html#adding-a-filetype
You can attach patches and submit them here.
Regards, Nick
yes thats what i did, i adapted the lex from scintilla and configured the colors the best i thougt it to be. ok so here it comes.
On Mon, Oct 4, 2010 at 11:16 AM, Nick Treleaven < nick.treleaven@btinternet.com> wrote:
Hi,
On Mon, 4 Oct 2010 10:30:46 +0100 Mário Silva sharelider@gmail.com wrote:
Hi there i made a patch to implement the highlighter to the lisp
language, i
would like to know how i can send it for checking and implementing.
There's already a Lisp lexer in the Scintilla project - src/LexLisp.cxx. Maybe you would like to adapt your patch to use it?
Also see: http://geany.org/manual/dev/hacking.html#adding-a-filetype
You can attach patches and submit them here.
Regards, Nick _______________________________________________ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
On Mon, 4 Oct 2010 11:43:00 +0100 Mário Silva sharelider@gmail.com wrote:
yes thats what i did, i adapted the lex from scintilla and configured the colors the best i thougt it to be. ok so here it comes.
If you made changes to LexLisp.cxx please submit them to the Scintilla project, as otherwise they will get lost when we update Scintilla.
Otherwise, which version of Scintilla did you take it from? Currently we are using Scintilla 2.12 but we'll update after the Geany 0.20 release.
Regards, Nick
hi there again, version is scintilla 221, the changes i did afaik to the lex was only push some constants to the SciLexer.h as you can see in the patch, and change the keywords & keywords_kw local variables to a more apropriate names, the rest is the same, so is not a big deal. oh i forgot to send this file.
On Tue, Oct 5, 2010 at 3:34 PM, Nick Treleaven < nick.treleaven@btinternet.com> wrote:
On Mon, 4 Oct 2010 11:43:00 +0100 Mário Silva sharelider@gmail.com wrote:
yes thats what i did, i adapted the lex from scintilla and configured the colors the best i thougt it to be. ok so here it comes.
If you made changes to LexLisp.cxx please submit them to the Scintilla project, as otherwise they will get lost when we update Scintilla.
Otherwise, which version of Scintilla did you take it from? Currently we are using Scintilla 2.12 but we'll update after the Geany 0.20 release.
Regards, Nick _______________________________________________ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
On Tue, 5 Oct 2010 19:10:53 +0100 Mário Silva sharelider@gmail.com wrote:
hi there again, version is scintilla 221, the changes i did afaik to the lex was only push some constants to the SciLexer.h as you can see in the patch, and change the keywords & keywords_kw local variables to a more apropriate names, the rest is the same, so is not a big deal.
I've committed the patch but with a version of LexLisp.cxx from Scintilla. Please consider sending your changes to the Scintilla project.
oh i forgot to send this file.
filetype_extensions.conf was already in the patch ;-)
Regards, Nick
i understand but i dunno where to summit the changes to the scintilla project, and your commit broken the compile cus some constants and some names are different, im already trying to apply to the group mailing list, please so it doest get broken, consider apply this patch to fix it, and when i can i summit to the scintilla.
On Wed, Oct 6, 2010 at 6:13 PM, Nick Treleaven < nick.treleaven@btinternet.com> wrote:
On Tue, 5 Oct 2010 19:10:53 +0100 Mário Silva sharelider@gmail.com wrote:
hi there again, version is scintilla 221, the changes i did afaik to the
lex
was only push some constants to the SciLexer.h as you can see in the
patch,
and change the keywords & keywords_kw local variables to a more
apropriate
names, the rest is the same, so is not a big deal.
I've committed the patch but with a version of LexLisp.cxx from Scintilla. Please consider sending your changes to the Scintilla project.
oh i forgot to send this file.
filetype_extensions.conf was already in the patch ;-)
Regards, Nick _______________________________________________ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
ups forgot the patch here it comes.
On Thu, Oct 7, 2010 at 7:15 PM, Mário Silva sharelider@gmail.com wrote:
i understand but i dunno where to summit the changes to the scintilla project, and your commit broken the compile cus some constants and some names are different, im already trying to apply to the group mailing list, please so it doest get broken, consider apply this patch to fix it, and when i can i summit to the scintilla.
On Wed, Oct 6, 2010 at 6:13 PM, Nick Treleaven < nick.treleaven@btinternet.com> wrote:
On Tue, 5 Oct 2010 19:10:53 +0100 Mário Silva sharelider@gmail.com wrote:
hi there again, version is scintilla 221, the changes i did afaik to the
lex
was only push some constants to the SciLexer.h as you can see in the
patch,
and change the keywords & keywords_kw local variables to a more
apropriate
names, the rest is the same, so is not a big deal.
I've committed the patch but with a version of LexLisp.cxx from Scintilla. Please consider sending your changes to the Scintilla project.
oh i forgot to send this file.
filetype_extensions.conf was already in the patch ;-)
Regards, Nick _______________________________________________ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
sorry to be spamy here but i saw that the special keywords, mod and mod dispatch style was also commented, was cus it was breaking the build? i have to discuss this to the scintilla devs then when i can, so i know for sure the right tokens to be styled.
On Thu, Oct 7, 2010 at 7:16 PM, Mário Silva sharelider@gmail.com wrote:
ups forgot the patch here it comes.
On Thu, Oct 7, 2010 at 7:15 PM, Mário Silva sharelider@gmail.com wrote:
i understand but i dunno where to summit the changes to the scintilla project, and your commit broken the compile cus some constants and some names are different, im already trying to apply to the group mailing list, please so it doest get broken, consider apply this patch to fix it, and when i can i summit to the scintilla.
On Wed, Oct 6, 2010 at 6:13 PM, Nick Treleaven < nick.treleaven@btinternet.com> wrote:
On Tue, 5 Oct 2010 19:10:53 +0100 Mário Silva sharelider@gmail.com wrote:
hi there again, version is scintilla 221, the changes i did afaik to
the lex
was only push some constants to the SciLexer.h as you can see in the
patch,
and change the keywords & keywords_kw local variables to a more
apropriate
names, the rest is the same, so is not a big deal.
I've committed the patch but with a version of LexLisp.cxx from Scintilla. Please consider sending your changes to the Scintilla project.
oh i forgot to send this file.
filetype_extensions.conf was already in the patch ;-)
Regards, Nick _______________________________________________ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
On Thu, 7 Oct 2010 19:15:47 +0100 Mário Silva sharelider@gmail.com wrote:
i understand but i dunno where to summit the changes to the scintilla project, and your commit broken the compile cus some constants and some names are different, im already trying to apply to the group mailing list, please so it doest get broken, consider apply this patch to fix it, and when i can i summit to the scintilla.
The build is not broken for me. A clean trunk checkout should build fine.
I decided not to apply your lexer changes because they could be lost when we update Scintilla. This is mentioned in the hacking file.
(Unfortunately it's slightly more complicated to submit changes back to Scintilla at the moment because Scintilla changed their lexer property code. If you send them a patch they may be able to adjust it though or explain what changes need making).
BTW one problem with your patch is that it changes the values of the existing Lisp constants, which break Scintilla's ABI.
Regards, Nick
ah i see dint knew about that. i joined the group and im gona create a topic about this. :)
On Fri, Oct 8, 2010 at 3:58 PM, Nick Treleaven < nick.treleaven@btinternet.com> wrote:
On Thu, 7 Oct 2010 19:15:47 +0100 Mário Silva sharelider@gmail.com wrote:
i understand but i dunno where to summit the changes to the scintilla project, and your commit broken the compile cus some constants and some names are different, im already trying to apply to the group mailing
list,
please so it doest get broken, consider apply this patch to fix it, and
when
i can i summit to the scintilla.
The build is not broken for me. A clean trunk checkout should build fine.
I decided not to apply your lexer changes because they could be lost when we update Scintilla. This is mentioned in the hacking file.
(Unfortunately it's slightly more complicated to submit changes back to Scintilla at the moment because Scintilla changed their lexer property code. If you send them a patch they may be able to adjust it though or explain what changes need making).
BTW one problem with your patch is that it changes the values of the existing Lisp constants, which break Scintilla's ABI.
Regards, Nick _______________________________________________ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel