Hi all,
>From discussions elsewhere, such as [1], it sounds like one of the
things holding back Geany development right now is a need for more
testing.
I have some spare time that I can dedicate to exploratory testing of
PRs to Geany and Geany-Plugins. I'm not a QA professional, but I am a
programmer, I use a range of Geany features daily, and I understand
Geany's code.
How can I test PRs in a way that would really help them get merged?
In particular:
1. How can I determine that a PR is mostly blocked on testing, and is
likely to be merged when positive testing results come in? Some PRs
are marked as "approved" in GitHub yet are not merged -- is that it?
2. How can I communicate my results to the satisfaction of Geany
committers? For example, I could write up some kind of a report: an
outline of what I tried, with screenshots of what I got -- would that
help?
Thank you.
[1] https://github.com/geany/geany/pull/1246#issuecomment-290047712
--
Vasiliy
Hi,
you replied only to me, so the others didn't see your answer but will
get it in the quote below.
On 05/25/2017 02:14 PM, Robert Zajda wrote:
> Hi,
>
> Thanks for the answer.
>
> This problem refers to CSS/SASS only.
>
>
> On 25.05.2017 13:55, Enrico Tröger wrote:
>> On 05/16/2017 09:37 AM, Robert Zajda wrote:
>>> Hi,
>>>
>>> There is a patch with SASS support 4 geany available on
>>> http://geany.robert.dvu.pl/.
>> I guess this is related to https://github.com/geany/geany/issues/908 ?
>> It would help a lot if you could provide some more text in the issue,
>> even if you just copy it from your website. Or even better, create pull
>> requests for your patches.
>
> Yes this is related, but this issue is only an info (not a problem)
> about patch.
I just noticed the other patch is about the Scintilla CSS lexer only,
you should report this (if not already done) to the Scintilla project
directly.
>>> There is one problem in latest version.
>>>
>>> Fold level in symbols pane is limited to second level. Can anyone help,
>>> how to change that to be infinity?
>> I don't understand exactly what you mean.
>> In the screenshot attached, I have multiple levels including folding of
>> each level, also below level two.
>>
> Yes it works with python an and php. But I made new CSS/SASS ctags file
> which is based on php file.
> Everything is ok except that fold level is limited. This is limited
> somewhere else in the geany code. I can't find it so i'm asking for help.
Ok.
Without having had a look at the code, I would assume that the
limitation is rather in the CTags parser than in Geany's code as it
works well for other filetypes.
Even if it is in Geany, it is most probably in src/symbols.c.
Regards,
Enrico
--
Get my GPG key from http://www.uvena.de/pub.asc
CodeAi (https://github.com/C0deAi), an automated repair tool developed at
QbitLogic (www.qbitlogic.com), suggested the following fix. Could I submit
it as a patch if it looks alright?
plugins/saveactions.c: “doc->file_type” pointer might be dereferenced when
null on line 283. Initialization may be provided by “doc” passed in as a
function argument, but a null check would be prudent just in case. The fix
checks “doc->file_type” for null before allowing a dereference on the
following line. A snapshot of the bug report generated by CodeAi is
attached. A full report is available upon request.
diff --git a/plugins/saveactions.c b/plugins/saveactions.c
@@ -280,8 +280,10 @@ static void instantsave_document_new_cb(GObject *obj,
GeanyDocument *doc, gpoint
doc->file_name = new_filename;
- if (doc->file_type->id == GEANY_FILETYPES_NONE)
+ if(doc->file_type) {
+ if (doc->file_type->id == GEANY_FILETYPES_NONE)
document_set_filetype(doc,
filetypes_lookup_by_name(instantsave_default_ft));
+ }
/* force saving the file to enable all the related actions(tab name,
filetype, etc.) */
document_save_file(doc, TRUE);
/* force saving the file to enable all the related actions(tab name,
filetype, etc.) */
document_save_file(doc, TRUE);
}
}
Base-commit: 84253714771f48dbc7fab02f7de43f253734dee2
Please let me know if you are interested in seeing more fixes from our
tool. Thanks!
Sincerely,
--
Benjamin Bales
Chief Technology Officer
[image: QbitLogic]
1050 Crown Pointe Pkwy, Ste. 840
Atlanta, GA 30338
470-554-2690
CONFIDENTIALITY NOTICE
This e-mail and any files transmitted with it are confidential and are
intended solely for the use of the individual or entity to which they are
addressed. This communication may contain privileged attorney material or
other Property and Confidential matter. If you are not the intended
recipient or the person responsible for delivering the e-mail for the
intended person, be advised that you have received this e-mail in error and
that any use, dissemination, forwarding, printing, or copying of this
e-mail is strictly prohibited. If you believe you have received this
e-mail in error, please immediately delete this e-mail and notify Benjamin
Bales by telephoning 470-554-2690.
Hi,
There is a patch with SASS support 4 geany available on
http://geany.robert.dvu.pl/.
There is one problem in latest version.
Fold level in symbols pane is limited to second level. Can anyone help,
how to change that to be infinity?
It seems to be not ctags related,
Regards,
Robert
Hi Geany developers,
I'm locally am updating the Verilog parser/creating a SystemVerilog parser with updated keywords and kinds. I don't know if anyone has already started this, but if so, I'd be interested in working off of a base.
Do we have a standard for changing file headers while still attributing original file creation correctly?
Josh Einstein-Curtis