Devel November 2011

devel@lists.geany.org

21 participants
40 discussions

Code review: suggest reorder of condition to put bounds check before use
by Daniel Marjamäki 16 Jul '13

16 Jul '13

Hi! I saw this code in src/symbols.c at line 1917: while (sci_get_style_at(sci, start) != fn_style && start < max_pos) start++; If start >= max_pos then sci_get_style_at will be called (with out of bounds value?) and then the loop will bail out. I suggest that the condition is reordered as: while (start < max_pos && sci_get_style_at(sci, start) != fn_style) start++; Then sci_get_style_at will only be called if start is less than max_pos. It is just my humble suggestion. Best regards, Daniel

3 2

Patches for review
by Jiří Techet 08 Oct '12

08 Oct '12

Hi, I'm sending my stack of patches against geany again, this time as individual patches. Here's the full list: [PATCH 01/19] Prevent -Wmissing-prototypes report warning when compiling a plugin [PATCH 02/19] Add signals for project options dialog opening and closing [PATCH 03/19] Make the project menu accessible by plugins [PATCH 04/19] Make it possible to change project patterns by plugins [PATCH 05/19] Don't be annoying when not necessary [PATCH 06/19] Make it possible for plugins to change the base directory of msgwindow [PATCH 07/19] Open the file in the msgwindow even if no linenumber is specified [PATCH 08/19] When closing tab, return to the document at the top of the MRU list [PATCH 09/19] Use wider entry for project file path [PATCH 10/19] New utils function to get relative path from one directory to another [PATCH 11/19] File name in the project settings dialog shouldn't look it is editable [PATCH 12/19] Use relative paths in the project files [PATCH 13/19] Remove the "set" button from the project properties dialog [PATCH 14/19] Rewrite tab switching queue [PATCH 15/19] Do not insert --include= when the search pattern entry is empty [PATCH 16/19] Use project patterns in the FIF dialog [PATCH 17/19] Make the tab switching dialog a bit more useful [PATCH 18/19] Use standard include paths for "open selected file" [PATCH 19/19] Use per document indent sizes Only some of them are required by gproject - others are just suggestions for improvements. I didn't explicitly distinguish between these two types of patches but it should be pretty clear from the description. There have been some minor changes since my last post - mainly the change of the FIF dialog to contain combo box for pattern selection and there are also some new patches - the detailed description is in the individual emails. Of course many of the patches are suggestions only so further discussion is welcome. Cheers, Jiri

8 68

Request: multithreaded tag generation?
by Harold Aling 04 Jul '12

04 Jul '12

Dear Geany Devs, I recently switched from GeanyPRJ to Gproject. Since Gproject doesn't support multiple open projects I have to switch between projects, but it takes up to 4 minutes to close one project and open another. A project consists of roughly 1000-2000 php-related files. The "Generate tags for all project files" causes this massive delay, but I really need that feature. At work I have a 2-core CPU, where 1 is completely idle and on my desktop at home there are 5 cores are doing nothing while generating tags. Can't they be utilized to speed up the tag generation? Cheers! Harold

8 31

Status of SM-Branch
by Frank Lanitz 31 Mar '12

31 Mar '12

Hi folks, I saw that the SM-branch is merged with trunk on a regular basis, but not sure what's the current status of that branch. Can someone help me out there? Cheers, Frank -- http://frank.uvena.de/en/

2 4

Maintainerrequest: Geany-Mini-Script
by Frank Lanitz 06 Feb '12

06 Feb '12

Hi folks, Unfortunately I didn't heard back of developer of geany-mini-script-plugin so today I like to ask you whether somebody likes to take over maintenance for geany-mini-script plugin inside geany-plugins-svn. It's untouched since maybe 2009 and to be honest I have no idea, what's the current status. Also I'm not 100% whether its still a useful plugin or maybe some other plugin is taking over the task in a better way. Personally I remember it as a possible useful plugin but don't have the resources to look after and used it >>1 year for the last time. If nobody is feeling responsible I suggest, similar to previous plugins, we remove it from official repository. Cheers, Frank -- http://frank.uvena.de/en/

4 16

GIT commit mails format
by Enrico Tröger 25 Jan '12

25 Jan '12

Hey guys, right now, we use the stock email commit hook from Github and let it send commit mails to the geany-commits mailing list. However, compared to the old Subversion commit mails, they are quite different: First, they are not really commit mails but rather "push" mails, that is all commits which are transmitted within one push are combined into one mail instead of one mail per commit as it was previously. Secondly, the commit mails only include the commit message and a link to the commit diff at Github. I personally would prefer to have the diff included (also as before). So, I'm tempted to use something else for sending out commit mails. For example, the Xfce guys have a simple Shell script to do the job and it does it as I would wish: http://git.xfce.org/admin/xfce-git-hooks/tree/hooks/update-03-send-commit-m… An example mail: http://mail.xfce.org/pipermail/xfce4-commits/2011-October/023580.html What do you think? Regards, Enrico -- Get my GPG key from http://www.uvena.de/pub.asc

8 27

Re: [Geany-devel] [Geany] hide menu bar on full-screen
by Pedro Cirne 21 Dec '11

21 Dec '11

Of course I can give a hand! But wouldn't be dangerous hide menu bar in normal view? I think some people could get stuck after that! It has happened with amarok some years ago until developers remove the functionality. On Sat, Oct 22, 2011 at 11:38 PM, Matthew Brush <mbrush(a)codebrainz.ca>wrote: > Hi, > > Is there any chance we could not commit this since I'll have to re-convert > the old Glade 2 file to Glade 3/GtkBuilder again? Once the switch is > complete I can hand-port the changes here. > > @Pedro > I hate to cause extra effort since we appreciate when people can help out > but would it be possible for you to post this to the patch tracker[1] so > that it doesn't get lost? > > Also, it would be cool to generally add options to show/hide the menu bar > and the status bar, whether in fullscreen or not. There's already a feature > request[2] about the status bar. > > Cheers, > Matthew Brush > > [1] https://sourceforge.net/**tracker/?group_id=153444&atid=**787793<https://sourceforge.net/tracker/?group_id=153444&atid=787793> > [2] https://sourceforge.net/**tracker/index.php?func=detail&** > aid=3131862&group_id=153444&**atid=787794<https://sourceforge.net/tracker/index.php?func=detail&aid=3131862&group_id=…> > > > On 11-10-22 03:19 PM, Pedro Cirne wrote: > >> "& ui_prefs.fullscreen" was redundant, state brings "ui_prefs.fullscreen >> & interface_prefs.hide_menubar_**on_fullscreen" from caller. Now with >> tabs..I think it's ok! >> >> On Sat, Oct 22, 2011 at 6:03 PM, Dimitar Zhekov >> <dimitar.zhekov(a)gmail.com <mailto:dimitar.zhekov@gmail.**com<dimitar.zhekov(a)gmail.com>>> >> wrote: >> >> On Thu, 20 Oct 2011 12:43:15 +0100 >> Pedro Cirne <pedro(a)cirne100.eu <mailto:pedro@cirne100.eu>> wrote: >> >> > Here it is...I hope it's useful! >> > >> > On Thu, Oct 20, 2011 at 1:55 AM, Lex Trotman <elextr(a)gmail.com >> <mailto:elextr@gmail.com>> wrote: >> > >> > > On 20 October 2011 11:39, Pedro Cirne <pedro(a)cirne100.eu >> <mailto:pedro@cirne100.eu>> wrote: >> > > > I have edited the source code to make it works for me, is it >> useful for >> > > the >> > > > project? >> > > >> > > If you submit a patch/pull request we will certainly have a look >> at >> > > it. Then you may not have to keep applying it each time Geany >> > > upgrades. >> >> Looks fine to me, except that some of the changes are indented with >> spaces instead of tabs. >> >> I'm not quite sure why ui_menubar_showhide() should take a gboolean >> state, check it with & and hide the menu for state = 1 (or TRUE?). It >> may be the most effective way, but writing an extra line or too to make >> the code stupid and simple may be a good idea. >> >> A good thing to have, though I personnaly am not going to use it. >> >> -- >> E-gards: Jimmy >> ______________________________**_________________ >> Geany mailing list >> Geany(a)uvena.de <mailto:Geany@uvena.de> >> https://lists.uvena.de/cgi-**bin/mailman/listinfo/geany<https://lists.uvena.de/cgi-bin/mailman/listinfo/geany> >> >> >> >> >> >> ______________________________**_________________ >> Geany mailing list >> Geany(a)uvena.de >> https://lists.uvena.de/cgi-**bin/mailman/listinfo/geany<https://lists.uvena.de/cgi-bin/mailman/listinfo/geany> >> > > ______________________________**_________________ > Geany mailing list > Geany(a)uvena.de > https://lists.uvena.de/cgi-**bin/mailman/listinfo/geany<https://lists.uvena.de/cgi-bin/mailman/listinfo/geany> >

3 2

Default Snippets
by Lex Trotman 16 Dec '11

16 Dec '11

Hi All, There are problems with the default snippets applying to all documents. It is not possible to add <snippet><tab> in a document even though the snippet is irrelevant to that filetype. A recent conversation on the ML showed problems with the Haskell do snippet and shortly after I hit the problem adding "if<tab>" in a text document (Murphy I guess). Basically having language specific snippets in the default section is just wrong. The current defaults are C or C++ specific so in https://github.com/elextr/geany_stuff/raw/master/snippets.conf I moved them there and to Java, but I understand that other languages may want them as well so I decided to post here before committing. I'll collate suggestions, patches etc then commit. Cheers Lex

5 14

statusbar virtual column
by Dimitar Zhekov 10 Dec '11

10 Dec '11

Hi, As you may have noticed, when cursor is in the "virtual space" (beyond eoln), our status bar always shows the last "real" column. This small patch adds a new %v (and %V) format specification, which displays a "virtual" column number, as if the line extends to the cursor position. I haven't included sci_get_cursor_virtual_space() is the plugin interface for now. Since the virtual position normally requires 3 SSM()-s, and is less likely to be used than the line and column, I placed the calls into add_statusbar_statistics() instead of ui_update_statusbar(). -- E-gards: Jimmy

2 2

Re: [Geany-devel] Indentation using regex (was [PATCH 14/19] Rewrite tab switching queue)
by Jiří Techet 07 Dec '11

07 Dec '11

On Thu, Sep 16, 2010 at 19:27, Thomas Martitz <thomas.martitz(a)student.htw-berlin.de> wrote: > On 16.09.2010 02:23, Lex Trotman wrote: >> >> Hi Jiri, >> >> I couldn't get this to work at all, it printed "calling indent this >> line" all the time but didn't indent :-( >> >> I only had half an hour so I couldn't investigate much. >> > > I have the same experience. Auto-indentation doesn't seem to work anymore > (e.g. when hitting enter after on a line that ends with {, or when typing > }). I have just re-tested it again and it works on my machine (I have forgotten one trace in the code - that's what you see in the console). A quick question: have you read the commit log? This patch makes it possible to specify several regex patterns for every filetype which determine under what condition the indentation is performed. The pattern variables are specified under the [settings] section of the given filetype and their value is the regex to be used. The variables are as follows: * indent_this_line_regex - the match is performed after every keystroke and if the regex matches, the indentation is performed on the current line * indent_next_line_regex - the match is performed only when enter is pressed. The indentation is applied on the next line * unindent_this_line_regex - like indent_this_line_regex but unindents instead * unindent_next_line_regex - like indent_next_line_regex but indents instead Comments and strings are detected from the lexer so these can be ignored inside the patterns. For instance these are very basic rules for GNU indent style: indent_next_line_regex=^.*\\{[[:blank:]]*$ unindent_this_line_regex=^[[:blank:]]*\\}$ indent_this_line_regex=^[[:blank:]]+\\{$ unindent_next_line_regex=^[[:blank:]]*\\}[[:blank:]]*$ By commenting-out the last two lines you get ANSI indentation style. If you replace \\{ and \\} with begin and end, respectively, you get analogous rules for pascal. Notice the double-escaping of { and } - the first escape sequence is for the keyfile ini format (so for the regex itself \\ becomes \). This means that in order to make it work e.g. for C, you have to edit ~/.config/geany/filedefs/filetypes.c (or the corresponding file under /usr/local/share/geany) and add indent_next_line_regex=^.*\\{[[:blank:]]*$ unindent_this_line_regex=^[[:blank:]]*\\}$ indent_this_line_regex=^[[:blank:]]+\\{$ unindent_next_line_regex=^[[:blank:]]*\\}[[:blank:]]*$ under the [settings] section (+ restart geany). Please let me know if it works (but also in the opposite case ;-). Jiri > > Best regards. > _______________________________________________ > Geany-devel mailing list > Geany-devel(a)uvena.de > http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel >

6 35

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

Devel November 2011