Hi,
I'm afraid we need to remove the Webkit-related plugins (Webhelper,
Markdown Preview) from the Windows installer.
This is because Webkit itself is going to be removed from MSYS2:
https://github.com/Alexpux/MINGW-packages/issues/4318
For the upcoming release we could ship the previous version of Webkit
along with the locally cached old version of ICU (i.e. we will ship ICU
61 *and* 62 in the installer).
But I personally would prefer removing the plugins from the Windows
installer immediately for the reasons mentioned in
https://github.com/Alexpux/MINGW-packages/issues/4318#issuecomment-436443226
and to prevent us from shipping two ICU versions which bloats the
Windows installer even more.
If there are no objections, I will remove all Webkit-related settings
from the Windows installer next week.
Regards,
Enrico
Hi All,
OK, after further research I have stumbled on the answer:
As well as adding the GEANY_API_SYMBOL macro to the function definition, the function declaration in keybindings.h also needs to be moved from the
#ifdef GEANY_PRIVATE
section, into the 'public' section. Dereffing the returned pointer then works fine.
I expect this is documented somewhere, though I haven't found it. Thanks to all for not responding with 'RTFM'. :)
Cheers,
Austin.
Hi All,
I'm new to Geany hacking, so please be kind in your response to possibly dumb question.
Trying to make changes to "addons" plugin, and found that I needed to call keybindings_get_core_group(), so added the GEANY_API_SYMBOL to that function and rebuilt Geany. It appeared to work, in that it returned a pointer,but when I tried to access the structure members pointed to, it segfaulted. Adding diagnostics to the keybindings_get_core_group function, found that I could access the structure members while still in that function. Displayed the value of the pointer, both in the function and on return to my caller; they were identical. (See code samples below) So: the pointer apparently only works in its originating context. Curious as to what's happening here. Is there more to do than just adding GEANY_API_SYMBOL? Or is it to do with keybindings_get_core_group being in a shared library?
Geany version:
geany 1.33 (git >= 63257599) (built on 2019-08-23 with GTK 3.22.30, GLib 2.56.4)
OS version:
Linux kernel 4.15.0-58-generic 64-bit Ubuntu x86_64
Example code:
In my calling function:
key_group_clipboard = keybindings_get_core_group(GEANY_KEY_GROUP_CLIPBOARD);
g_printf("Ptr: %0X\n", key_group_clipboard);
gchar* s = key_group_clipboard->name; // segfaults
In keybindings_get_core_group():
key_group = &groups[id];
gchar* s = key_group->name; // works fine
g_printf("Ptr: %0X, Name: %s\n", key_group, s);
// displays same ptr as in caller, and correct name string
BTW, found that I didn't need to call keybindings_get_core_group after all, achieved the results I wanted by other means. But would still like to know what's wrong.
Thanks in advance,
Austin.
Dear Geany developers,
I have developed a version of the Geany with native support for the GIBIANE language. The git patch is attached and has been tested with the latest version of Geany (commit 9c91c287803ae05ce0f2aacd605564301e0ef4aa).
What is the GIBIANE language ?
The GIBIANE language is the language to control the Cast3M Software.
Cast3M ( http://www-cast3m.cea.fr/ ) is a finite element software for structural and fluid mechanics.
It is developed by the Department for Modelling Systems and Structures (DM2S) from the French Alternative Energies and Atomic Energy Commission ( CEA http://www.cea.fr/english ), and it is widely used around the world.
In Cast3M, the user have access to all source code that control algorithms for mechanics calculations.
I and the Cast3M team, would be very grateful if you accept to add the GIBIANE native support to the official Geany version.
If you have any questions or suggestions, please come back to me.
Sincerely,
Thibault LINDECKER,
The Cast3M support.
[cid:image001.png@01D54847.920C3890]
Hello,
Thank you for your reply. I will open a pull request on GitHub.
Sincerely,
Thibault LINDECKER,
The Cast3M support.
[cid:image001.png@01D54BA1.CFD4B820]
-----Message d'origine-----
De : Devel [mailto:devel-bounces@lists.geany.org] De la part de Matthew Brush
Envoyé : samedi 3 août 2019 02:00
À : devel(a)lists.geany.org
Objet : Re: [Geany-Devel] New language in Geany
On 2019-08-01 12:41 a.m., KK2000 wrote:
> Dear Geany developers,
>
> I have developed a version of the Geany with native support for the GIBIANE language. The git patch is attached and has been tested with the latest version of Geany (commit 9c91c287803ae05ce0f2aacd605564301e0ef4aa).
>
> What is the GIBIANE language ?
> The GIBIANE language is the language to control the Cast3M Software.
> Cast3M ( http://www-cast3m.cea.fr/ ) is a finite element software for structural and fluid mechanics.
> It is developed by the Department for Modelling Systems and Structures (DM2S) from the French Alternative Energies and Atomic Energy Commission ( CEA http://www.cea.fr/english ), and it is widely used around the world.
> In Cast3M, the user have access to all source code that control algorithms for mechanics calculations.
>
> I and the Cast3M team, would be very grateful if you accept to add the GIBIANE native support to the official Geany version.
>
> If you have any questions or suggestions, please come back to me.
>
Nice work! We usually do pull requests on Github these days since it's harder to get lost and easier to see the individual changes than one big patch. Would it be possible to open a pull request on Github for this?
If the language is reasonably popular, it seems likely nobody would object to including it into core.
One thing with Geany is that the project has a policy of upstreaming changes to the libraries/other projects it uses, so new Ctags parsers and Scintilla lexers get merged upstream and then get pulled back down into Geany. This makes sure we don't hoard contributions as well as facilitates synchronizing the code between projects.
Regards,
Matthew Brush
_______________________________________________
Devel mailing list
Devel(a)lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel