I saw this code in src/symbols.c at line 1917:
while (sci_get_style_at(sci, start) != fn_style
&& start < max_pos) start++;
If start >= max_pos then sci_get_style_at will be called (with out of
bounds value?) and then the loop will bail out.
I suggest that the condition is reordered as:
while (start < max_pos
&& sci_get_style_at(sci, start) != fn_style)
Then sci_get_style_at will only be called if start is less than max_pos.
It is just my humble suggestion.
I'm sending my stack of patches against geany again, this time as individual patches. Here's the full list:
[PATCH 01/19] Prevent -Wmissing-prototypes report warning when compiling a plugin
[PATCH 02/19] Add signals for project options dialog opening and closing
[PATCH 03/19] Make the project menu accessible by plugins
[PATCH 04/19] Make it possible to change project patterns by plugins
[PATCH 05/19] Don't be annoying when not necessary
[PATCH 06/19] Make it possible for plugins to change the base directory of msgwindow
[PATCH 07/19] Open the file in the msgwindow even if no linenumber is specified
[PATCH 08/19] When closing tab, return to the document at the top of the MRU list
[PATCH 09/19] Use wider entry for project file path
[PATCH 10/19] New utils function to get relative path from one directory to another
[PATCH 11/19] File name in the project settings dialog shouldn't look it is editable
[PATCH 12/19] Use relative paths in the project files
[PATCH 13/19] Remove the "set" button from the project properties dialog
[PATCH 14/19] Rewrite tab switching queue
[PATCH 15/19] Do not insert --include= when the search pattern entry is empty
[PATCH 16/19] Use project patterns in the FIF dialog
[PATCH 17/19] Make the tab switching dialog a bit more useful
[PATCH 18/19] Use standard include paths for "open selected file"
[PATCH 19/19] Use per document indent sizes
Only some of them are required by gproject - others are just suggestions for improvements. I didn't explicitly distinguish between these two types of patches but it should be pretty clear from the description. There have been some minor changes since my last post - mainly the change of the FIF dialog to contain combo box for pattern selection and there are also some new patches - the detailed description is in the individual emails. Of course many of the patches are suggestions only so further discussion is welcome.
Dear Geany Devs,
I recently switched from GeanyPRJ to Gproject. Since Gproject doesn't
support multiple open projects I have to switch between projects, but
it takes up to 4 minutes to close one project and open another. A
project consists of roughly 1000-2000 php-related files.
The "Generate tags for all project files" causes this massive delay,
but I really need that feature.
At work I have a 2-core CPU, where 1 is completely idle and on my
desktop at home there are 5 cores are doing nothing while generating
tags. Can't they be utilized to speed up the tag generation?
I saw that the SM-branch is merged with trunk on a regular basis, but
not sure what's the current status of that branch. Can someone help me
On Tue, Jan 3, 2012 at 13:44, Matthew Brush <mbrush(a)codebrainz.ca> wrote:
> I already ported all of the existing old-style color schemes to work with
> the new filedefs, see the geany-themes project on Github to get them.
> Some might need a little tweaking, but should for the most part be quite
> similar to the original ones.
Unfortunately, the 'dark' scheme needs some serious tweaking to make
it look like I'm used to (it's very brownish dull right now), but I
guess some well-placed copy/paste actions will solve that for me! ;)
Armed with a screenshot of the old scheme, dark.conf, an old
filetypes.* file and the documentation I'll try to recreate the old
Now that the geany-plugins has been converted to Git, I thought I'd post
this patch that adds the feature I've been working on (wrapping text with
characters) to the Addons plugin. Any chance of it being added?
And I've never really used Git before too, so please let me know if the
patch is incorrectly made or something.
I'm experiencing a bug where the project properties dialog is empty
when opened for the second time. Steps to reproduce:
1. Open project properties dialog.
2. Close it.
3. Open it for the second time.
Result: the project properties dialog is much smaller and it's empty.
I suspect it's related to the GtkBuiler transition. I haven't looked
into it because I guess Matthew knows better what might be wrong.
On Fri, Jan 27, 2012 at 2:42 AM, Nick Treleaven <git-noreply(a)geany.org> wrote:
> Branch: refs/heads/master
> Author: Nick Treleaven <nick.treleaven(a)btinternet.com>
> Committer: Nick Treleaven <nick.treleaven(a)btinternet.com>
> Date: Thu, 26 Jan 2012 15:42:06
> Commit: 7cc443e1420b77d041815a464fe5b20bc62412f4
> Log Message:
> Don't append file truncation warning if file doesn't exist
> This warning shown after a failed save is unnecessary when the
> filename is invalid.
> Modified Paths:
> Modified: src/document.c
> 3 files changed, 2 insertions(+), 1 deletions(-)
> @@ -1766,7 +1766,8 @@ gboolean document_save_file(GeanyDocument *doc, gboolean force)
> ui_set_statusbar(TRUE, _("Error saving file (%s)."), errmsg);
> - if (!file_prefs.use_safe_file_saving)
> + if (!file_prefs.use_safe_file_saving &&
> + g_file_test(locale_filename, G_FILE_TEST_IS_REGULAR))
If writing a remote file failed half way because of a network failure,
then if the network is still faulty when we g_file_test for a regular
file, it will fail because the file doesn't exist, but the partly
written file may (is likely to) be truncated.
> g_strdup_printf(_("%s\n\nThe file on disk may now be truncated!"), errmsg));
> This E-Mail was brought to you by github_commit_mail.py (Source: TBD).
> Geany-commits mailing list
Unfortunately I didn't heard back of developer of
geany-mini-script-plugin so today I like to ask you whether somebody
likes to take over maintenance for geany-mini-script plugin inside
geany-plugins-svn. It's untouched since maybe 2009 and to be honest I
have no idea, what's the current status. Also I'm not 100% whether its
still a useful plugin or maybe some other plugin is taking over the
task in a better way. Personally I remember it as a possible useful
plugin but don't have the resources to look after and used it >>1 year
for the last time.
If nobody is feeling responsible I suggest, similar to previous plugins,
we remove it from official repository.