Devel June 2012

devel@lists.geany.org

16 participants
26 discussions

Code review: suggest reorder of condition to put bounds check before use
by Daniel Marjamäki 16 Jul '13

16 Jul '13

Hi! I saw this code in src/symbols.c at line 1917: while (sci_get_style_at(sci, start) != fn_style && start < max_pos) start++; If start >= max_pos then sci_get_style_at will be called (with out of bounds value?) and then the loop will bail out. I suggest that the condition is reordered as: while (start < max_pos && sci_get_style_at(sci, start) != fn_style) start++; Then sci_get_style_at will only be called if start is less than max_pos. It is just my humble suggestion. Best regards, Daniel

3 2

Remove MSYS dependency of Geany on Win~1
by Dimitar Zhekov 12 Dec '12

12 Dec '12

Hi, Now that 1.22 is out, how about removing the MSYS build dependency under Win~1? I tried to compile Geany with the default MinGW make, without any MSYS, and there were some easily fixable problems: cd foo && $(MAKE) -f makefile.win32 && cd ..\.. does not work, probably requires some sh. But if we depend on GNU make (which seems to be the case, since we're using ifdef/else/endif), it's easier and shorter to: $(MAKE) -C foo -f makefile.win32 Linking does not work, because the stock make supports \ only for variables, not commands. But that's even easier to fix: STLIBS = ../scintilla/scintilla.a ../tagmanager/tagmanager.a ../tagmanager/mio/mio.a $(TARGET): $(OBJS) $(RES) $(STLIBS) $(CXX) $(OBJS) $(RES) -o $(TARGET) $(STLIBS) $(ALL_GTK_LIBS) $(WIN_LIBS) with the added benefit that static library names are not repeated literally. There is also some inconsistency: CP = copy, but "cp -r" and "cp" at the end of makefile. The install target can be rewritten as several -$(MD) and non-recursive $(CP) commands, and no MSYS will be required. RFC. If we consider this worthy, I can make the required changes. -- E-gards: Jimmy

5 37

[PATCH] File saving dialog behavior
by Quentin Glidic 09 Nov '12

09 Nov '12

Hello, Attached a little patch concerning the file saving dialog. I may have missed some use cases, but it works on all cases mentioned in the commit message. The main point is about the âRenameâ, the unsaved file one (last commit message line) is a bonus. Cheers, -- Quentin "Sardem FF7" Glidic

4 7

Patches for review
by Jiří Techet 08 Oct '12

08 Oct '12

Hi, I'm sending my stack of patches against geany again, this time as individual patches. Here's the full list: [PATCH 01/19] Prevent -Wmissing-prototypes report warning when compiling a plugin [PATCH 02/19] Add signals for project options dialog opening and closing [PATCH 03/19] Make the project menu accessible by plugins [PATCH 04/19] Make it possible to change project patterns by plugins [PATCH 05/19] Don't be annoying when not necessary [PATCH 06/19] Make it possible for plugins to change the base directory of msgwindow [PATCH 07/19] Open the file in the msgwindow even if no linenumber is specified [PATCH 08/19] When closing tab, return to the document at the top of the MRU list [PATCH 09/19] Use wider entry for project file path [PATCH 10/19] New utils function to get relative path from one directory to another [PATCH 11/19] File name in the project settings dialog shouldn't look it is editable [PATCH 12/19] Use relative paths in the project files [PATCH 13/19] Remove the "set" button from the project properties dialog [PATCH 14/19] Rewrite tab switching queue [PATCH 15/19] Do not insert --include= when the search pattern entry is empty [PATCH 16/19] Use project patterns in the FIF dialog [PATCH 17/19] Make the tab switching dialog a bit more useful [PATCH 18/19] Use standard include paths for "open selected file" [PATCH 19/19] Use per document indent sizes Only some of them are required by gproject - others are just suggestions for improvements. I didn't explicitly distinguish between these two types of patches but it should be pretty clear from the description. There have been some minor changes since my last post - mainly the change of the FIF dialog to contain combo box for pattern selection and there are also some new patches - the detailed description is in the individual emails. Of course many of the patches are suggestions only so further discussion is welcome. Cheers, Jiri

8 68

Introduction
by Jacob Strohm 15 Jul '12

15 Jul '12

Hello all, I'm interested in beginning to contribute to Geany. I'm a freshman CS major and I often find myself with way too much free time and needing something productive to do. As I've enjoyed using Geany, its something I'd like to get involved in. However, open source (and projects in general written by more than 2 people) is new to me, so I'll probably take it slow for a while. Any advice is greatly appreciated. Thanks, Jacob

4 3

ANN: Geany-Themes 1.22 Released
by Matthew Brush 06 Jul '12

06 Jul '12

Hi, I've made a tarball and zip release for Geany-Themes 1.22 file at: https://github.com/codebrainz/geany-themes/downloads Highlights: * Improved Solarized light and dark schemes (thanks Joshua Hoff) * Improved Gedit theme (thanks Jean-Philippe Fleury) * Improved Dark theme (thanks Harold Aling) * Remove Alternate (alt.conf) theme since it's shipped with Geany now * Updated credits and licensing information I'm hoping to make the releases/tarballs somewhat predictable to make it easier for distro package maintainers who want to create Geany-Themes packages. The main version number will follow Geany's and releases in between Geany releases will have a micro number like 1.22.1, 1.22.2, etc. Let me know if this format is going to work out or if there's any other files or something I need to add or re-format to simplify building packages. If anyone has any original or ported themes they want to include in Geany-Themes, make a pull request or Github or just email it to me or whatever. Cheers, Matthew Brush

3 2

Request: multithreaded tag generation?
by Harold Aling 04 Jul '12

04 Jul '12

Dear Geany Devs, I recently switched from GeanyPRJ to Gproject. Since Gproject doesn't support multiple open projects I have to switch between projects, but it takes up to 4 minutes to close one project and open another. A project consists of roughly 1000-2000 php-related files. The "Generate tags for all project files" causes this massive delay, but I really need that feature. At work I have a 2-core CPU, where 1 is completely idle and on my desktop at home there are 5 cores are doing nothing while generating tags. Can't they be utilized to speed up the tag generation? Cheers! Harold

8 31

Geany-Plugins: String freeze for 1.22 release
by Frank Lanitz 27 Jun '12

27 Jun '12

Hi translators and friends of Geany, After 1.22 release of Geany we are on final road to release also Geany-Plugins 1.22. The list of changes done for this release is long and so a lot of string have changed or were added. I like to ask all translators to check the translations. I'd be very happy if you could send a patch, a pull request or single file with translation to either the geany-i18n mailing list or direct to me within the next two weeks so we can include it to the next release. Deadline will be 2012-07-07. To make it more easy for you I've already uploaded updated versions of the po files (and now this is new) to git master as well as 1.22_release-branch at github. You can either download the direct via web or by cloning the repository from https://github.com/geany/geany-plugins This can be done e.g. with git clone https://github.com/geany/geany-plugins.git Also at http://i18n.geany.org/plugins are statistics and daily updated files available. As mentioned before, we are trying to have all translations complete by 2012-07-07. If your language was translated by two or more in past, please double check directly with them or by pinging me, so we don't need to translate same things two or three times. Also please feel to ping me for every question or if you like to start a new translation for an unsupported language. Thanks and happy translating Frank

1 0

Crash when pasting a Zero-width space
by Harold Aling 27 Jun '12

27 Jun '12

A collegue of mine needed a zero-width space[1] for a breaking a word at a specific place in the menu of a website, so I copy/pasted mA (last character of first line, first character of next line) from the Wikipedia example, pasted it in Geany and deleted the m and the A so that there would only be a zero-width space left to copy by using ctrl-a, ctrl-c. Geany however crashed when there was only a zero-width space left in the document ;) Dunno if this is worth looking at, though ;) Cheers! Harold [1] http://en.wikipedia.org/wiki/Zero-width_space

3 11

Does "marker_translucency" work?
by Matthew Brush 25 Jun '12

25 Jun '12

Hi, I'm writing up some info on colour schemes and through testing it seems that "marker_translucency" doesn't do anything. Can anyone test to confirm? It says in the manual and filetypes.common file that it's supposed to control the translucency of the line markers (first arg) and the search indicators (second arg), but it seems that the line marker is hardcoded to fully opaque and that the search indicator is hardcoded to a fixed translucency level (not fully opaque). It's entirely possible I'm missing (or misunderstanding) something. Cheers, Matthew Brush

2 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

Devel June 2012