On Tue, 18 Nov 2008 17:03:15 +0000 eht16@users.sourceforge.net wrote:
Revision: 3244 http://geany.svn.sourceforge.net/geany/?rev=3244&view=rev Author: eht16 Date: 2008-11-18 17:03:15 +0000 (Tue, 18 Nov 2008)
Log Message:
Remove forced size requests for the tab close icon as it seems not necessary and broke the icon on Windows.
Although I'm not bothered at the moment, this commit makes the tab bar taller by about 8-10 pixels on my machine. But on my laptop the tab close button was slightly cropped before, haven't tried the new code yet though.
Regards, Nick
On Thu, 20 Nov 2008 16:42:35 +0000, Nick Treleaven nick.treleaven@btinternet.com wrote:
On Tue, 18 Nov 2008 17:03:15 +0000 eht16@users.sourceforge.net wrote:
Revision: 3244 http://geany.svn.sourceforge.net/geany/?rev=3244&view=rev Author: eht16 Date: 2008-11-18 17:03:15 +0000 (Tue, 18 Nov 2008)
Log Message:
Remove forced size requests for the tab close icon as it seems not necessary and broke the icon on Windows.
Although I'm not bothered at the moment, this commit makes the tab bar taller by about 8-10 pixels on my machine. But on my laptop the tab close button was slightly cropped before, haven't tried the new code yet though.
Weird. But at least the old code broke the icon on Windows completely, there it was only a little dot. Now it is shown properly (on my system at least).
The current code is pretty much the same as what Midori and Gedit are using so I thought it might be safe and works on most systems.
Nick, could you check which value GTK_ICON_SIZE_MENU has on your system?
Does anyone else have problems with the tab close icon size?
Regards, Enrico
On Fri, 21 Nov 2008 15:35:30 +0100 Enrico Tröger enrico.troeger@uvena.de wrote:
But at least the old code broke the icon on Windows completely, there it was only a little dot. Now it is shown properly (on my system at least).
Yes, so it is better than before.
The current code is pretty much the same as what Midori and Gedit are using so I thought it might be safe and works on most systems.
Maybe it works OK on newer GTK versions, I have 2.8 here. My GEdit is 2.14 and it has a cropped close button. But if it works fine on newer GTK versions, I say lets just leave it at that. It might be impossible to get it perfect on all gtk versions.
Nick, could you check which value GTK_ICON_SIZE_MENU has on your system?
Not sure how to do that.
Regards, Nick
On Fri, 21 Nov 2008 16:43:45 +0000, Nick Treleaven nick.treleaven@btinternet.com wrote:
The current code is pretty much the same as what Midori and Gedit are using so I thought it might be safe and works on most systems.
Maybe it works OK on newer GTK versions, I have 2.8 here. My GEdit is 2.14 and it has a cropped close button. But if it works fine on newer GTK versions, I say lets just leave it at that. It might be impossible to get it perfect on all gtk versions.
As Colomban confirmed, it happens also with newer GTK versions. I'm using 2.14 but on Windows I used 2.12 to test this. Anyway, I added back the sizing code for non-Windows systems, so it should work at least as good as before. If it doesn't, the change to use gtk_button_set_image() seems to be involved.
Nick, could you check which value GTK_ICON_SIZE_MENU has on your system?
Not sure how to do that.
See the attached file. By default the menu icon size is 16x16, probably you have the same value. I'm still not sure what's causing the different behaviour.
Regards, Enrico
On Sun, 23 Nov 2008 17:10:52 +0100 Enrico Tröger enrico.troeger@uvena.de wrote:
As Colomban confirmed, it happens also with newer GTK versions. I'm using 2.14 but on Windows I used 2.12 to test this. Anyway, I added back the sizing code for non-Windows systems, so it should work at least as good as before.
The button is now the right size again, thanks...
If it doesn't, the change to use gtk_button_set_image() seems to be involved.
...but now the image on the button is aligned to the right, instead of being centred (but with the button still aligned to the right of the tab).
Nick, could you check which value GTK_ICON_SIZE_MENU has on your system?
Not sure how to do that.
See the attached file. By default the menu icon size is 16x16, probably you have the same value. I'm still not sure what's causing the different behaviour.
OK, it is 16x16. I'm using a ClearLooks-like theme which has rounded buttons.
Regards, Nick
On Mon, 24 Nov 2008 13:04:57 +0000, Nick Treleaven nick.treleaven@btinternet.com wrote:
On Sun, 23 Nov 2008 17:10:52 +0100 Enrico Tröger enrico.troeger@uvena.de wrote:
As Colomban confirmed, it happens also with newer GTK versions. I'm using 2.14 but on Windows I used 2.12 to test this. Anyway, I added back the sizing code for non-Windows systems, so it should work at least as good as before.
The button is now the right size again, thanks...
If it doesn't, the change to use gtk_button_set_image() seems to be involved.
...but now the image on the button is aligned to the right, instead of being centred (but with the button still aligned to the right of the tab).
Should be fixed in SVN.
Regards, Enrico
On Sat, 29 Nov 2008 13:48:51 +0100 Enrico Tröger enrico.troeger@uvena.de wrote:
...but now the image on the button is aligned to the right, instead of being centred (but with the button still aligned to the right of the tab).
Should be fixed in SVN.
Thanks, works fine now.
Regards, Nick
Enrico Tröger a écrit :
On Thu, 20 Nov 2008 16:42:35 +0000, Nick Treleaven nick.treleaven@btinternet.com wrote:
On Tue, 18 Nov 2008 17:03:15 +0000 eht16@users.sourceforge.net wrote:
Revision: 3244 http://geany.svn.sourceforge.net/geany/?rev=3244&view=rev Author: eht16 Date: 2008-11-18 17:03:15 +0000 (Tue, 18 Nov 2008)
Log Message:
Remove forced size requests for the tab close icon as it seems not necessary and broke the icon on Windows.
Although I'm not bothered at the moment, this commit makes the tab bar taller by about 8-10 pixels on my machine. But on my laptop the tab close button was slightly cropped before, haven't tried the new code yet though.
Weird. But at least the old code broke the icon on Windows completely, there it was only a little dot. Now it is shown properly (on my system at least).
The current code is pretty much the same as what Midori and Gedit are using so I thought it might be safe and works on most systems.
Nick, could you check which value GTK_ICON_SIZE_MENU has on your system?
Does anyone else have problems with the tab close icon size?
Regards, Enrico
Hi,
On my system (Debian Lenny using an ubuntulooks-based theme, GTK 2.12) the tabs are now 4 pixels taller than GEdit's or gnome-terminal's ones (29px vs 25px). GEdit's close icons are cropped but gnome-terminal ones are not.
For me ICON_SIZE_MENU seems to be 16×16 (according to the GDK Window's size of a rendered stock image).
Regards, Colomban