On Fri, 19 Nov 2010 08:20:58 +1100 Lex Trotman elextr@gmail.com wrote:
On 19 November 2010 06:04, Nick Treleaven nick.treleaven@btinternet.com wrote:
On Mon, 15 Nov 2010 08:57:51 +1100 Lex Trotman elextr@gmail.com wrote:
I think either:
- unsafe_save_backup should be renamed to gio_unsafe_save_backup to
avoid confusion.
Ok, attached.
Applied, thanks. I put the new pref field last just in case anyone is accessing the other fields from a plugin.
- call the pref make_backup and make it work for all save
implementations, and maybe have a GUI option for it.
To do this we would almost be writing the whole of GIO with the algorithm I outlined previously. So we probably should do that instead. For now lets just offer this easy option that provides improved performance on remote filesystems.
Fine with just the patch. I was only suggesting copying the existing file first for the backup when using non-gio saving.
Nick