Branch: refs/heads/elextr-patch-3 Author: elextr elextr@gmail.com Committer: GitHub noreply@github.com Date: Fri, 12 Jan 2018 21:58:03 UTC Commit: 9e052ae0366f6c5c36b47ba7767b70d2e8e6c210 https://github.com/geany/geany/commit/9e052ae0366f6c5c36b47ba7767b70d2e8e6c2...
Log Message: ----------- Remove requirement to fail build on aggregate return
Returning large aggregates as values is a potential performance problem, but preventing all aggregate returns is inappropriate because:
1. returning small aggregates that are mostly handled as complete objects as return values often makes code clearer.
2. Modern (well not so modern actually) ABIs allow for small aggregates to be returned in registers, so forcing all returns to memory is actually likely to be slower.
3. if code review does not notice a large aggregate return and nobody notices a performance issue then it doesn't matter
Modified Paths: -------------- .travis.yml
Modified: .travis.yml 2 lines changed, 1 insertions(+), 1 deletions(-) =================================================================== @@ -21,7 +21,7 @@ install: - sudo apt-get install -y --no-install-recommends doxygen - sudo apt-get install -y python-lxml before_script: - - export CFLAGS="-g -O2 -Werror=pointer-arith -Werror=aggregate-return -Werror=implicit-function-declaration" + - export CFLAGS="-g -O2 -Werror=pointer-arith -Werror=implicit-function-declaration" script: - NOCONFIGURE=1 ./autogen.sh - >
-------------- This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).