Revision: 1333 http://svn.sourceforge.net/geany/?rev=1333&view=rev Author: ntrel Date: 2007-02-25 05:08:01 -0800 (Sun, 25 Feb 2007)
Log Message: ----------- Prevent undefined behaviour when using the Stop command that can kill X when Geany is run from the KDE or Xfce menu (not from a terminal). Should close #1668017.
Modified Paths: -------------- trunk/ChangeLog trunk/src/build.c
Modified: trunk/ChangeLog =================================================================== --- trunk/ChangeLog 2007-02-24 17:08:29 UTC (rev 1332) +++ trunk/ChangeLog 2007-02-25 13:08:01 UTC (rev 1333) @@ -1,3 +1,11 @@ +2007-02-25 Nick Treleaven nick.treleaven@btinternet.com + + * src/build.c: + Prevent undefined behaviour when using the Stop command that can kill + X when Geany is run from the KDE or Xfce menu (not from a terminal). + Should close #1668017. + + 2007-02-24 Enrico Troeger enrico.troeger@uvena.de
* configure.in, Makefile.am, README.I18N, po/intl_stats.sh, po/LINGUAS:
Modified: trunk/src/build.c =================================================================== --- trunk/src/build.c 2007-02-24 17:08:29 UTC (rev 1332) +++ trunk/src/build.c 2007-02-25 13:08:01 UTC (rev 1333) @@ -1516,13 +1516,13 @@ * perforce necessary for just killing a process). But we must use a signal which we can * ignore because the main process get it too, it is declared to ignore in main.c. */
- gint resultpg, result; + gint result;
- // sent SIGQUIT to all the processes to the processes' own process group + g_return_if_fail(*pid > 1); + result = kill(*pid, SIGQUIT); - resultpg = killpg(0, SIGQUIT);
- if (result != 0 || resultpg != 0) + if (result != 0) msgwin_status_add(_("Process could not be stopped (%s)."), g_strerror(errno)); else {
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.