Revision: 5315
http://geany.svn.sourceforge.net/geany/?rev=5315&view=rev
Author: ntrel
Date: 2010-10-21 16:19:06 +0000 (Thu, 21 Oct 2010)
Log Message:
-----------
Rename confusing callback name for prefs dialog response.
Edit comment - use Stash for new 'simple' prefs.
Modified Paths:
--------------
trunk/src/prefs.c
Modified: trunk/src/prefs.c
===================================================================
--- trunk/src/prefs.c 2010-10-21 16:06:53 UTC (rev 5314)
+++ trunk/src/prefs.c 2010-10-21 16:19:06 UTC (rev 5315)
@@ -28,7 +28,7 @@
/*
* Preferences dialog support functions.
- * New prefs should use Stash code in keyfile.c - init_pref_groups().
+ * New 'simple' prefs should use Stash code in keyfile.c - init_pref_groups().
*/
#include <stdlib.h>
@@ -324,7 +324,7 @@
}
-/* note: new prefs should use Stash code in keyfile.c */
+/* note: new 'simple' prefs should use Stash code in keyfile.c */
static void prefs_init_dialog(void)
{
GtkWidget *widget;
@@ -744,9 +744,9 @@
/*
* callbacks
*/
-/* note: new prefs should use Stash code in keyfile.c */
+/* note: new 'simple' prefs should use Stash code in keyfile.c */
static void
-on_prefs_button_clicked(GtkDialog *dialog, gint response, gpointer user_data)
+on_prefs_dialog_response(GtkDialog *dialog, gint response, gpointer user_data)
{
if (response == GTK_RESPONSE_OK || response == GTK_RESPONSE_APPLY)
{
@@ -1670,7 +1670,7 @@
GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER, GTK_ENTRY(ui_lookup_widget(ui_widgets.prefs_dialog, "extra_plugin_path_entry")));
g_signal_connect(ui_widgets.prefs_dialog, "response",
- G_CALLBACK(on_prefs_button_clicked), NULL);
+ G_CALLBACK(on_prefs_dialog_response), NULL);
g_signal_connect(ui_widgets.prefs_dialog, "delete-event",
G_CALLBACK(gtk_widget_hide_on_delete), NULL);
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
Revision: 5306
http://geany.svn.sourceforge.net/geany/?rev=5306&view=rev
Author: ntrel
Date: 2010-10-20 12:11:07 +0000 (Wed, 20 Oct 2010)
Log Message:
-----------
Add 3 bugs to watch out for.
Modified Paths:
--------------
trunk/HACKING
Modified: trunk/HACKING
===================================================================
--- trunk/HACKING 2010-10-20 11:49:50 UTC (rev 5305)
+++ trunk/HACKING 2010-10-20 12:11:07 UTC (rev 5306)
@@ -254,8 +254,11 @@
---------------------
* Forgetting to check *doc->is_valid* when looping through
*documents_array* - instead use *foreach_document()*.
+* Inserting fields into structs in the plugin API instead of appending.
* Not breaking the plugin ABI when necessary.
* Using an idle callback that doesn't check main_status.quitting.
+* Forgetting CRLF line endings on Windows.
+* Not handling Tabs/Spaces indent mode.
Libraries
---------
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.