$ ./autogen.sh ... checking for valac... valac configure: WARNING: no proper vala compiler found configure: WARNING: you will not be able to compile vala source files ... Plugins: MultiTerm: yes
$ make ... make[3]: Entering directory `/home/build/projects/plugins/testing/multiterm/src' VALAC multiterm_la_vala.stamp /bin/bash: valac: command not found make[3]: *** [multiterm_la_vala.stamp] Error 127
I fetched a clean git, just to be sure there's no some older configuration left.
On 14-04-27 05:39 AM, Dimitar Zhekov wrote:
$ ./autogen.sh ... checking for valac... valac configure: WARNING: no proper vala compiler found configure: WARNING: you will not be able to compile vala source files ... Plugins: MultiTerm: yes
$ make ... make[3]: Entering directory `/home/build/projects/plugins/testing/multiterm/src' VALAC multiterm_la_vala.stamp /bin/bash: valac: command not found make[3]: *** [multiterm_la_vala.stamp] Error 127
I fetched a clean git, just to be sure there's no some older configuration left.
Yeah I guess AM_PROG_VALAC() just issues those warnings instead of failing as I'd have expected.
In a perfect world, the generated *.[ch] files would be distributed and when compiling (from tarball at least) no Vala compiler would be required.
Cheers, Matthew Brush
Le 27/04/2014 21:24, Matthew Brush a écrit :
On 14-04-27 05:39 AM, Dimitar Zhekov wrote:
$ ./autogen.sh ... checking for valac... valac configure: WARNING: no proper vala compiler found configure: WARNING: you will not be able to compile vala source files ... Plugins: MultiTerm: yes
$ make ... make[3]: Entering directory `/home/build/projects/plugins/testing/multiterm/src' VALAC multiterm_la_vala.stamp /bin/bash: valac: command not found make[3]: *** [multiterm_la_vala.stamp] Error 127
I fetched a clean git, just to be sure there's no some older configuration left.
Yeah I guess AM_PROG_VALAC() just issues those warnings instead of failing as I'd have expected.
In a perfect world, the generated *.[ch] files would be distributed and when compiling (from tarball at least) no Vala compiler would be required.
That's the very reason why the absence of valac doesn't trigger a failure (hence disabling the plugin): because tarballs include the C sources, and then valac isn't required unless you want to change the Vala source.
I'm not sure what we can do here… maybe magically detect it's not a tarball and then require valac? Not sure.
Regards, Colomban
On 14-04-27 01:08 PM, Colomban Wendling wrote:
Le 27/04/2014 21:24, Matthew Brush a écrit :
On 14-04-27 05:39 AM, Dimitar Zhekov wrote:
$ ./autogen.sh ... checking for valac... valac configure: WARNING: no proper vala compiler found configure: WARNING: you will not be able to compile vala source files ... Plugins: MultiTerm: yes
$ make ... make[3]: Entering directory `/home/build/projects/plugins/testing/multiterm/src' VALAC multiterm_la_vala.stamp /bin/bash: valac: command not found make[3]: *** [multiterm_la_vala.stamp] Error 127
I fetched a clean git, just to be sure there's no some older configuration left.
Yeah I guess AM_PROG_VALAC() just issues those warnings instead of failing as I'd have expected.
In a perfect world, the generated *.[ch] files would be distributed and when compiling (from tarball at least) no Vala compiler would be required.
That's the very reason why the absence of valac doesn't trigger a failure (hence disabling the plugin): because tarballs include the C sources, and then valac isn't required unless you want to change the Vala source.
I'm not sure what we can do here… maybe magically detect it's not a tarball and then require valac? Not sure.
One not great option would be to check-in the generated source.
Cheers, Matthew Brush
On 2014-04-27 22:41, Matthew Brush wrote:
On 14-04-27 01:08 PM, Colomban Wendling wrote:
Le 27/04/2014 21:24, Matthew Brush a écrit :
Yeah I guess AM_PROG_VALAC() just issues those warnings instead of failing as I'd have expected.
In a perfect world, the generated *.[ch] files would be distributed and when compiling (from tarball at least) no Vala compiler would be required.
GNOME folks just say that distributing generated files was a bad design idea.
That's the very reason why the absence of valac doesn't trigger a failure (hence disabling the plugin): because tarballs include the C sources, and then valac isn't required unless you want to change the Vala source.
I'm not sure what we can do here… maybe magically detect it's not a tarball and then require valac? Not sure.
One not great option would be to check-in the generated source.
Just require this little dependency that Vala is for everyone. Or consider that Git = non-tarball and do:
if test -d .git -a -z "$VALAC"; then AC_MSG_ERROR([valac is required to build from Git]) fi
On 30 April 2014 22:40, Quentin Glidic sardemff7+geany@sardemff7.net wrote:
On 2014-04-27 22:41, Matthew Brush wrote:
On 14-04-27 01:08 PM, Colomban Wendling wrote:
Le 27/04/2014 21:24, Matthew Brush a écrit :
Yeah I guess AM_PROG_VALAC() just issues those warnings instead
of failing as I'd have expected.
In a perfect world, the generated *.[ch] files would be distributed and when compiling (from tarball at least) no Vala compiler would be required.
GNOME folks just say that distributing generated files was a bad design idea.
That's the very reason why the absence of valac doesn't trigger a failure (hence disabling the plugin): because tarballs include the C sources, and then valac isn't required unless you want to change the Vala source.
I'm not sure what we can do here… maybe magically detect it's not a tarball and then require valac? Not sure.
One not great option would be to check-in the generated source.
Just require this little dependency that Vala is for everyone. Or consider that Git = non-tarball and do:
if test -d .git -a -z "$VALAC"; then AC_MSG_ERROR([valac is required to build from Git]) fi
The "proper" solution is for configure to test if valac is available, then for the plugins that use it to decide if they need it (ie if they need to make .c files) and to disable themselves if they need it and its not available. How they do that s/b up to the plugin, but a trial make sounds good :)
Cheers Lex
--
Quentin “Sardem FF7” Glidic
Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
On 14-04-30 05:40 AM, Quentin Glidic wrote:
On 2014-04-27 22:41, Matthew Brush wrote:
On 14-04-27 01:08 PM, Colomban Wendling wrote:
Le 27/04/2014 21:24, Matthew Brush a écrit :
Yeah I guess AM_PROG_VALAC() just issues those warnings instead of failing as I'd have expected.
In a perfect world, the generated *.[ch] files would be distributed and when compiling (from tarball at least) no Vala compiler would be required.
GNOME folks just say that distributing generated files was a bad design idea.
I can understand this, however not requiring an extra build-time dependency where not strictly necessary might improve chances of getting distributed (especially ex. on windows, not that multiterm counts :)
That's the very reason why the absence of valac doesn't trigger a failure (hence disabling the plugin): because tarballs include the C sources, and then valac isn't required unless you want to change the Vala source.
I'm not sure what we can do here… maybe magically detect it's not a tarball and then require valac? Not sure.
One not great option would be to check-in the generated source.
Just require this little dependency that Vala is for everyone.
I'm not strictly opposed, but if it saves someone that is using the tarball/dist from having to install a bunch of Vala stuff even if they have no intention of modifying the original Vala sources, and Valac conveniently outputs nice portable C code, then I'm not sure.
Or consider that Git = non-tarball and do:
if test -d .git -a -z "$VALAC"; then AC_MSG_ERROR([valac is required to build from Git]) fi
I like this concept best... if you forced on Multiterm/etc/Vala, and you're building from Git, then you need Valac, else soft-fail and just use generated C sources from dist, unless explicitly disabled.
Cheers, Matthew Brush
Am 27.04.2014 22:08, schrieb Colomban Wendling:
Le 27/04/2014 21:24, Matthew Brush a écrit :
On 14-04-27 05:39 AM, Dimitar Zhekov wrote:
$ ./autogen.sh ... checking for valac... valac configure: WARNING: no proper vala compiler found configure: WARNING: you will not be able to compile vala source files ... Plugins: MultiTerm: yes
$ make ... make[3]: Entering directory `/home/build/projects/plugins/testing/multiterm/src' VALAC multiterm_la_vala.stamp /bin/bash: valac: command not found make[3]: *** [multiterm_la_vala.stamp] Error 127
I fetched a clean git, just to be sure there's no some older configuration left.
Yeah I guess AM_PROG_VALAC() just issues those warnings instead of failing as I'd have expected.
In a perfect world, the generated *.[ch] files would be distributed and when compiling (from tarball at least) no Vala compiler would be required.
That's the very reason why the absence of valac doesn't trigger a failure (hence disabling the plugin): because tarballs include the C sources, and then valac isn't required unless you want to change the Vala source.
I'm not sure what we can do here… maybe magically detect it's not a tarball and then require valac? Not sure.
Perhaps check if (one of) the generated C files exists at configure-time?
Best regards