Hi,
Currently we have apart of the git list itself two places where we have added contributors in past, but which look quiet orphaned nowadays:
The contributors-dialog on Geany->Help:
https://github.com/geany/geany/blob/master/src/about.c
and the THANKS-file inside / of the source tree:
https://github.com/geany/geany/blob/master/THANKS
As we got a huge amount of contributors¹ all should get their kudos and now I'm wondering how we can go on in future with it. There are contributors for translations, code, documentation, community things like support, donations (money) etc.
Cheers, Frank
¹ Openhub https://www.openhub.net/p/geany says we have 42 (hihi) contributors last year -- not counting po updates where I committed the po files myself.
On 9 March 2017 at 23:56, Frank Lanitz frank@frank.uvena.de wrote:
Hi,
Currently we have apart of the git list itself two places where we have added contributors in past, but which look quiet orphaned nowadays:
The contributors-dialog on Geany->Help:
https://github.com/geany/geany/blob/master/src/about.c
and the THANKS-file inside / of the source tree:
https://github.com/geany/geany/blob/master/THANKS
As we got a huge amount of contributors¹ all should get their kudos and now I'm wondering how we can go on in future with it. There are contributors for translations, code, documentation, community things like support, donations (money) etc.
It is certainly nice to acknowledge contributors, but for it not to be a burden it has to be automated, otherwise just remove the hand cranked lists and just say thank you to all contributors and list the categories as you have done above. And don't forget packagers and ...
Cheers Lex
Cheers, Frank
¹ Openhub https://www.openhub.net/p/geany says we have 42 (hihi) contributors last year -- not counting po updates where I committed the po files myself.
Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Hi Frank,
On Thu, Mar 9, 2017 at 2:56 PM, Frank Lanitz frank@frank.uvena.de wrote:
Hi,
Currently we have apart of the git list itself two places where we have added contributors in past, but which look quiet orphaned nowadays:
The contributors-dialog on Geany->Help:
https://github.com/geany/geany/blob/master/src/about.c
and the THANKS-file inside / of the source tree:
https://github.com/geany/geany/blob/master/THANKS
As we got a huge amount of contributors¹ all should get their kudos and now I'm wondering how we can go on in future with it. There are contributors for translations, code, documentation, community things like support, donations (money) etc.
One possibility (apart from what Lex suggests which is OK too) is to list the names that the AUTHORS file shows:
https://github.com/geany/geany/blob/master/AUTHORS
or better the updated version of AUTHORS from #1148:
https://github.com/geany/geany/pull/1148/commits/b40b6ec9dfebcb7dc6911fbca08...
When you have a look here
https://github.com/geany/geany/graphs/contributors
the number of regularly code-contributing developers is quite small - I'd say it's just the first 9 plus Eugene who contributed a lot in the pre-git era (maybe there's someone else missing from that time - Enrico could know better). When you have a look at the rest of the contributor's commits, they are either 1-feature-related (e.g. SiegeLord's Rust parser), or translators.
So I think listing these people explicitly plus "thanks to all other contributors" could be enough. If someone else starts contributing regularly, he can be added but this doesn't happen so often to be a maintenance problem.
Cheers, Frank
¹ Openhub https://www.openhub.net/p/geany says we have 42 (hihi) contributors last year -- not counting po updates where I committed the po files myself.
I think these actually are po updates mostly - even though you commit them, git shows the author of the patch, not the committer and there definitely weren't Geany code patches merged from 42 different people last year.
Cheers,
Jiri
...
I think these actually are po updates mostly - even though you commit them, git shows the author of the patch, not the committer and there definitely weren't Geany code patches merged from 42 different people last year.
Translators ARE contributors, if anybody is listed they should be too.
This is one of my BIG objections to some projects, you are only considered worthwhile if you contribute to code. Documentation, translation, testing, those who submit bug reports that we then fix, even those who submit feature suggestions that get implemented by others, packagers, all of those are worthwhile contributors to improving Geany, but not all of them will show up in git. Projects that ignore those people just look like unappreciative gits (pun intended). [end rant]
Certainly using a single source of all the thank yous is an improvement, but who is going to go back and find all the contributors from the past?
Regards Lex
Cheers,
Jiri
Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Hi Lex,
On Fri, Mar 10, 2017 at 12:58 AM, Lex Trotman elextr@gmail.com wrote:
...
I think these actually are po updates mostly - even though you commit
them,
git shows the author of the patch, not the committer and there definitely weren't Geany code patches merged from 42 different people last year.
Translators ARE contributors, if anybody is listed they should be too.
This is one of my BIG objections to some projects, you are only considered worthwhile if you contribute to code. Documentation, translation, testing, those who submit bug reports that we then fix, even those who submit feature suggestions that get implemented by others, packagers, all of those are worthwhile contributors to improving Geany, but not all of them will show up in git. Projects that ignore those people just look like unappreciative gits (pun intended). [end rant]
actually after re-reading Frank's email I realized I misunderstood what he was saying - I thought he said there were 42 contributors last year "not counting po file updates" (i.e. non-translators, just code contributors) but he said "not counting po file updates committed by myself" (that is without a few extra ones he committed on behalf of the translators). So I was pointing just to what I thought was an error in the counts of code contributors - I absolutely didn't want to say that translators aren't contributors and sorry if I made that impression.
What Enrico suggests about exporting git history and adding other contributors from the past sounds good to me. I think it's almost guaranteed someone will be missed but the THANKS file will be more up-to-date than now.
Maybe a suggestion - instead of linking to the THANKS file to github (URLs can change, etc.), the THANKS file could be installed together with Geany and the About dialog could just read it and add it as a string to the Contributors section. I can write the patch.
Cheers,
Jiri
On 12/03/17 22:13, Jiří Techet wrote:
Hi Lex,
On Fri, Mar 10, 2017 at 12:58 AM, Lex Trotman elextr@gmail.com wrote:
...
I think these actually are po updates mostly - even though you commit
them,
git shows the author of the patch, not the committer and there definitely weren't Geany code patches merged from 42 different people last year.
Translators ARE contributors, if anybody is listed they should be too.
This is one of my BIG objections to some projects, you are only considered worthwhile if you contribute to code. Documentation, translation, testing, those who submit bug reports that we then fix, even those who submit feature suggestions that get implemented by others, packagers, all of those are worthwhile contributors to improving Geany, but not all of them will show up in git. Projects that ignore those people just look like unappreciative gits (pun intended). [end rant]
actually after re-reading Frank's email I realized I misunderstood what he was saying - I thought he said there were 42 contributors last year "not counting po file updates" (i.e. non-translators, just code contributors) but he said "not counting po file updates committed by myself" (that is without a few extra ones he committed on behalf of the translators). So I was pointing just to what I thought was an error in the counts of code contributors - I absolutely didn't want to say that translators aren't contributors and sorry if I made that impression.
What Enrico suggests about exporting git history and adding other contributors from the past sounds good to me. I think it's almost guaranteed someone will be missed but the THANKS file will be more up-to-date than now.
Full ACK. I'm also worried about forgetting someone but also don't think we can really ensure to not forget anyone. But we can try to minimize the risk.
Maybe a suggestion - instead of linking to the THANKS file to github (URLs can change, etc.), the THANKS file could be installed together with Geany and the About dialog could just read it and add it as a string to the Contributors section. I can write the patch.
Sounds fine to me.
Regards, Enrico
On 09/03/17 14:56, Frank Lanitz wrote:
Hi,
Currently we have apart of the git list itself two places where we have added contributors in past, but which look quiet orphaned nowadays:
The contributors-dialog on Geany->Help:
https://github.com/geany/geany/blob/master/src/about.c
and the THANKS-file inside / of the source tree:
https://github.com/geany/geany/blob/master/THANKS
As we got a huge amount of contributors¹ all should get their kudos and now I'm wondering how we can go on in future with it. There are contributors for translations, code, documentation, community things like support, donations (money) etc.
My two cents: remove the translators and contributors lists from the About dialog and replace the lists by a link to the THANKS file on Github and add a note to find the THANKS file in the source distribution.
Then keep the THANKS file up to date by generating it from GIT history, maybe with excluding our own names (feels weird to thank yourself :D). And, as Jiri said, keep a few names manually maintained like those who didn't contributed code/translations directly via GIT or in pre-GIT times.
This way we would have one place where contributors are listed for their kudos and the maintenance burden is hopefully low enough.
Regards, Enrico
On 10 March 2017 at 07:14, Enrico Tröger enrico.troeger@uvena.de wrote:
On 09/03/17 14:56, Frank Lanitz wrote:
Hi,
Currently we have apart of the git list itself two places where we have added contributors in past, but which look quiet orphaned nowadays:
The contributors-dialog on Geany->Help:
https://github.com/geany/geany/blob/master/src/about.c
and the THANKS-file inside / of the source tree:
https://github.com/geany/geany/blob/master/THANKS
As we got a huge amount of contributors¹ all should get their kudos and now I'm wondering how we can go on in future with it. There are contributors for translations, code, documentation, community things like support, donations (money) etc.
My two cents: remove the translators and contributors lists from the About dialog and replace the lists by a link to the THANKS file on Github and add a note to find the THANKS file in the source distribution.
Then keep the THANKS file up to date by generating it from GIT history, maybe with excluding our own names (feels weird to thank yourself :D).
Consider it thanks from the rest of us.
And, as Jiri said, keep a few names manually maintained like those who didn't contributed code/translations directly via GIT or in pre-GIT times.
And non-git like bug reporters and feature suggesters, and testers and packagers and ...
Cheers Lex
This way we would have one place where contributors are listed for their kudos and the maintenance burden is hopefully low enough.
Regards, Enrico
-- Get my GPG key from http://www.uvena.de/pub.asc
Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
On 10/03/17 01:01, Lex Trotman wrote:
On 10 March 2017 at 07:14, Enrico Tröger enrico.troeger@uvena.de wrote:
On 09/03/17 14:56, Frank Lanitz wrote:
Hi,
Currently we have apart of the git list itself two places where we have added contributors in past, but which look quiet orphaned nowadays:
The contributors-dialog on Geany->Help:
https://github.com/geany/geany/blob/master/src/about.c
and the THANKS-file inside / of the source tree:
https://github.com/geany/geany/blob/master/THANKS
As we got a huge amount of contributors¹ all should get their kudos and now I'm wondering how we can go on in future with it. There are contributors for translations, code, documentation, community things like support, donations (money) etc.
[...]
And, as Jiri said, keep a few names manually maintained like those who didn't contributed code/translations directly via GIT or in pre-GIT times.
And non-git like bug reporters and feature suggesters, and testers and packagers and ...
Yes, absolutely. We could fill the THANKS file from GIT history, merged PRs, closed issues and so get already many people to credit. Furthermore, we still need to manually maintain a list of people who contributed in at least one of the following ways: - mailing list (patches, requests, ideas, discussions, ...) - old pre-GIT contributions - any other input we received and want to credit which is not visible on Github
I think the overhead of the manual editing is not that high and with auto-generating the majority of the list we can ensure to not easily forget someone.
Of course, the list is getting huge then but IMO that's better than not listing anyone.
Furthermore, I'd vote for *not* listing email addresses of contributors in the THANKS file as they tend to get obsolete and make it email address harvesters too easy to find the addresses.
Regards, Enrico
On 12 March 2017 at 20:59, Enrico Tröger enrico.troeger@uvena.de wrote:
On 10/03/17 01:01, Lex Trotman wrote:
On 10 March 2017 at 07:14, Enrico Tröger enrico.troeger@uvena.de wrote:
On 09/03/17 14:56, Frank Lanitz wrote:
Hi,
Currently we have apart of the git list itself two places where we have added contributors in past, but which look quiet orphaned nowadays:
The contributors-dialog on Geany->Help:
https://github.com/geany/geany/blob/master/src/about.c
and the THANKS-file inside / of the source tree:
https://github.com/geany/geany/blob/master/THANKS
As we got a huge amount of contributors¹ all should get their kudos and now I'm wondering how we can go on in future with it. There are contributors for translations, code, documentation, community things like support, donations (money) etc.
[...]
And, as Jiri said, keep a few names manually maintained like those who didn't contributed code/translations directly via GIT or in pre-GIT times.
And non-git like bug reporters and feature suggesters, and testers and packagers and ...
Yes, absolutely. We could fill the THANKS file from GIT history, merged PRs, closed issues and so get already many people to credit. Furthermore, we still need to manually maintain a list of people who contributed in at least one of the following ways:
- mailing list (patches, requests, ideas, discussions, ...)
- old pre-GIT contributions
- any other input we received and want to credit which is not visible on
Github
I think the overhead of the manual editing is not that high and with auto-generating the majority of the list we can ensure to not easily forget someone.
Of course, the list is getting huge then but IMO that's better than not listing anyone.
As my rant indicated, I agree with that. My only worry is missing people, I'm sure it will always be a last minute thing before release, and then people get forgotten.
Furthermore, I'd vote for *not* listing email addresses of contributors in the THANKS file as they tend to get obsolete and make it email address harvesters too easy to find the addresses.
Totally agree with that, even though many email addresses will be visible from other sources, we shouldn't be propogating them without explicit permission.
Cheers Lex
Regards, Enrico
-- Get my GPG key from http://www.uvena.de/pub.asc
Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel