Hi everybody !
I checked all my PR, didn't see any comment, but they're still not merged and i don't if there is a reason, or anything else. Can someone can check them ? :)
I think it would be nice to merge the PR#224, since it already been a discussed PR ! I know the 2 other PR are maybe not good enough to be merged :)
https://github.com/geany/geany/pull/224 https://github.com/geany/geany/pull/219 (make the string more accurate with PR 218) https://github.com/geany/geany/pull/218 (let the user choose between Windows or Gtk color chooser)
Cheers, Steven Valsesia
On 28 March 2014 22:21, Steven VALSESIA steven.valsesia@gmail.com wrote:
Hi everybody !
I checked all my PR, didn't see any comment, but they're still not merged and i don't if there is a reason, or anything else. Can someone can check them ? :)
I think it would be nice to merge the PR#224, since it already been a discussed PR !
Patience is a virtue, or so they tell me, I wouldn't know :)
Its only 3 days since you last updated #224.
There needs to be enough time for people with varying amounts of free time to comment. (nobody does Geany as a job).
We need to allow at least a week in most cases. If its big, difficult or controversial expect at least a month ... or more ... much more :)
I know the 2 other PR are maybe not good enough to be merged :)
https://github.com/geany/geany/pull/224 https://github.com/geany/geany/pull/219 (make the string more accurate with PR 218) https://github.com/geany/geany/pull/218 (let the user choose between Windows or Gtk color chooser)
The last two are both windows. None of the devs uses windows regularly (and some like me refuse categorically to do so) so windows changes will likely be slower than Linux ones anyway, simply because fewer people will look at them and they need to make a special effort to do so.
Also we are just before a release so its a bad idea to commit things that might introduce errors, since there is not much testing going to happen before release, and even less on windows changes.
Thats not a comment on any perceived quality of those PRs. But anybody can make a mistake, thats why 1.23.1 followed 1.23 so quickly last time, after a last minute change caused problems. This time hopefully no last minute buggy changes will get committed :)
Cheers Lex
Cheers, Steven Valsesia
Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Thanks for your response. Now I understand what's going on :)
Cheers, Steven Valsesia
2014-03-28 13:28 GMT+01:00 Lex Trotman elextr@gmail.com:
On 28 March 2014 22:21, Steven VALSESIA steven.valsesia@gmail.com wrote:
Hi everybody !
I checked all my PR, didn't see any comment, but they're still not merged and i don't if there is a reason, or anything else. Can someone can check them ? :)
I think it would be nice to merge the PR#224, since it already been a discussed PR !
Patience is a virtue, or so they tell me, I wouldn't know :)
Its only 3 days since you last updated #224.
There needs to be enough time for people with varying amounts of free time to comment. (nobody does Geany as a job).
We need to allow at least a week in most cases. If its big, difficult or controversial expect at least a month ... or more ... much more :)
I know the 2 other PR are maybe not good enough to be merged :)
https://github.com/geany/geany/pull/224 https://github.com/geany/geany/pull/219 (make the string more accurate
with
PR 218) https://github.com/geany/geany/pull/218 (let the user choose between
Windows
or Gtk color chooser)
The last two are both windows. None of the devs uses windows regularly (and some like me refuse categorically to do so) so windows changes will likely be slower than Linux ones anyway, simply because fewer people will look at them and they need to make a special effort to do so.
Also we are just before a release so its a bad idea to commit things that might introduce errors, since there is not much testing going to happen before release, and even less on windows changes.
Thats not a comment on any perceived quality of those PRs. But anybody can make a mistake, thats why 1.23.1 followed 1.23 so quickly last time, after a last minute change caused problems. This time hopefully no last minute buggy changes will get committed :)
Cheers Lex
Cheers, Steven Valsesia
Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
On Fri, 28 Mar 2014 23:28:02 +1100 Lex Trotman elextr@gmail.com wrote:
The last two are both windows. None of the devs uses windows regularly (and some like me refuse categorically to do so) so windows changes will likely be slower than Linux ones anyway, simply because fewer people will look at them and they need to make a special effort to do so.
This may change. Recent kernel and x11 updates made my wi-fi and video slower, and judging from the mailing lists, they will stay like this. Given the inevitable gtk+3, I plan to give Windows a try. As soon as I find out how to pull two years of updates before it catches a virus. :)
(Actually, one of the "offline" updaters has a bash download script.)
On 14-03-28 11:39 AM, Dimitar Zhekov wrote:
On Fri, 28 Mar 2014 23:28:02 +1100 Lex Trotman elextr@gmail.com wrote:
The last two are both windows. None of the devs uses windows regularly (and some like me refuse categorically to do so) so windows changes will likely be slower than Linux ones anyway, simply because fewer people will look at them and they need to make a special effort to do so.
This may change. Recent kernel and x11 updates made my wi-fi and video slower, and judging from the mailing lists, they will stay like this. Given the inevitable gtk+3, I plan to give Windows a try. As soon as I find out how to pull two years of updates before it catches a virus. :)
(Actually, one of the "offline" updaters has a bash download script.)
You might like MacOS more than Windows if you like Linux, at least it has bash and most common core utils and stuff, plus a proper terminal emulator, and package managers to get good software onto it. The only bad part is the user interface kind of sucks and you have to buy ugly expensive hardware to run it, but it's still vastly better than Windows, IMO :)
Cheers, Matthew Brush
[...]
You might like MacOS more than Windows if you like Linux, at least it has bash and most common core utils and stuff, plus a proper terminal emulator, and package managers to get good software onto it. The only bad part is the user interface kind of sucks and you have to buy ugly expensive hardware to run it, but it's still vastly better than Windows, IMO :)
But some guy called Matthew Brush complains bitterly that Geany doesn't look and act very native on Macs :-D
Cheers Lex
Cheers, Matthew Brush
Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
On Fri, 28 Mar 2014 17:35:17 -0700 Matthew Brush mbrush@codebrainz.ca wrote:
The last two are both windows. None of the devs uses windows regularly [...]
This may change. Recent kernel and x11 updates made my wi-fi and video slower, and [...] I plan to give Windows a try.
You might like MacOS more than Windows if you like Linux, at least it has bash and most common core utils and stuff, plus a proper terminal emulator, and package managers to get good software onto it. The only bad part is the user interface kind of sucks and you have to buy ugly expensive hardware to run it, but it's still vastly better than Windows, IMO :)
Novadays, there is a full set of coreutils, bash etc. for Win~1, and they don't need Cygwin. It'll be interesting to see Android-x86, though it can't be used for development.
Am 28.03.2014 19:39, schrieb Dimitar Zhekov:
This may change. Recent kernel and x11 updates made my wi-fi and video slower, and judging from the mailing lists, they will stay like this. Given the inevitable gtk+3, I plan to give Windows a try. As soon as I find out how to pull two years of updates before it catches a virus. :)
Well, at least testing I'm doing also under Win7 64Bit at daily office work. ... But coding, most likely not.
On 31 March 2014 18:49, Frank Lanitz frank@frank.uvena.de wrote:
Am 28.03.2014 19:39, schrieb Dimitar Zhekov:
This may change. Recent kernel and x11 updates made my wi-fi and video slower, and judging from the mailing lists, they will stay like this. Given the inevitable gtk+3, I plan to give Windows a try. As soon as I find out how to pull two years of updates before it catches a virus. :)
Well, at least testing I'm doing also under Win7 64Bit at daily office work. ... But coding, most likely not.
Hey, at least its regular testing on a version of Windows thats not unsupported in a week :)
Cheers Lex
PS and 64 bit too :)
Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel