Hey Matthew,
the Markdown plugin currently does not compile on GTK 2.16, more specific with GLib < 2.26. See http://nightly.geany.org/misc/build_gtk216_plugins_stderr.log for details.
One issue is that "uint" (conf.c:245) is not defined. I guess this is just a typo and should be "guint". I just don't understand why this works on other systems, like the nightly build environment for ArchLinux. Anyway, changing it to "guint" is probably good enough.
Though there is another issue: g_object_class_install_properties is first available in GLib 2.26 (used in conf.c:372). So maybe this plugin needs a higher GLib requirement.
Regards, Enrico
Le 31/01/2013 19:09, Enrico Tröger a écrit :
Hey Matthew,
the Markdown plugin currently does not compile on GTK 2.16, more specific with GLib < 2.26. See http://nightly.geany.org/misc/build_gtk216_plugins_stderr.log for details.
One issue is that "uint" (conf.c:245) is not defined. I guess this is just a typo and should be "guint". I just don't understand why this works on other systems, like the nightly build environment for ArchLinux. Anyway, changing it to "guint" is probably good enough.
I guess the newer GTK include a system header that defines the uint type or something like this.
Also Matthew, markdown_config_get_uint_key() have a default_value argument (the one with type uint), but the default used is hard-coded as 12, it doesn't look so legitimate ;)
Though there is another issue: g_object_class_install_properties is first available in GLib 2.26 (used in conf.c:372). So maybe this plugin needs a higher GLib requirement.
Or simply not use this function, or emulate it. I think it's easy enough not to use the cheap and mean solution of higher dep for this.
Regards, Colomban
On 13-01-31 10:17 AM, Colomban Wendling wrote:
Le 31/01/2013 19:09, Enrico Tröger a écrit :
Hey Matthew,
the Markdown plugin currently does not compile on GTK 2.16, more specific with GLib < 2.26. See http://nightly.geany.org/misc/build_gtk216_plugins_stderr.log for details.
One issue is that "uint" (conf.c:245) is not defined. I guess this is just a typo and should be "guint". I just don't understand why this works on other systems, like the nightly build environment for ArchLinux. Anyway, changing it to "guint" is probably good enough.
I guess the newer GTK include a system header that defines the uint type or something like this.
Also Matthew, markdown_config_get_uint_key() have a default_value argument (the one with type uint), but the default used is hard-coded as 12, it doesn't look so legitimate ;)
Hehehe. I think that was a copy and paste error from a function that returned a default font size of 12pt for config file key, in case you were curious :) Fixed.
Though there is another issue: g_object_class_install_properties is first available in GLib 2.26 (used in conf.c:372). So maybe this plugin needs a higher GLib requirement.
Or simply not use this function, or emulate it. I think it's easy enough not to use the cheap and mean solution of higher dep for this.
Agreed. I made a little wrapper function to do it.
Cheers, Matthew Brush
On 13-01-31 10:09 AM, Enrico Tröger wrote:
Hey Matthew,
the Markdown plugin currently does not compile on GTK 2.16, more specific with GLib < 2.26. See http://nightly.geany.org/misc/build_gtk216_plugins_stderr.log for details.
One issue is that "uint" (conf.c:245) is not defined. I guess this is just a typo and should be "guint". I just don't understand why this works on other systems, like the nightly build environment for ArchLinux. Anyway, changing it to "guint" is probably good enough.
Not sure exactly where it comes from, but I did mean "guint" :) Fixed.
Though there is another issue: g_object_class_install_properties is first available in GLib 2.26 (used in conf.c:372). So maybe this plugin needs a higher GLib requirement.
I made a little wrapper function that uses that function on new versions and some alternate code if not. It should be OK now I think, although I don't have GLIB 2.26 to be 100% sure.
Let me know if it causes any more issues.
Cheers, Matthew Brush
On 01/02/13 04:32, Matthew Brush wrote:
On 13-01-31 10:09 AM, Enrico Tröger wrote:
Hey Matthew,
the Markdown plugin currently does not compile on GTK 2.16, more specific with GLib < 2.26. See http://nightly.geany.org/misc/build_gtk216_plugins_stderr.log for details.
One issue is that "uint" (conf.c:245) is not defined. I guess this is just a typo and should be "guint". I just don't understand why this works on other systems, like the nightly build environment for ArchLinux. Anyway, changing it to "guint" is probably good enough.
Not sure exactly where it comes from, but I did mean "guint" :) Fixed.
Heh.
Though there is another issue: g_object_class_install_properties is first available in GLib 2.26 (used in conf.c:372). So maybe this plugin needs a higher GLib requirement.
I made a little wrapper function that uses that function on new versions and some alternate code if not. It should be OK now I think, although I don't have GLIB 2.26 to be 100% sure.
Ok, thanks. I don't have a system with Glib 2.26, too. But at least indirect the nightly builds, in particular the GTK 2.16 build test, helps to spot those things (currently the build is still broken but this is a problem in the build environment setup, will fix that later).
Regards, Enrico