Hi everybody !
I copy-paste a code that belong to Peter Scholtens that add an apply button to the color chooser.
But to make that code useful to windows users, and make the code more maintainable, I choose to remove the Win32 API window dialog and put the Gtk's one !
Does someone know why that dialog has been used for ? Does somebody feel that move disrespectful ? :P
Have fun !
On 14-03-04 06:57 AM, Steven VALSESIA wrote:
Hi everybody !
I copy-paste a code that belong to Peter Scholtens that add an apply button to the color chooser.
But to make that code useful to windows users, and make the code more maintainable, I choose to remove the Win32 API window dialog and put the Gtk's one !
As long as it's not the new toy GTK3 dialog made for exclusively for smart phones, it's really really terrible.
Does someone know why that dialog has been used for ? Does somebody feel that move disrespectful ? :P
IMO, it should follow the "use_win32_native_dialogs" (or whatever) preference at least, like the other native win32 dialogs. But, I see no point in completely removing it while leaving all the other win32 native dialogs in there, it seems kind of an arbitrary change.
Also the colour chooser should be in a plugin too IMO, not mixed-in to core code, but I guess that's a different subject :)
Cheers, Matthew Brush
On 04/03/14 16:41, Matthew Brush wrote:
On 14-03-04 06:57 AM, Steven VALSESIA wrote:
Hi everybody !
I copy-paste a code that belong to Peter Scholtens that add an apply button to the color chooser.
But to make that code useful to windows users, and make the code more maintainable, I choose to remove the Win32 API window dialog and put the Gtk's one !
As long as it's not the new toy GTK3 dialog made for exclusively for smart phones, it's really really terrible.
Does someone know why that dialog has been used for ? Does somebody feel that move disrespectful ? :P
IMO, it should follow the "use_win32_native_dialogs" (or whatever) preference at least, like the other native win32 dialogs. But, I see no point in completely removing it while leaving all the other win32 native dialogs in there, it seems kind of an arbitrary change.
Agreed. @Steven: the reason for the native win32 dialogs is simply that people requested it. And I think it's not that bad in general to have native dialogs while it is also good to have GTK dialogs which are also somewhat native, just to GTK. It's just the win32 API which is horrible.
Also the colour chooser should be in a plugin too IMO, not mixed-in to core code, but I guess that's a different subject :)
Yes. IIRC there is somewhere a TODO floating around suggesting this. Don't remember where it was (code, file TODO, my head, ...).
Regards, Enrico
On 14-03-05 12:14 PM, Enrico Tröger wrote:
On 04/03/14 16:41, Matthew Brush wrote:
On 14-03-04 06:57 AM, Steven VALSESIA wrote:
Hi everybody !
I copy-paste a code that belong to Peter Scholtens that add an apply button to the color chooser.
But to make that code useful to windows users, and make the code more maintainable, I choose to remove the Win32 API window dialog and put the Gtk's one !
As long as it's not the new toy GTK3 dialog made for exclusively for smart phones, it's really really terrible.
Does someone know why that dialog has been used for ? Does somebody feel that move disrespectful ? :P
IMO, it should follow the "use_win32_native_dialogs" (or whatever) preference at least, like the other native win32 dialogs. But, I see no point in completely removing it while leaving all the other win32 native dialogs in there, it seems kind of an arbitrary change.
Agreed. @Steven: the reason for the native win32 dialogs is simply that people requested it. And I think it's not that bad in general to have native dialogs while it is also good to have GTK dialogs which are also somewhat native, just to GTK. It's just the win32 API which is horrible.
Yeah, and its interaction with the GTK+ event/drawing loop (or lack thereof) that causes craziness like this:
http://codebrainz.ca/images/geany-native-no-redraw.png
Also the dialogs are somewhat inconsistent, in that from the main menu View->Set Font always uses the native win32 font-chooser dialog on Windows regardless of the "use native dialogs setting", and inversly in the preferences dialog Interface->Fonts never use native dialogs, irrespective of that option (due to using GtkFontChooserButton).
Also the colour chooser should be in a plugin too IMO, not mixed-in to core code, but I guess that's a different subject :)
Yes. IIRC there is somewhere a TODO floating around suggesting this. Don't remember where it was (code, file TODO, my head, ...).
I actually moved it into a plugin before, I'm sure it's around somewhere buried in a branch in my backups, if anyone cares enough I can try to find it. IIRC the main barriers were; feature regression due to inability to have a plugin enabled by default; not integrated into the toolbar customization stuff; some of needed win32 API functions were not exposed (rightly so).
Cheers, Matthew Brush
Le 04/03/2014 16:41, Matthew Brush a écrit :
On 14-03-04 06:57 AM, Steven VALSESIA wrote:
[...] Does someone know why that dialog has been used for ? Does somebody feel that move disrespectful ? :P
IMO, it should follow the "use_win32_native_dialogs" (or whatever) preference at least, like the other native win32 dialogs.
That was also my first though, but the setting we have, although named "use_native_windows_dialogs" is only used for save/open dialogs, and the preference in the UI says "Use Windows open/save dialog". So either this setting has to change meaning, an new one has to be added, or we cant use one.
Also the colour chooser should be in a plugin too IMO, not mixed-in to core code, but I guess that's a different subject :)
Would probably be good indeed.
Cheers, Colomban
IMO, it should follow the "use_win32_native_dialogs" (or whatever) preference at least, like the other native win32 dialogs. But, I see no point in completely removing it while leaving all the other win32 native dialogs in there, it seems kind of an arbitrary change.
I follow that setting, but it's UI names isn't good, so I made a PR. (I admit, I find the native's one horrible, it's kind of arbitrary change ^^). But let the user choose is the best thing we can make happen !
@Steven: the reason for the native win32 dialogs is simply that people requested it. And I think it's not that bad in general to have native dialogs while it is also good to have GTK dialogs which are also somewhat native, just to GTK. It's just the win32 API which is horrible.
Who requested that ? :D Yes, I admit that let the user choose is the best thing to do.
That was also my first though, but the setting we have, although named "use_native_windows_dialogs" is only used for save/open dialogs, and the preference in the UI says "Use Windows open/save dialog". So either this setting has to change meaning, an new one has to be added, or we cant use one.
Yesterday I made 2 Pull request :
One for changing the UI string "Use Windows open/save dialog" to "Use Windows native dialogs" : https://github.com/geany/geany/pull/219
The other let the user choose between "native" Win32 color chooser, or the Gtk's one, depending of use_native_windows_dialogs : https://github.com/geany/geany/pull/218
For the decision of putting the color chooser in a plugin, unfornatly, I think it would be feel a kind od regression by the user. We don't know why people like geany, this is why IMO " " "regression" " " is dangerous.
Thanks to all of you for your interest !
2014-03-06 1:14 GMT+01:00 Colomban Wendling lists.ban@herbesfolles.org:
Le 04/03/2014 16:41, Matthew Brush a écrit :
On 14-03-04 06:57 AM, Steven VALSESIA wrote:
[...] Does someone know why that dialog has been used for ? Does somebody feel that move disrespectful ? :P
IMO, it should follow the "use_win32_native_dialogs" (or whatever) preference at least, like the other native win32 dialogs.
That was also my first though, but the setting we have, although named "use_native_windows_dialogs" is only used for save/open dialogs, and the preference in the UI says "Use Windows open/save dialog". So either this setting has to change meaning, an new one has to be added, or we cant use one.
Also the colour chooser should be in a plugin too IMO, not mixed-in to core code, but I guess that's a different subject :)
Would probably be good indeed.
Cheers, Colomban _______________________________________________ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel