In path_is_in_dir(), if it's about to return NULL (if the function parameters have no path components in common) it tried to free() a string literal, which causes a crash. In the same function, there was a memory leak, because diffed_path was reassigned without being free()'d before.
Fix both problems.
Here's the patch.
Le 12/05/2011 20:25, Thomas Martitz a écrit :
Am 02.05.2011 17:38, schrieb Thomas Martitz:
Here's the patch.
Hmm, no answer from the maintainer or anyone whatsoever. Is it OK if I commit it myself?
The patch looks OK to me, but I wouldn't commit to a plugin without the author's agreement.
Anyway, you seem to have confused "treeviewer" and "treebrowser" in your mail/patch titles, maybe it's not really good for visibility?
Cheers, Colomban
Am 12.05.2011 20:32, schrieb Colomban Wendling:
The patch looks OK to me, but I wouldn't commit to a plugin without the author's agreement.
Which is why I posted it here in the first place :) I'll wait a bit longer and deactivate the plugin in the meantime.
Anyway, you seem to have confused "treeviewer" and "treebrowser" in your mail/patch titles, maybe it's not really good for visibility?
*Ooops* /me changes topic
Best regards.
Le 12/05/2011 20:33, Thomas Martitz a écrit :
Am 12.05.2011 20:32, schrieb Colomban Wendling:
The patch looks OK to me, but I wouldn't commit to a plugin without the author's agreement.
Which is why I posted it here in the first place :) I'll wait a bit longer and deactivate the plugin in the meantime.
You can still patch your local copy ^^ And maybe just send a mail directly to Adrian, maybe he doesn't read this ML in a daily basis.
Cheers, Colomban