Hi,
With allow_always_save=true, both Save and Save All are always enabled (unless there are no files, of course). Obviously, that makes sense for Save. But what you invoke Save All and there are no modified files? It doesn't save all files regardless of modification, as you may think, nor does it save the current file - in fact, it does nothing, and allow_always_save has no effect on it. So IMHO, en/disabling of Save All should not be affected by the value of allow_always_save.
The attached patch does that, and makes the preference changeable, provided that you call ui_save_buttons_toggle() after change (we'll need this when/if the various preferences editor is included in Geany). I also edited the documentation accordingly.
But that's enough description for a one-liner...
On Fri, 20 May 2011 20:30:45 +0300, Dimitar wrote:
Hi,
With allow_always_save=true, both Save and Save All are always enabled (unless there are no files, of course). Obviously, that makes sense for Save. But what you invoke Save All and there are no modified files? It doesn't save all files regardless of modification, as you may think, nor does it save the current file - in fact, it does nothing, and allow_always_save has no effect on it. So IMHO, en/disabling of Save All should not be affected by the value of allow_always_save.
Agreed. Just for your interest, the original request for this feature is here: http://www.mail-archive.com/geany@uvena.de/msg01148.html
The attached patch does that, and makes the preference changeable,
I committed the patch, thanks.
provided that you call ui_save_buttons_toggle() after change (we'll need this when/if the various preferences editor is included in Geany).
Not completely sure what you mean here.
Regards, Enrico
On Sun, 22 May 2011 12:35:25 +0200 Enrico Tröger enrico.troeger@uvena.de wrote:
[Re: [Geany-devel] allow always save all fix]
provided that you call ui_save_buttons_toggle() after change (we'll need this when/if the various preferences editor is included in Geany).
Not completely sure what you mean here.
This thing - an extra tab in Edit -> Preferences which contains the hidden prefs, now named "various". It was discussed in january; Nick wanted to do some changes in the code (don't know what exactly), and to make sure that all prefs are safe to change. I checked them one by one, and with allow_always_save changeable, they seem safe.
In this new patch version, only indent_hard_tab_width, number_[a-z]\ +_menu_items, show_symbol_list_expanders and use_gtk_word_boundaries require restart. I can make tab width and word boundaries take effect immediately, but don't think it's worth.
Needless to say, I'd be happy to see the various prefs editor included in Geany...
On Sun, 22 May 2011 17:01:22 +0300, Dimitar wrote:
On Sun, 22 May 2011 12:35:25 +0200 Enrico Tröger enrico.troeger@uvena.de wrote:
[Re: [Geany-devel] allow always save all fix]
provided that you call ui_save_buttons_toggle() after change (we'll need this when/if the various preferences editor is included in Geany).
Not completely sure what you mean here.
This thing - an extra tab in Edit -> Preferences which contains the hidden prefs, now named "various". It was discussed in january; Nick wanted to do some changes in the code (don't know what exactly), and to make sure that all prefs are safe to change. I checked them one by one, and with allow_always_save changeable, they seem safe.
In this new patch version, only indent_hard_tab_width, number_[a-z]\ +_menu_items, show_symbol_list_expanders and use_gtk_word_boundaries require restart. I can make tab width and word boundaries take effect immediately, but don't think it's worth.
Needless to say, I'd be happy to see the various prefs editor included in Geany...
Ok got it, but due to limited time, I leave this to Nick or whoever wants to get this into Geany.
Regards, Enrico
