Hi all,
I was looking for some programming to do recently and found this feature request: https://sourceforge.net/tracker/?func=detail&aid=3383201&group_id=15.... I tried writing a plugin which implements the feature, and it seems to work, but now I'm not sure what to do with it now. I've pasted the code here: http://pastebin.com/549Dazj0. My main concerns are that it seems very hack-ish, and seems too simple to be a full plugin.
Any advice regarding the code, what to do with it, etc. would be much appreciated.
Thanks, Alex
On Wed, Nov 16, 2011 at 8:29 AM, Meyer 3m.meyer@gmail.com wrote:
Hi all,
I was looking for some programming to do recently and found this feature request: https://sourceforge.net/tracker/?func=detail&aid=3383201&group_id=15... . I tried writing a plugin which implements the feature, and it seems to work, but now I'm not sure what to do with it now. I've pasted the code here: http://pastebin.com/549Dazj0.%C2%A0 My main concerns are that it seems very hack-ish, and seems too simple to be a full plugin.
Any advice regarding the code, what to do with it, etc. would be much appreciated.
Hi,
Nice simple plugin, but very fixed in operation, I have a couple of suggestions.
1. Use keybindings rather than the editor notify. This lets you catch the key before it is inserted in Scintilla and allows the user to set the trigger keycode (for me the actual characters would not be appropriate, but <ctrl><shift>char would be, but different users would have different use-cases). See for eg addons plugin for how to use keybindings. 2. Group the changes you make into one undo group, see the scintilla docs. 3. Add a preferences dialog to allow the opening and the respective closing character(s) to be set for each trigger keycode. It would of course default to your current pairs but would allow updating for other languages and multi character sequences. See again for eg addons. 4. Have 1 and 3 allow up to say eight codes/pairs to be defined.
The plugins infrastructure is about to get moved to Github and some new processes are being defined, see http://news.gmane.org/find-root.php?message_id=%3c4EC29977.1030802%40frank.u... so keep an eye on that thread and you can be the first new plugin using the new process :)
Cheers Lex
Thanks, Alex
Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Hi,
Thanks very much for the input! I've pasted an updated version here [1] which should implement your suggestions (assuming I understand them correctly).
Cheers Alex
[1] http://pastebin.com/WJXYQm1N
On Tue, Nov 15, 2011 at 6:45 PM, Lex Trotman elextr@gmail.com wrote:
On Wed, Nov 16, 2011 at 8:29 AM, Meyer 3m.meyer@gmail.com wrote:
Hi all,
I was looking for some programming to do recently and found this feature request:
https://sourceforge.net/tracker/?func=detail&aid=3383201&group_id=15...
. I tried writing a plugin which implements the feature, and it seems to work, but now I'm not sure what to do with it now. I've pasted the code here: http://pastebin.com/549Dazj0. My main concerns are that it seems
very
hack-ish, and seems too simple to be a full plugin.
Any advice regarding the code, what to do with it, etc. would be much appreciated.
Hi,
Nice simple plugin, but very fixed in operation, I have a couple of suggestions.
- Use keybindings rather than the editor notify. This lets you catch
the key before it is inserted in Scintilla and allows the user to set the trigger keycode (for me the actual characters would not be appropriate, but <ctrl><shift>char would be, but different users would have different use-cases). See for eg addons plugin for how to use keybindings. 2. Group the changes you make into one undo group, see the scintilla docs. 3. Add a preferences dialog to allow the opening and the respective closing character(s) to be set for each trigger keycode. It would of course default to your current pairs but would allow updating for other languages and multi character sequences. See again for eg addons. 4. Have 1 and 3 allow up to say eight codes/pairs to be defined.
The plugins infrastructure is about to get moved to Github and some new processes are being defined, see
http://news.gmane.org/find-root.php?message_id=%3c4EC29977.1030802%40frank.u... so keep an eye on that thread and you can be the first new plugin using the new process :)
Cheers Lex
Thanks, Alex
Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Am 17.11.2011 02:49, schrieb Meyer:
Thanks very much for the input! I've pasted an updated version here [1] which should implement your suggestions (assuming I understand them correctly).
Didn't check the source code but maybe you can put it into some version control system. Maybe at github or gitourios. Would make things for us a bit easier.
Cheers, Frank
I've never used a version control system before for my own code, but I think I it up correctly: https://github.com/pzoxiuv/Geany-Plugins
Cheers, Alex
On Thu, Nov 17, 2011 at 4:01 AM, Frank Lanitz frank@frank.uvena.de wrote:
Am 17.11.2011 02:49, schrieb Meyer:
Thanks very much for the input! I've pasted an updated version here [1] which should implement your suggestions (assuming I understand them correctly).
Didn't check the source code but maybe you can put it into some version control system. Maybe at github or gitourios. Would make things for us a bit easier.
Cheers, Frank
Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
On 11/17/2011 10:01 AM, Meyer wrote:
I've never used a version control system before for my own code, but I think I it up correctly: https://github.com/pzoxiuv/Geany-Plugins
Yep, I just cloned it and had a quick look. I left some comments on the github commit.
We could add this to the geany-plugins project if you want, but it seems a bit on the "small" side, IMO. Maybe the code would fit better in the Addons plugin?
Cheers, Matthew Brush
Cheers, Alex
On Thu, Nov 17, 2011 at 4:01 AM, Frank Lanitz <frank@frank.uvena.de mailto:frank@frank.uvena.de> wrote:
Am 17.11.2011 02:49, schrieb Meyer: > Thanks very much for the input! I've pasted an updated version here [1] > which should implement your suggestions (assuming I understand them > correctly). Didn't check the source code but maybe you can put it into some version control system. Maybe at github or gitourios. Would make things for us a bit easier. Cheers, Frank _______________________________________________ Geany-devel mailing list Geany-devel@uvena.de <mailto:Geany-devel@uvena.de> https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Am 18.11.2011 02:31, schrieb Matthew Brush:
On 11/17/2011 10:01 AM, Meyer wrote:
I've never used a version control system before for my own code, but I think I it up correctly: https://github.com/pzoxiuv/Geany-Plugins
Yep, I just cloned it and had a quick look. I left some comments on the github commit.
We could add this to the geany-plugins project if you want, but it seems a bit on the "small" side, IMO. Maybe the code would fit better in the Addons plugin?
We could do that (adding to addons) but to be honest I think addons is already really big and would like to leave it as single plugin. However, integrating to combined geany-plugins-project is a good idea as it will prevent you from maintaining your own build system and doing regular releases on your own.
Cheers, Frank
On Thu, Nov 17, 2011 at 8:31 PM, Matthew Brush mbrush@codebrainz.ca wrote:
On 11/17/2011 10:01 AM, Meyer wrote:
I've never used a version control system before for my own code, but I think I it up correctly: https://github.com/pzoxiuv/**Geany-Pluginshttps://github.com/pzoxiuv/Geany-Plugins
Yep, I just cloned it and had a quick look. I left some comments on the github commit.
We could add this to the geany-plugins project if you want, but it seems a bit on the "small" side, IMO. Maybe the code would fit better in the Addons plugin?
Thanks for looking at it, I've fixed the g_strdup_printf stuff. I agree it's too small to be its own plugin, and if you thought it could be put in with the Addons plugin that would be great. How would that happen?
Cheers, Alex
Cheers, Matthew Brush
Cheers,
Alex
On Thu, Nov 17, 2011 at 4:01 AM, Frank Lanitz <frank@frank.uvena.de mailto:frank@frank.uvena.de> wrote:
Am 17.11.2011 02:49, schrieb Meyer:
> Thanks very much for the input! I've pasted an updated versionhere [1] > which should implement your suggestions (assuming I understand them > correctly).
Didn't check the source code but maybe you can put it into some version control system. Maybe at github or gitourios. Would make things for us a bit easier.
Cheers, Frank
______________________________**_________________ Geany-devel mailing list Geany-devel@uvena.de mailto:Geany-devel@uvena.de https://lists.uvena.de/cgi-**bin/mailman/listinfo/geany-**develhttps://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
______________________________**_________________ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-**bin/mailman/listinfo/geany-**develhttps://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
______________________________**_________________ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-**bin/mailman/listinfo/geany-**develhttps://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel