Hello.
Sorry for bothering you so much. When I looked for existing bug reports related to changing document's filetype to "None", I found a couple of reports that seems obsolete. Maybe some of the developers could spend some time to review them and mark them as CLOSED or whatever is applicable.
1. Incorrect indentation guides - ID: 2637071 [1]
I opened the attached document and did not see any issues with indentation guides. I could miss something because I rarely use the guies, but... Maybe it was already fixed in Scintilla?
Enrico replied to this report in 2009.
2. Command line option to bring Geany to front - ID: 2276179 [2]
Seems that some actions were performed to fix the bug, but the report's author didn't have time to check it. Maybe, as a long time has passed since 2009, the bug report can be closed? BTW, what is described in the report, works fine for me (Geany is brought to front).
Enrico replied to this report in 2009, too.
3. "geany xyz.txt" does not load files from session - ID: 2838686 [3]
Here it wasn't decided whether of not Geany should restore session. I suggest we discuss this question and finally either fix the bug or mark it as WONTFIX.
A long time ago I added to the Preferences dialog a checkbox that controlled the behaviour. This was done in the sm branch. If it's decided that a graphical preference is needed, I can extract code from there and make a pull request.
However, currently I think that a hidden pref for that is better. Your opinions?
[1]:http://sf.net/tracker/index.php?func=detail&aid=2637071&group_id=153444&atid=787791 [2]:http://sf.net/tracker/index.php?func=detail&aid=2276179&group_id=153444&atid=787794 [3]:http://sf.net/tracker/index.php?func=detail&aid=2838686&group_id=153444&atid=787791
-- Best regards, Eugene.
On Sun, 12 Feb 2012 11:18:36 +0400 Eugene Arshinov earshinov@gmail.com wrote:
- Command line option to bring Geany to front - ID: 2276179 [2]
Seems that some actions were performed to fix the bug, but the report's author didn't have time to check it. Maybe, as a long time has passed since 2009, the bug report can be closed? BTW, what is described in the report, works fine for me (Geany is brought to front).
Enrico replied to this report in 2009, too.
From the discussion, it looks like Enrico fixed this... As of opening
Geany per-desktop, the manual contains an example (search for xprop).
- "geany xyz.txt" does not load files from session - ID: 2838686 [3]
Here it wasn't decided whether of not Geany should restore session. I suggest we discuss this question and finally either fix the bug or mark it as WONTFIX.
A long time ago I added to the Preferences dialog a checkbox that controlled the behaviour. This was done in the sm branch. If it's decided that a graphical preference is needed, I can extract code from there and make a pull request.
That was discussed before, for example "Proposed patch to fix issues with command line file loading", and weltall even sent a patch [1] for graphical preference. Outdated, of course, since it's a year old, and Geany uses GtkBuilder now...
If we're going to finally implement this feature (and several people requested it), I suggest that we apply #3312654 [2] first. The current load_startup_files() is a bit of a mess, and becomes worse with the new preference.
The thuth to be said, I had enough discussion on default session loading CL files specified. Let's vote and decide it, shall we?..
[1] http://lists.uvena.de/pipermail/geany-devel/2011-January/003818.html [2] http://sourceforge.net/tracker/?func=detail&aid=3312654&group_id=153...
On 02/11/2012 11:18 PM, Eugene Arshinov wrote:
Hello.
Sorry for bothering you so much. When I looked for existing bug reports related to changing document's filetype to "None", I found a couple of reports that seems obsolete. Maybe some of the developers could spend some time to review them and mark them as CLOSED or whatever is applicable.
- Incorrect indentation guides - ID: 2637071 [1]
I opened the attached document and did not see any issues with indentation guides. I could miss something because I rarely use the guies, but... Maybe it was already fixed in Scintilla?
Enrico replied to this report in 2009.
I think this bug is still present if I understand it correctly. The attached file causes indentation guides to be shown on the blank line that has no indentation at all.
- Command line option to bring Geany to front - ID: 2276179 [2]
Seems that some actions were performed to fix the bug, but the report's author didn't have time to check it. Maybe, as a long time has passed since 2009, the bug report can be closed? BTW, what is described in the report, works fine for me (Geany is brought to front).
Enrico replied to this report in 2009, too.
Just closed this one.
- "geany xyz.txt" does not load files from session - ID: 2838686 [3]
Here it wasn't decided whether of not Geany should restore session. I suggest we discuss this question and finally either fix the bug or mark it as WONTFIX.
A long time ago I added to the Preferences dialog a checkbox that controlled the behaviour. This was done in the sm branch. If it's decided that a graphical preference is needed, I can extract code from there and make a pull request.
However, currently I think that a hidden pref for that is better. Your opinions?
I don't often use Geany for opening files from the command line and usually I always have a Geany window open so if I do, it's not an issue, so I can't really provide a worthwhile opinion here.
Thanks for tracking down those lingering bug reports!
Cheers, Matthew Brush
On Mon, 13 Feb 2012 17:14:19 -0800 Matthew Brush mbrush@codebrainz.ca wrote:
On 02/11/2012 11:18 PM, Eugene Arshinov wrote:
Hello.
Sorry for bothering you so much. When I looked for existing bug reports related to changing document's filetype to "None", I found a couple of reports that seems obsolete. Maybe some of the developers could spend some time to review them and mark them as CLOSED or whatever is applicable.
- Incorrect indentation guides - ID: 2637071 [1]
I opened the attached document and did not see any issues with indentation guides. I could miss something because I rarely use the guies, but... Maybe it was already fixed in Scintilla?
Enrico replied to this report in 2009.
I think this bug is still present if I understand it correctly. The attached file causes indentation guides to be shown on the blank line that has no indentation at all.
Seems that I misunderstood the problem. Let's leave the report open.
- Command line option to bring Geany to front - ID: 2276179 [2]
Seems that some actions were performed to fix the bug, but the report's author didn't have time to check it. Maybe, as a long time has passed since 2009, the bug report can be closed? BTW, what is described in the report, works fine for me (Geany is brought to front).
Enrico replied to this report in 2009, too.
Just closed this one.
Thanks :)
- "geany xyz.txt" does not load files from session - ID: 2838686
[3]
Here it wasn't decided whether of not Geany should restore session. I suggest we discuss this question and finally either fix the bug or mark it as WONTFIX.
A long time ago I added to the Preferences dialog a checkbox that controlled the behaviour. This was done in the sm branch. If it's decided that a graphical preference is needed, I can extract code from there and make a pull request.
However, currently I think that a hidden pref for that is better. Your opinions?
I don't often use Geany for opening files from the command line and usually I always have a Geany window open so if I do, it's not an issue, so I can't really provide a worthwhile opinion here.
It's same with me, actually :) But still it would be good to make a decision about the bug report.
On Mon, 13 Feb 2012 17:14:19 -0800 Matthew Brush mbrush@codebrainz.ca wrote:
- "geany xyz.txt" does not load files from session - ID: 2838686 [3]
Here it wasn't decided whether of not Geany should restore session. I suggest we discuss this question and finally either fix the bug or mark it as WONTFIX.
I don't often use Geany for opening files from the command line and usually I always have a Geany window open so if I do, it's not an issue, so I can't really provide a worthwhile opinion here.
As the bug report states, opening a file _with your file manager_ or CLI loses the last [default] session [if no geany is running]. The complaints we usually got were "I double-clicked foo.c and lost my session", to which we usually replied "use projects". So this affects the GUI, even more than CLI.
Why not have a vote and finally implement or wontfix it? I volunteer to write the preference, as a graphical or vaiouus preference, if we decide "aye".
On 02/17/2012 09:42 AM, Dimitar Zhekov wrote:
On Mon, 13 Feb 2012 17:14:19 -0800 Matthew Brushmbrush@codebrainz.ca wrote:
- "geany xyz.txt" does not load files from session - ID: 2838686 [3]
Here it wasn't decided whether of not Geany should restore session. I suggest we discuss this question and finally either fix the bug or mark it as WONTFIX.
I don't often use Geany for opening files from the command line and usually I always have a Geany window open so if I do, it's not an issue, so I can't really provide a worthwhile opinion here.
As the bug report states, opening a file _with your file manager_ or CLI loses the last [default] session [if no geany is running]. The complaints we usually got were "I double-clicked foo.c and lost my session", to which we usually replied "use projects". So this affects the GUI, even more than CLI.
Yeah, I don't usually do that either. I almost always have an instance of Geany running on my 2nd monitor and if not, I'm usually not surprised by the behaviour since I do use projects mostly unless I'm just quickly editing a file or two.
Why not have a vote and finally implement or wontfix it? I volunteer to write the preference, as a graphical or vaiouus preference, if we decide "aye".
I have no opposition to this, though I wouldn't even know which way to vote. Why not setup one of those online polls and send a message to the mailing list(s) and see what happens?
Cheers, Matthew Brush
On 18 February 2012 12:13, Matthew Brush mbrush@codebrainz.ca wrote:
On 02/17/2012 09:42 AM, Dimitar Zhekov wrote:
On Mon, 13 Feb 2012 17:14:19 -0800 Matthew Brushmbrush@codebrainz.ca wrote:
- "geany xyz.txt" does not load files from session - ID: 2838686 [3]
Here it wasn't decided whether of not Geany should restore session. I suggest we discuss this question and finally either fix the bug or mark it as WONTFIX.
I don't often use Geany for opening files from the command line and usually I always have a Geany window open so if I do, it's not an issue, so I can't really provide a worthwhile opinion here.
As the bug report states, opening a file _with your file manager_ or CLI loses the last [default] session [if no geany is running]. The complaints we usually got were "I double-clicked foo.c and lost my session", to which we usually replied "use projects". So this affects the GUI, even more than CLI.
I just taught the file mangler to run geany -c so it never interrupts what a normal Geany is doing :)
Yeah, I don't usually do that either. I almost always have an instance of Geany running on my 2nd monitor and if not, I'm usually not surprised by the behaviour since I do use projects mostly unless I'm just quickly editing a file or two.
Why not have a vote and finally implement or wontfix it? I volunteer to write the preference, as a graphical or vaiouus preference, if we decide "aye".
Since there is no "always right" answer as to how Geany should react I'd say "wont change" since we have well known documented behaviour already.
Cheers Lex
I have no opposition to this, though I wouldn't even know which way to vote. Why not setup one of those online polls and send a message to the mailing list(s) and see what happens?
Cheers, Matthew Brush
Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Sorry for the long delay, I was busy last week (OK, no one cares anyway)
Le 18/02/2012 02:45, Lex Trotman a écrit :
On 18 February 2012 12:13, Matthew Brush mbrush@codebrainz.ca wrote:
On 02/17/2012 09:42 AM, Dimitar Zhekov wrote:
On Mon, 13 Feb 2012 17:14:19 -0800 Matthew Brushmbrush@codebrainz.ca wrote:
- "geany xyz.txt" does not load files from session - ID: 2838686 [3]
Here it wasn't decided whether of not Geany should restore session. I suggest we discuss this question and finally either fix the bug or mark it as WONTFIX.
I don't often use Geany for opening files from the command line and usually I always have a Geany window open so if I do, it's not an issue, so I can't really provide a worthwhile opinion here.
As the bug report states, opening a file _with your file manager_ or CLI loses the last [default] session [if no geany is running]. The complaints we usually got were "I double-clicked foo.c and lost my session", to which we usually replied "use projects". So this affects the GUI, even more than CLI.
I just taught the file mangler to run geany -c so it never interrupts what a normal Geany is doing :)
I don't think that's something everybody should need to do.
Yeah, I don't usually do that either. I almost always have an instance of Geany running on my 2nd monitor and if not, I'm usually not surprised by the behaviour since I do use projects mostly unless I'm just quickly editing a file or two.
Why not have a vote and finally implement or wontfix it? I volunteer to write the preference, as a graphical or vaiouus preference, if we decide "aye".
Since there is no "always right" answer as to how Geany should react I'd say "wont change" since we have well known documented behaviour already.
I personally do think what we do is definitely the Wrong Thing. Honestly, I always have found this behavior very counter-intuitive and not helpful. I mean, if I tell Geany to restore my session, I expect it to be restored whenever I start Geany, not only in some cases.
OK, for me it's not a real problem since I always have one or more Geany instance open, but remembering the early times I did unexpectedly lost some session data because of this behavior.
To summarize, I think that the current behavior will most likely NOT be the expected one and will disturb most users. See, even us do workaround that in some ways, either using -c or having an instance always open.
So I'd say "aye" to Dimitar since he gently volunteered :) Moreover if it is a preference I don't see any loss; but I'd better see this preference turned on by default for new configurations if the restore session one is on.
That's my POV of course :)
Cheers, Colomban
Cheers Lex
I have no opposition to this, though I wouldn't even know which way to vote. Why not setup one of those online polls and send a message to the mailing list(s) and see what happens?
Cheers, Matthew Brush
Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
[...]
I just taught the file mangler to run geany -c so it never interrupts what a normal Geany is doing :)
I don't think that's something everybody should need to do.
Yes, true.
[...]
I personally do think what we do is definitely the Wrong Thing. Honestly, I always have found this behavior very counter-intuitive and not helpful. I mean, if I tell Geany to restore my session, I expect it to be restored whenever I start Geany, not only in some cases.
Looking at it like that, then the current behaviour is wrong.
I also checked a few other apps and all restore past sessions and add the new file to it, so I would say this is the behaviour a user would expect.
OK, for me it's not a real problem since I always have one or more Geany instance open, but remembering the early times I did unexpectedly lost some session data because of this behavior.
To summarize, I think that the current behavior will most likely NOT be the expected one and will disturb most users. See, even us do workaround that in some ways, either using -c or having an instance always open.
Or both, so I *never* saw it as a problem :)
So I'd say "aye" to Dimitar since he gently volunteered :) Moreover if it is a preference I don't see any loss; but I'd better see this preference turned on by default for new configurations if the restore session one is on.
Colomban has been so persuasive that I don't even think it needs another option, the suggested behaviour is non-destructive, so why not just turn restoring sessions on or off.
Cheers Lex
Le 19/02/2012 01:06, Lex Trotman a écrit :
[...]
I just taught the file mangler to run geany -c so it never interrupts what a normal Geany is doing :)
I don't think that's something everybody should need to do.
Yes, true.
[...]
I personally do think what we do is definitely the Wrong Thing. Honestly, I always have found this behavior very counter-intuitive and not helpful. I mean, if I tell Geany to restore my session, I expect it to be restored whenever I start Geany, not only in some cases.
Looking at it like that, then the current behaviour is wrong.
I also checked a few other apps and all restore past sessions and add the new file to it, so I would say this is the behaviour a user would expect.
OK, for me it's not a real problem since I always have one or more Geany instance open, but remembering the early times I did unexpectedly lost some session data because of this behavior.
To summarize, I think that the current behavior will most likely NOT be the expected one and will disturb most users. See, even us do workaround that in some ways, either using -c or having an instance always open.
Or both, so I *never* saw it as a problem :)
So I'd say "aye" to Dimitar since he gently volunteered :) Moreover if it is a preference I don't see any loss; but I'd better see this preference turned on by default for new configurations if the restore session one is on.
Colomban has been so persuasive
Hehe :D
that I don't even think it needs another option, the suggested behaviour is non-destructive, so why not just turn restoring sessions on or off.
Agreed, another pref isn't needed, either always restore or never restore should be enough; IMO too.
Sounds reasonable to everybody?
Cheers, Colomban
On Sun, 19 Feb 2012 16:51:54 +0100 Colomban Wendling lists.ban@herbesfolles.org wrote:
Le 19/02/2012 01:06, Lex Trotman a écrit :
[...]
I just taught the file mangler to run geany -c so it never interrupts what a normal Geany is doing :)
I don't think that's something everybody should need to do.
Yes, true.
[...]
I personally do think what we do is definitely the Wrong Thing. Honestly, I always have found this behavior very counter-intuitive and not helpful. I mean, if I tell Geany to restore my session, I expect it to be restored whenever I start Geany, not only in some cases.
Looking at it like that, then the current behaviour is wrong.
I also checked a few other apps and all restore past sessions and add the new file to it, so I would say this is the behaviour a user would expect.
OK, for me it's not a real problem since I always have one or more Geany instance open, but remembering the early times I did unexpectedly lost some session data because of this behavior.
To summarize, I think that the current behavior will most likely NOT be the expected one and will disturb most users. See, even us do workaround that in some ways, either using -c or having an instance always open.
Or both, so I *never* saw it as a problem :)
So I'd say "aye" to Dimitar since he gently volunteered :) Moreover if it is a preference I don't see any loss; but I'd better see this preference turned on by default for new configurations if the restore session one is on.
Colomban has been so persuasive
Hehe :D
that I don't even think it needs another option, the suggested behaviour is non-destructive, so why not just turn restoring sessions on or off.
Agreed, another pref isn't needed, either always restore or never restore should be enough; IMO too.
Sounds reasonable to everybody?
I agree.
Hi,
- "geany xyz.txt" does not load files from session - ID: 2838686
With Lex, Colomban, Enrico and Eugene for it, and Matthew's "don't know", I'll do it tomorrow, using the rewritten load_startup_files. So we will be able to easily make it a pref, should it turn out that lots of people like the current behaviour. :)
Heya,
Eugene, thanks for the efforts on this front!
I just taught the file mangler to run geany -c so it never interrupts what a normal Geany is doing :)
I don't think that's something everybody should need to do.
Yeah, I don't usually do that either. I almost always have an instance of Geany running on my 2nd monitor and if not, I'm usually not surprised by the behaviour since I do use projects mostly unless I'm just quickly editing a file or two.
Why not have a vote and finally implement or wontfix it? I volunteer to write the preference, as a graphical or vaiouus preference, if we decide "aye".
Since there is no "always right" answer as to how Geany should react I'd say "wont change" since we have well known documented behaviour already.
I personally do think what we do is definitely the Wrong Thing. Honestly, I always have found this behavior very counter-intuitive and not helpful. I mean, if I tell Geany to restore my session, I expect it to be restored whenever I start Geany, not only in some cases.
OK, for me it's not a real problem since I always have one or more Geany instance open, but remembering the early times I did unexpectedly lost some session data because of this behavior.
To summarize, I think that the current behavior will most likely NOT be the expected one and will disturb most users. See, even us do workaround that in some ways, either using -c or having an instance always open.
So I'd say "aye" to Dimitar since he gently volunteered :) Moreover if it is a preference I don't see any loss; but I'd better see this preference turned on by default for new configurations if the restore session one is on.
FWIW, I'd agree as well. I think in the past, I denied this but it caused me also a few times losing my session and indeed many people prefer to keep the session when opening files from the CLI (or file manager or whatever).
So, my vote is 'yes' as well.
Regards, Enrico
On Sat, 18 Feb 2012 14:17:17 +0100 Colomban Wendling lists.ban@herbesfolles.org wrote:
So I'd say "aye" to Dimitar since he gently volunteered :) Moreover if it is a preference I don't see any loss; but I'd better see this preference turned on by default for new configurations if the restore session one is on.
Here's the patch. There is no additional preference - if "Load files from the last session" is checked, they are loaded, and that's it. Though it'll be easy to make it a pref...
Le 20/02/2012 18:34, Dimitar Zhekov a écrit :
On Sat, 18 Feb 2012 14:17:17 +0100 Colomban Wendling lists.ban@herbesfolles.org wrote:
So I'd say "aye" to Dimitar since he gently volunteered :) Moreover if it is a preference I don't see any loss; but I'd better see this preference turned on by default for new configurations if the restore session one is on.
Here's the patch. There is no additional preference - if "Load files from the last session" is checked, they are loaded, and that's it. Though it'll be easy to make it a pref...
Thanks a lot, committed. Maybe an update of the manual to explain more it needed? Though anyway I think new behavior is much more expected so that manual would be less read anyway :)
Cheers, Colomban
On Mon, 20 Feb 2012 20:00:38 +0100 Colomban Wendling lists.ban@herbesfolles.org wrote:
Thanks a lot, committed. Maybe an update of the manual to explain more it needed?
Yes... An update is required because the manual explicitly says "if you specify CL files, only they will be opened", and refers the user to Recent files. So I altered the Startup section a bit.
Le 20/02/2012 20:29, Dimitar Zhekov a écrit :
On Mon, 20 Feb 2012 20:00:38 +0100 Colomban Wendling lists.ban@herbesfolles.org wrote:
Thanks a lot, committed. Maybe an update of the manual to explain more it needed?
Yes... An update is required because the manual explicitly says "if you specify CL files, only they will be opened", and refers the user to Recent files. So I altered the Startup section a bit.
Thanks for that update again :)
"To run a second instance of Geany, do not specify any filenames on the command-line, [...]"
This should be reworded since it's not true since a long time one need explicit -i, isn't it? Or do I get the sentence wrong?
Cheers, Colomban
On Mon, 20 Feb 2012 21:00:44 +0100 Colomban Wendling lists.ban@herbesfolles.org wrote:
"To run a second instance of Geany, do not specify any filenames on the command-line, [...]"
This should be reworded since it's not true since a long time one need explicit -i, isn't it? Or do I get the sentence wrong?
Well, maybe "secondary" instead of second, since I used "subsequent" in the previous paragraph.
-i is required only if you want to open CL files in a new instance, instead of passing them to an already running one (explained under "Command line options" before "Startup"). If you have a Geany, and start another from, say, your DE menu (i.e. without CL), it becomes (new instance) automatically.
Le 21/02/2012 19:06, Dimitar Zhekov a écrit :
On Mon, 20 Feb 2012 21:00:44 +0100 Colomban Wendling lists.ban@herbesfolles.org wrote:
"To run a second instance of Geany, do not specify any filenames on the command-line, [...]"
This should be reworded since it's not true since a long time one need explicit -i, isn't it? Or do I get the sentence wrong?
Well, maybe "secondary" instead of second, since I used "subsequent" in the previous paragraph.
-i is required only if you want to open CL files in a new instance, instead of passing them to an already running one (explained under "Command line options" before "Startup"). If you have a Geany, and start another from, say, your DE menu (i.e. without CL), it becomes (new instance) automatically.
Hum ok, that's true, my bad. I actually never launch a second geany without files nor -i so... :-'
So the patch is fine, I applied it thanks.
Cheers, Colomban
Hey guys,
- Incorrect indentation guides - ID: 2637071 [1]
I opened the attached document and did not see any issues with indentation guides. I could miss something because I rarely use the guies, but... Maybe it was already fixed in Scintilla?
Enrico replied to this report in 2009.
I think this bug is still present if I understand it correctly. The attached file causes indentation guides to be shown on the blank line that has no indentation at all.
I can't reproduce it here, see attached screenshot. Maybe it's related to some preferences set?
Regards, Enrico
Le 19/02/2012 16:42, Enrico Tröger a écrit :
Hey guys,
- Incorrect indentation guides - ID: 2637071 [1]
I opened the attached document and did not see any issues with indentation guides. I could miss something because I rarely use the guies, but... Maybe it was already fixed in Scintilla?
Enrico replied to this report in 2009.
I think this bug is still present if I understand it correctly. The attached file causes indentation guides to be shown on the blank line that has no indentation at all.
I can't reproduce it here, see attached screenshot. Maybe it's related to some preferences set?
I think you just don't have indent guides enabled ;)
Regards, Enrico
Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
On 19/02/12 16:49, Colomban Wendling wrote:
Le 19/02/2012 16:42, Enrico Tröger a écrit :
Hey guys,
- Incorrect indentation guides - ID: 2637071 [1]
I opened the attached document and did not see any issues with indentation guides. I could miss something because I rarely use the guies, but... Maybe it was already fixed in Scintilla?
Enrico replied to this report in 2009.
I think this bug is still present if I understand it correctly. The attached file causes indentation guides to be shown on the blank line that has no indentation at all.
I can't reproduce it here, see attached screenshot. Maybe it's related to some preferences set?
I think you just don't have indent guides enabled ;)
Ah, stupid me. I confused indentation guides with 'show whitespace'.
Now, I looked a bit deeper into it and the behaviour is correct for the mode SC_IV_LOOKBOTH which we use for most filetypes (including C), according to the Scintilla documentation:
"Indentation guides are shown beyond the actual indentation up to the level of the next non-empty line or previous non-empty line whichever is the greater."
And now, I also understand my comment on the bug report again :). Though I could have said this in more detail. Now done and closed.
If anyone disagrees, just re-open it and put some more info in. If it's a real issue still, one could make the used indentation guide configurable per language. Since I don't use, I don't feel like doing it is necessary but that's just me.
Regards, Enrico
