Hi,
I haven't heard too much about the Git conversion of Geany Plugins, but I wanted to offer a suggestion that might improve the commit messages compared to Geany's. In the Geany's Git repository there's links back to the SVN repository in the commit messages (the links are broken BTW). I was wondering if it would be better to have these links point to a place we have more control over, for example using a Geany commit, instead of this in the commit message:
git-svn-id: https://geany.svn.sourceforge.net/svnroot/geany/trunk@5970 ea778897-0a13-0410-b9d1-a72fbfd435f5
We could have something like this:
git-svn-id: [ea778897-0a13-0410-b9d1-a72fbfd435f5](http://svn.geany.org/svnroot/geany/trunk?rev=5970)
That way we could make the links work and be able to move the old SVN repository without breaking all the links in the commit message. I guess we'd need a little redirect script or something on geany.org. Note also the use of Markdown link syntax, which might render better on Github (not sure).
I guess it's too late to do this for Geany's Git repository, but we could maybe consider something like this for Geany Plugins if the software can support it?
Just an idea.
Cheers, Matthew Brush
On Sun, Oct 30, 2011 at 10:15, Matthew Brush mbrush@codebrainz.ca wrote:
Hi,
I haven't heard too much about the Git conversion of Geany Plugins, but I wanted to offer a suggestion that might improve the commit messages compared to Geany's. In the Geany's Git repository there's links back to the SVN repository in the commit messages (the links are broken BTW). I was wondering if it would be better to have these links point to a place we have more control over, for example using a Geany commit, instead of this in the commit message:
git-svn-id: https://geany.svn.sourceforge.net/svnroot/geany/trunk@5970 ea778897-0a13-0410-b9d1-a72fbfd435f5
We could have something like this:
git-svn-id: [ea778897-0a13-0410-b9d1-a72fbfd435f5](http://svn.geany.org/svnroot/geany/trunk?rev=5970)
That way we could make the links work and be able to move the old SVN repository without breaking all the links in the commit message. I guess we'd need a little redirect script or something on geany.org. Note also the use of Markdown link syntax, which might render better on Github (not sure).
I guess it's too late to do this for Geany's Git repository, but we could maybe consider something like this for Geany Plugins if the software can support it?
Just an idea.
Well, the only thing I can do with the script is exclude/include the info about the original commit with --metadata switch. But of course if I make the import from the repository at svn.geany.org, the links will be changed to svn.geany.org. If you need some more advanced formatting, you'd have to change svn2git scripts manually. Feel free to send me the modifications of svn2git ;-).
Cheers, Jiri
On Sun, 30 Oct 2011 02:15:33 -0700 Matthew Brush mbrush@codebrainz.ca wrote:
Hi,
I haven't heard too much about the Git conversion of Geany Plugins, but I wanted to offer a suggestion that might improve the commit messages compared to Geany's. In the Geany's Git repository there's links back to the SVN repository in the commit messages (the links are broken BTW). I was wondering if it would be better to have these links point to a place we have more control over, for example using a Geany commit, instead of this in the commit message:
git-svn-id: https://geany.svn.sourceforge.net/svnroot/geany/trunk@5970 ea778897-0a13-0410-b9d1-a72fbfd435f5
We could have something like this:
git-svn-id: [ea778897-0a13-0410-b9d1-a72fbfd435f5] (http://svn.geany.org/svnroot/geany/trunk?rev=5970)
That way we could make the links work and be able to move the old SVN repository without breaking all the links in the commit message. I guess we'd need a little redirect script or something on geany.org. Note also the use of Markdown link syntax, which might render better on Github (not sure).
I'm afraid I don't get what is needed here? Did I got you right to setup complete mirror of ancient svn on geany.org?
Cheers, Frank
On 11-10-30 03:03 PM, Frank Lanitz wrote:
On Sun, 30 Oct 2011 02:15:33 -0700 Matthew Brushmbrush@codebrainz.ca wrote:
Hi,
I haven't heard too much about the Git conversion of Geany Plugins, but I wanted to offer a suggestion that might improve the commit messages compared to Geany's. In the Geany's Git repository there's links back to the SVN repository in the commit messages (the links are broken BTW). I was wondering if it would be better to have these links point to a place we have more control over, for example using a Geany commit, instead of this in the commit message:
git-svn-id: https://geany.svn.sourceforge.net/svnroot/geany/trunk@5970 ea778897-0a13-0410-b9d1-a72fbfd435f5
We could have something like this:
git-svn-id: [ea778897-0a13-0410-b9d1-a72fbfd435f5] (http://svn.geany.org/svnroot/geany/trunk?rev=5970)
That way we could make the links work and be able to move the old SVN repository without breaking all the links in the commit message. I guess we'd need a little redirect script or something on geany.org. Note also the use of Markdown link syntax, which might render better on Github (not sure).
I'm afraid I don't get what is needed here? Did I got you right to setup complete mirror of ancient svn on geany.org?
Or easier, just make some URL forwarders/rewrites on geany.org so we don't have to depend on SourceForge.net to always store the SVN repo and never change URLs. The SVN URLs in the Git commit messages will never be able to change ever in the future, so if we point it to a location we control, then we can ensure they remain valid.
From Jiri's other message though, it sounds like the SVN URLs in the Git commit messages are all going to be broken like the one's in Geany's Git repository, since it's not an option of the conversion script to change them. I don't feel like hacking the conversion script to change the URL that goes in the commit message, and anyway, as long as it contains the SVN revision, it's still useful.
Cheers, Matthew Brush
On Sun, Oct 30, 2011 at 23:25, Matthew Brush mbrush@codebrainz.ca wrote:
On 11-10-30 03:03 PM, Frank Lanitz wrote:
On Sun, 30 Oct 2011 02:15:33 -0700 Matthew Brushmbrush@codebrainz.ca wrote:
Hi,
I haven't heard too much about the Git conversion of Geany Plugins, but I wanted to offer a suggestion that might improve the commit messages compared to Geany's. In the Geany's Git repository there's links back to the SVN repository in the commit messages (the links are broken BTW). I was wondering if it would be better to have these links point to a place we have more control over, for example using a Geany commit, instead of this in the commit message:
git-svn-id: https://geany.svn.sourceforge.net/svnroot/geany/trunk@5970 ea778897-0a13-0410-b9d1-a72fbfd435f5
We could have something like this:
git-svn-id: [ea778897-0a13-0410-b9d1-a72fbfd435f5] (http://svn.geany.org/svnroot/geany/trunk?rev=5970)
That way we could make the links work and be able to move the old SVN repository without breaking all the links in the commit message. I guess we'd need a little redirect script or something on geany.org. Note also the use of Markdown link syntax, which might render better on Github (not sure).
I'm afraid I don't get what is needed here? Did I got you right to setup complete mirror of ancient svn on geany.org?
Or easier, just make some URL forwarders/rewrites on geany.org so we don't have to depend on SourceForge.net to always store the SVN repo and never change URLs. The SVN URLs in the Git commit messages will never be able to change ever in the future, so if we point it to a location we control, then we can ensure they remain valid.
From Jiri's other message though, it sounds like the SVN URLs in the Git commit messages are all going to be broken like the one's in Geany's Git repository, since it's not an option of the conversion script to change them. I don't feel like hacking the conversion script to change the URL that goes in the commit message, and anyway, as long as it contains the SVN revision, it's still useful.
Another option would be to use
git filter-branch --msg-filter command
where command would be some sed expression which would substitute the current format with the required format. Maybe a bit easier, still something I don't want to spend my time on ;-). The only reason I included the SVN metadata was the commit ID which is useful to have because some commits refer to it in their comments and this information would be lost otherwise.
Cheers, Jiri
Am 01.11.2011 14:11, schrieb Jiří Techet:
where command would be some sed expression which would substitute the current format with the required format. Maybe a bit easier, still something I don't want to spend my time on ;-). The only reason I included the SVN metadata was the commit ID which is useful to have because some commits refer to it in their comments and this information would be lost otherwise.
I agree the commit url isn't terribly important, and even less under whose control the old svn repo since, you know, the history is there in that very git clone :)
Best regards.
On 11-11-01 06:11 AM, Jiří Techet wrote:
On Sun, Oct 30, 2011 at 23:25, Matthew Brushmbrush@codebrainz.ca wrote:
On 11-10-30 03:03 PM, Frank Lanitz wrote:
On Sun, 30 Oct 2011 02:15:33 -0700 Matthew Brushmbrush@codebrainz.ca wrote:
Hi,
I haven't heard too much about the Git conversion of Geany Plugins, but I wanted to offer a suggestion that might improve the commit messages compared to Geany's. In the Geany's Git repository there's links back to the SVN repository in the commit messages (the links are broken BTW). I was wondering if it would be better to have these links point to a place we have more control over, for example using a Geany commit, instead of this in the commit message:
git-svn-id: https://geany.svn.sourceforge.net/svnroot/geany/trunk@5970 ea778897-0a13-0410-b9d1-a72fbfd435f5
We could have something like this:
git-svn-id: [ea778897-0a13-0410-b9d1-a72fbfd435f5] (http://svn.geany.org/svnroot/geany/trunk?rev=5970)
That way we could make the links work and be able to move the old SVN repository without breaking all the links in the commit message. I guess we'd need a little redirect script or something on geany.org. Note also the use of Markdown link syntax, which might render better on Github (not sure).
I'm afraid I don't get what is needed here? Did I got you right to setup complete mirror of ancient svn on geany.org?
Or easier, just make some URL forwarders/rewrites on geany.org so we don't have to depend on SourceForge.net to always store the SVN repo and never change URLs. The SVN URLs in the Git commit messages will never be able to change ever in the future, so if we point it to a location we control, then we can ensure they remain valid.
From Jiri's other message though, it sounds like the SVN URLs in the Git commit messages are all going to be broken like the one's in Geany's Git repository, since it's not an option of the conversion script to change them. I don't feel like hacking the conversion script to change the URL that goes in the commit message, and anyway, as long as it contains the SVN revision, it's still useful.
Another option would be to use
git filter-branch --msg-filter command
where command would be some sed expression which would substitute the current format with the required format. Maybe a bit easier, still something I don't want to spend my time on ;-). The only reason I included the SVN metadata was the commit ID which is useful to have because some commits refer to it in their comments and this information would be lost otherwise.
What about something as simple as:
sed |git-svn-id: https://geany-plugins.svn.sourceforge.net/svnroot/geany-plugins/trunk/geany-...
To at least remove the invalid URL, or better yet:
sed |geany-plugins@|geany-plugins?revision=|
Or similar, so that the URL is not broken?
If it's easy enough, I'd say it's worthwhile.
Cheers, Matthew Brush
Le 01/11/2011 15:43, Matthew Brush a écrit :
On 11-11-01 06:11 AM, Jiří Techet wrote:
On Sun, Oct 30, 2011 at 23:25, Matthew Brushmbrush@codebrainz.ca wrote:
On 11-10-30 03:03 PM, Frank Lanitz wrote:
On Sun, 30 Oct 2011 02:15:33 -0700 Matthew Brushmbrush@codebrainz.ca wrote:
Hi,
I haven't heard too much about the Git conversion of Geany Plugins, but I wanted to offer a suggestion that might improve the commit messages compared to Geany's. In the Geany's Git repository there's links back to the SVN repository in the commit messages (the links are broken BTW). I was wondering if it would be better to have these links point to a place we have more control over, for example using a Geany commit, instead of this in the commit message:
git-svn-id: https://geany.svn.sourceforge.net/svnroot/geany/trunk@5970 ea778897-0a13-0410-b9d1-a72fbfd435f5
We could have something like this:
git-svn-id: [ea778897-0a13-0410-b9d1-a72fbfd435f5] (http://svn.geany.org/svnroot/geany/trunk?rev=5970)
That way we could make the links work and be able to move the old SVN repository without breaking all the links in the commit message. I guess we'd need a little redirect script or something on geany.org. Note also the use of Markdown link syntax, which might render better on Github (not sure).
I'm afraid I don't get what is needed here? Did I got you right to setup complete mirror of ancient svn on geany.org?
Or easier, just make some URL forwarders/rewrites on geany.org so we don't have to depend on SourceForge.net to always store the SVN repo and never change URLs. The SVN URLs in the Git commit messages will never be able to change ever in the future, so if we point it to a location we control, then we can ensure they remain valid.
From Jiri's other message though, it sounds like the SVN URLs in the Git commit messages are all going to be broken like the one's in Geany's Git repository, since it's not an option of the conversion script to change them. I don't feel like hacking the conversion script to change the URL that goes in the commit message, and anyway, as long as it contains the SVN revision, it's still useful.
Another option would be to use
git filter-branch --msg-filter command
where command would be some sed expression which would substitute the current format with the required format. Maybe a bit easier, still something I don't want to spend my time on ;-). The only reason I included the SVN metadata was the commit ID which is useful to have because some commits refer to it in their comments and this information would be lost otherwise.
What about something as simple as:
sed |git-svn-id: https://geany-plugins.svn.sourceforge.net/svnroot/geany-plugins/trunk/geany-...
To at least remove the invalid URL, or better yet:
sed |geany-plugins@|geany-plugins?revision=|
Or similar, so that the URL is not broken?
If it's easy enough, I'd say it's worthwhile.
Although I don't mind much, isn't "@rev" more readable than "?revision=rev"? I mean, the history will be in Git already, so is it more important to have a valid URL to the old SVN repo or a readable reference?
Just my 2¢ Colomban
On 11/01/2011 07:50 AM, Colomban Wendling wrote:
Le 01/11/2011 15:43, Matthew Brush a écrit :
On 11-11-01 06:11 AM, Jiří Techet wrote:
On Sun, Oct 30, 2011 at 23:25, Matthew Brushmbrush@codebrainz.ca wrote:
On 11-10-30 03:03 PM, Frank Lanitz wrote:
On Sun, 30 Oct 2011 02:15:33 -0700 Matthew Brushmbrush@codebrainz.ca wrote:
Hi,
I haven't heard too much about the Git conversion of Geany Plugins, but I wanted to offer a suggestion that might improve the commit messages compared to Geany's. In the Geany's Git repository there's links back to the SVN repository in the commit messages (the links are broken BTW). I was wondering if it would be better to have these links point to a place we have more control over, for example using a Geany commit, instead of this in the commit message:
git-svn-id: https://geany.svn.sourceforge.net/svnroot/geany/trunk@5970 ea778897-0a13-0410-b9d1-a72fbfd435f5
We could have something like this:
git-svn-id: [ea778897-0a13-0410-b9d1-a72fbfd435f5] (http://svn.geany.org/svnroot/geany/trunk?rev=5970)
That way we could make the links work and be able to move the old SVN repository without breaking all the links in the commit message. I guess we'd need a little redirect script or something on geany.org. Note also the use of Markdown link syntax, which might render better on Github (not sure).
I'm afraid I don't get what is needed here? Did I got you right to setup complete mirror of ancient svn on geany.org?
Or easier, just make some URL forwarders/rewrites on geany.org so we don't have to depend on SourceForge.net to always store the SVN repo and never change URLs. The SVN URLs in the Git commit messages will never be able to change ever in the future, so if we point it to a location we control, then we can ensure they remain valid.
From Jiri's other message though, it sounds like the SVN URLs in the Git commit messages are all going to be broken like the one's in Geany's Git repository, since it's not an option of the conversion script to change them. I don't feel like hacking the conversion script to change the URL that goes in the commit message, and anyway, as long as it contains the SVN revision, it's still useful.
Another option would be to use
git filter-branch --msg-filter command
where command would be some sed expression which would substitute the current format with the required format. Maybe a bit easier, still something I don't want to spend my time on ;-). The only reason I included the SVN metadata was the commit ID which is useful to have because some commits refer to it in their comments and this information would be lost otherwise.
What about something as simple as:
sed |git-svn-id: https://geany-plugins.svn.sourceforge.net/svnroot/geany-plugins/trunk/geany-...
To at least remove the invalid URL, or better yet:
sed |geany-plugins@|geany-plugins?revision=|
Or similar, so that the URL is not broken?
If it's easy enough, I'd say it's worthwhile.
Although I don't mind much, isn't "@rev" more readable than "?revision=rev"? I mean, the history will be in Git already, so is it more important to have a valid URL to the old SVN repo or a readable reference?
IMO, if there's going to be a hyperlink, it should not be broken, otherwise we should use something like the first option, to just remove the broken URL all together and have something like `SVN revision 1234` or `SVN @1234` or something.
Cheers, Matthew Brush
On Tue, Nov 1, 2011 at 15:43, Matthew Brush mbrush@codebrainz.ca wrote:
On 11-11-01 06:11 AM, Jiří Techet wrote:
On Sun, Oct 30, 2011 at 23:25, Matthew Brushmbrush@codebrainz.ca wrote:
On 11-10-30 03:03 PM, Frank Lanitz wrote:
On Sun, 30 Oct 2011 02:15:33 -0700 Matthew Brushmbrush@codebrainz.ca wrote:
Hi,
I haven't heard too much about the Git conversion of Geany Plugins, but I wanted to offer a suggestion that might improve the commit messages compared to Geany's. In the Geany's Git repository there's links back to the SVN repository in the commit messages (the links are broken BTW). I was wondering if it would be better to have these links point to a place we have more control over, for example using a Geany commit, instead of this in the commit message:
git-svn-id: https://geany.svn.sourceforge.net/svnroot/geany/trunk@5970 ea778897-0a13-0410-b9d1-a72fbfd435f5
We could have something like this:
git-svn-id: [ea778897-0a13-0410-b9d1-a72fbfd435f5] (http://svn.geany.org/svnroot/geany/trunk?rev=5970)
That way we could make the links work and be able to move the old SVN repository without breaking all the links in the commit message. I guess we'd need a little redirect script or something on geany.org. Note also the use of Markdown link syntax, which might render better on Github (not sure).
I'm afraid I don't get what is needed here? Did I got you right to setup complete mirror of ancient svn on geany.org?
Or easier, just make some URL forwarders/rewrites on geany.org so we don't have to depend on SourceForge.net to always store the SVN repo and never change URLs. The SVN URLs in the Git commit messages will never be able to change ever in the future, so if we point it to a location we control, then we can ensure they remain valid.
From Jiri's other message though, it sounds like the SVN URLs in the Git commit messages are all going to be broken like the one's in Geany's Git repository, since it's not an option of the conversion script to change them. I don't feel like hacking the conversion script to change the URL that goes in the commit message, and anyway, as long as it contains the SVN revision, it's still useful.
Another option would be to use
git filter-branch --msg-filter command
where command would be some sed expression which would substitute the current format with the required format. Maybe a bit easier, still something I don't want to spend my time on ;-). The only reason I included the SVN metadata was the commit ID which is useful to have because some commits refer to it in their comments and this information would be lost otherwise.
What about something as simple as:
sed |git-svn-id: https://geany-plugins.svn.sourceforge.net/svnroot/geany-plugins/trunk/geany-...
To at least remove the invalid URL, or better yet:
sed |geany-plugins@|geany-plugins?revision=|
Or similar, so that the URL is not broken?
If it's easy enough, I'd say it's worthwhile.
Hi Matthew,
could you test if it does the right thing with git filter-branch? (I'm quite busy these days.)
Cheers, Jiri
On 11/02/2011 08:17 AM, Jiří Techet wrote:
On Tue, Nov 1, 2011 at 15:43, Matthew Brushmbrush@codebrainz.ca wrote:
On 11-11-01 06:11 AM, Jiří Techet wrote:
On Sun, Oct 30, 2011 at 23:25, Matthew Brushmbrush@codebrainz.ca wrote:
On 11-10-30 03:03 PM, Frank Lanitz wrote:
On Sun, 30 Oct 2011 02:15:33 -0700 Matthew Brushmbrush@codebrainz.ca wrote:
Hi,
I haven't heard too much about the Git conversion of Geany Plugins, but I wanted to offer a suggestion that might improve the commit messages compared to Geany's. In the Geany's Git repository there's links back to the SVN repository in the commit messages (the links are broken BTW). I was wondering if it would be better to have these links point to a place we have more control over, for example using a Geany commit, instead of this in the commit message:
git-svn-id: https://geany.svn.sourceforge.net/svnroot/geany/trunk@5970 ea778897-0a13-0410-b9d1-a72fbfd435f5
We could have something like this:
git-svn-id: [ea778897-0a13-0410-b9d1-a72fbfd435f5] (http://svn.geany.org/svnroot/geany/trunk?rev=5970)
That way we could make the links work and be able to move the old SVN repository without breaking all the links in the commit message. I guess we'd need a little redirect script or something on geany.org. Note also the use of Markdown link syntax, which might render better on Github (not sure).
I'm afraid I don't get what is needed here? Did I got you right to setup complete mirror of ancient svn on geany.org?
Or easier, just make some URL forwarders/rewrites on geany.org so we don't have to depend on SourceForge.net to always store the SVN repo and never change URLs. The SVN URLs in the Git commit messages will never be able to change ever in the future, so if we point it to a location we control, then we can ensure they remain valid.
From Jiri's other message though, it sounds like the SVN URLs in the Git commit messages are all going to be broken like the one's in Geany's Git repository, since it's not an option of the conversion script to change them. I don't feel like hacking the conversion script to change the URL that goes in the commit message, and anyway, as long as it contains the SVN revision, it's still useful.
Another option would be to use
git filter-branch --msg-filter command
where command would be some sed expression which would substitute the current format with the required format. Maybe a bit easier, still something I don't want to spend my time on ;-). The only reason I included the SVN metadata was the commit ID which is useful to have because some commits refer to it in their comments and this information would be lost otherwise.
What about something as simple as:
sed |git-svn-id: https://geany-plugins.svn.sourceforge.net/svnroot/geany-plugins/trunk/geany-...
To at least remove the invalid URL, or better yet:
sed |geany-plugins@|geany-plugins?revision=|
Or similar, so that the URL is not broken?
If it's easy enough, I'd say it's worthwhile.
Hi Matthew,
could you test if it does the right thing with git filter-branch? (I'm quite busy these days.)
All on one line:
git filter-branch --msg-filter "sed -e 's|svnroot/geany-plugins/trunk/geany-plugins@|viewvc/geany-plugins?view=revision&revision=|'" HEAD
Works fine at least looking at quite a few of the commits in gitk and has the advantage of linking to the better ViewVC code browser that SourceForge offers.
Cheers, Matthew Brush
On Thu, Nov 3, 2011 at 03:18, Matthew Brush mbrush@codebrainz.ca wrote:
On 11/02/2011 08:17 AM, Jiří Techet wrote:
On Tue, Nov 1, 2011 at 15:43, Matthew Brushmbrush@codebrainz.ca wrote:
On 11-11-01 06:11 AM, Jiří Techet wrote:
On Sun, Oct 30, 2011 at 23:25, Matthew Brushmbrush@codebrainz.ca wrote:
On 11-10-30 03:03 PM, Frank Lanitz wrote:
On Sun, 30 Oct 2011 02:15:33 -0700 Matthew Brushmbrush@codebrainz.ca wrote:
> Hi, > > I haven't heard too much about the Git conversion of Geany Plugins, > but I wanted to offer a suggestion that might improve the commit > messages compared to Geany's. In the Geany's Git repository there's > links back to the SVN repository in the commit messages (the links > are broken BTW). I was wondering if it would be better to have these > links point to a place we have more control over, for example using a > Geany commit, instead of this in the commit message: > > git-svn-id: > https://geany.svn.sourceforge.net/svnroot/geany/trunk@5970 > ea778897-0a13-0410-b9d1-a72fbfd435f5 > > We could have something like this: > > git-svn-id: > [ea778897-0a13-0410-b9d1-a72fbfd435f5] > (http://svn.geany.org/svnroot/geany/trunk?rev=5970) > > That way we could make the links work and be able to move the old SVN > repository without breaking all the links in the commit message. I > guess we'd need a little redirect script or something on geany.org. > Note also the use of Markdown link syntax, which might render better > on Github (not sure).
I'm afraid I don't get what is needed here? Did I got you right to setup complete mirror of ancient svn on geany.org?
Or easier, just make some URL forwarders/rewrites on geany.org so we don't have to depend on SourceForge.net to always store the SVN repo and never change URLs. The SVN URLs in the Git commit messages will never be able to change ever in the future, so if we point it to a location we control, then we can ensure they remain valid.
From Jiri's other message though, it sounds like the SVN URLs in the Git commit messages are all going to be broken like the one's in Geany's Git repository, since it's not an option of the conversion script to change them. I don't feel like hacking the conversion script to change the URL that goes in the commit message, and anyway, as long as it contains the SVN revision, it's still useful.
Another option would be to use
git filter-branch --msg-filter command
where command would be some sed expression which would substitute the current format with the required format. Maybe a bit easier, still something I don't want to spend my time on ;-). The only reason I included the SVN metadata was the commit ID which is useful to have because some commits refer to it in their comments and this information would be lost otherwise.
What about something as simple as:
sed |git-svn-id:
https://geany-plugins.svn.sourceforge.net/svnroot/geany-plugins/trunk/geany-...
To at least remove the invalid URL, or better yet:
sed |geany-plugins@|geany-plugins?revision=|
Or similar, so that the URL is not broken?
If it's easy enough, I'd say it's worthwhile.
Hi Matthew,
could you test if it does the right thing with git filter-branch? (I'm quite busy these days.)
All on one line:
git filter-branch --msg-filter "sed -e 's|svnroot/geany-plugins/trunk/geany-plugins@|viewvc/geany-plugins?view=revision&revision=|'" HEAD
Works fine at least looking at quite a few of the commits in gitk and has the advantage of linking to the better ViewVC code browser that SourceForge offers.
OK, thanks. So is there any "official" conclusion which format should be used? (I don't have any strong preference here.)
Also when should the final conversion be done? I fight with time a bit these days but the conversion of geany-plugins requires much less manual changes than the conversion of Geany's repository so I can reserve the hour or two for it (almost) any time. Just tell the date.
Cheers, Jiri
Le 04/11/2011 23:28, Jiří Techet a écrit :
On Thu, Nov 3, 2011 at 03:18, Matthew Brush mbrush@codebrainz.ca wrote:
[...]
All on one line:
git filter-branch --msg-filter "sed -e 's|svnroot/geany-plugins/trunk/geany-plugins@|viewvc/geany-plugins?view=revision&revision=|'" HEAD
Works fine at least looking at quite a few of the commits in gitk and has the advantage of linking to the better ViewVC code browser that SourceForge offers.
OK, thanks. So is there any "official" conclusion which format should be used? (I don't have any strong preference here.)
I'd personally prefer to have a valid SVN URL rather than a valid HTTP link, but again, I don't mind much.
Cheers, Colomban
On 11-11-04 04:03 PM, Colomban Wendling wrote:
Le 04/11/2011 23:28, Jiří Techet a écrit :
On Thu, Nov 3, 2011 at 03:18, Matthew Brushmbrush@codebrainz.ca wrote:
[...]
All on one line:
git filter-branch --msg-filter "sed -e 's|svnroot/geany-plugins/trunk/geany-plugins@|viewvc/geany-plugins?view=revision&revision=|'" HEAD
Works fine at least looking at quite a few of the commits in gitk and has the advantage of linking to the better ViewVC code browser that SourceForge offers.
OK, thanks. So is there any "official" conclusion which format should be used? (I don't have any strong preference here.)
I'd personally prefer to have a valid SVN URL rather than a valid HTTP link, but again, I don't mind much.
Thanks for pointing out now *after* so much time and discussion that the existing URL *was a valid SVN URL*. I'm glad I wasted my time :) </sarcasm>
@Jiri I'd say it's your call, in light of this new information, I'd say leave it as is and get it done as soon as you have time (assuming no one else objects).
Cheers, Matthew Brush
Le 05/11/2011 01:28, Matthew Brush a écrit :
On 11-11-04 04:03 PM, Colomban Wendling wrote:
Le 04/11/2011 23:28, Jiří Techet a écrit :
On Thu, Nov 3, 2011 at 03:18, Matthew Brushmbrush@codebrainz.ca wrote:
[...]
All on one line:
git filter-branch --msg-filter "sed -e 's|svnroot/geany-plugins/trunk/geany-plugins@|viewvc/geany-plugins?view=revision&revision=|'"
HEAD
Works fine at least looking at quite a few of the commits in gitk and has the advantage of linking to the better ViewVC code browser that SourceForge offers.
OK, thanks. So is there any "official" conclusion which format should be used? (I don't have any strong preference here.)
I'd personally prefer to have a valid SVN URL rather than a valid HTTP link, but again, I don't mind much.
Thanks for pointing out now *after* so much time and discussion that the existing URL *was a valid SVN URL*. I'm glad I wasted my time :)
</sarcasm>
@Jiri I'd say it's your call, in light of this new information, I'd say leave it as is and get it done as soon as you have time (assuming no one else objects).
Sorry, I though you already knew it :/
However, Enrico agreed with setting up something appropriate on geany.org, so if you think it's worth it, maybe it'd be possible to have svn.geany.org/svnroot/geany-plugins@rev as a URL both valid for SVN and a viewvc. I totally agree that having the URL somewhere we control is better, I'm just not completely sure it's worth the effort (but maybe it's actually cheap, dunno).
Regards, Colomban
On Sun, 30 Oct 2011 15:25:10 -0700, Matthew wrote:
On 11-10-30 03:03 PM, Frank Lanitz wrote:
On Sun, 30 Oct 2011 02:15:33 -0700 Matthew Brushmbrush@codebrainz.ca wrote:
Hi,
I haven't heard too much about the Git conversion of Geany Plugins, but I wanted to offer a suggestion that might improve the commit messages compared to Geany's. In the Geany's Git repository there's links back to the SVN repository in the commit messages (the links are broken BTW). I was wondering if it would be better to have these links point to a place we have more control over, for example using a Geany commit, instead of this in the commit message:
git-svn-id: https://geany.svn.sourceforge.net/svnroot/geany/trunk@5970 ea778897-0a13-0410-b9d1-a72fbfd435f5
We could have something like this:
git-svn-id: [ea778897-0a13-0410-b9d1-a72fbfd435f5] (http://svn.geany.org/svnroot/geany/trunk?rev=5970)
That way we could make the links work and be able to move the old SVN repository without breaking all the links in the commit message. I guess we'd need a little redirect script or something on geany.org. Note also the use of Markdown link syntax, which might render better on Github (not sure).
I'm afraid I don't get what is needed here? Did I got you right to setup complete mirror of ancient svn on geany.org?
Or easier, just make some URL forwarders/rewrites on geany.org so we don't have to depend on SourceForge.net to always store the SVN repo and never change URLs. The SVN URLs in the Git commit messages will never be able to change ever in the future, so if we point it to a location we control, then we can ensure they remain valid.
I didn't follow the discussion completely but I'd be fine with setting up some URL forwarders or even a copy of the SVN repository on geany.org. Just tell me what you would like (once we have a decision).
Regards, Enrico