On Mon, 15 Mar 2010 14:06:29 +0000 eht16@users.sourceforge.net wrote:
Revision: 4763 http://geany.svn.sourceforge.net/geany/?rev=4763&view=rev Author: eht16 Date: 2010-03-15 14:06:29 +0000 (Mon, 15 Mar 2010)
Log Message:
Fix/Improve GIT repository detection (patch by Thomas Martitz, thanks).
...
if svn_rev != '-1': print_message(conf, 'Compiling Subversion revision', svn_rev)
conf.env.append_value('CCFLAGS', '-g -DGEANY_DEBUG'.split())
conf.env.append_value('CCFLAGS', '-g -O0 -DGEANY_DEBUG'.split())
Do we really want to force -O0 for wscript SVN builds?
Also, as I don't know Waf well, does it only support building with gcc?
Regards, Nick
Am 16.03.2010 13:51, schrieb Nick Treleaven:
Do we really want to force -O0 for wscript SVN builds?
I don't understand that either. The same happens in geany-plugins. What is the rational behind using -O0? Am I forced to use releases now in order not get crappy generated code (if you have ever looked at a disassembly of -O0 code, then you know what I mean)?
Also, as I don't know Waf well, does it only support building with gcc?
Regards, Nick
I can't comment here, but the code at least looks like being generic.
Best regards.
On Tue, 16 Mar 2010 14:54:00 +0100 Thomas Martitz thomas.martitz@student.HTW-Berlin.de wrote:
Also, as I don't know Waf well, does it only support building with gcc?
Regards, Nick
I can't comment here, but the code at least looks like being generic.
I was thinking about the compiler flags, -g and -DFOO are probably somewhat 'standard' but I don't know about -O0.
Regards, Nick
Am 16.03.2010 17:22, schrieb Nick Treleaven:
I was thinking about the compiler flags, -g and -DFOO are probably somewhat 'standard' but I don't know about -O0.
Regards, Nick
IIUC -O(n) is more or less standard as well. I know MSVC can handle them, and probably other compilers as well.
On Tue, 16 Mar 2010 12:51:35 +0000, Nick wrote:
On Mon, 15 Mar 2010 14:06:29 +0000 eht16@users.sourceforge.net wrote:
Revision: 4763 http://geany.svn.sourceforge.net/geany/?rev=4763&view=rev Author: eht16 Date: 2010-03-15 14:06:29 +0000 (Mon, 15 Mar 2010)
Log Message:
Fix/Improve GIT repository detection (patch by Thomas Martitz, thanks).
...
if svn_rev != '-1': print_message(conf, 'Compiling Subversion revision', svn_rev)
conf.env.append_value('CCFLAGS', '-g-DGEANY_DEBUG'.split())
conf.env.append_value('CCFLAGS', '-g -O0-DGEANY_DEBUG'.split())
Do we really want to force -O0 for wscript SVN builds?
Nah, that was a funny mistake :). I committed the other changes of the revision 4763 and while waiting for the commit to finish, I added -O0 to test something and then accidentally hit Ctrl-S to save too early and so this change got committed as well by Subversion.
I'll revert it, also in the geany-plugins' wscript where it was since a long time though I'm not sure why I added it, it definitely makes no sense to add compiler-specific compile flags to the build system. Sorry.
Also, as I don't know Waf well, does it only support building with gcc?
No, it also supports icc and mscc, though I never tested those.
Regards, Enrico
On Tue, 16 Mar 2010 21:24:13 +0100 Enrico Tröger enrico.troeger@uvena.de wrote:
Do we really want to force -O0 for wscript SVN builds?
Nah, that was a funny mistake :). I committed the other changes of the revision 4763 and while waiting for the commit to finish, I added -O0 to test something and then accidentally hit Ctrl-S to save too early and so this change got committed as well by Subversion.
I did that once but managed to Ctrl-C subversion luckily. I think Git doesn't have this problem.
I'll revert it, also in the geany-plugins' wscript where it was since a long time though I'm not sure why I added it, it definitely makes no sense to add compiler-specific compile flags to the build system. Sorry.
No problem, glad it's resolved now, thanks.
Also, as I don't know Waf well, does it only support building with gcc?
No, it also supports icc and mscc, though I never tested those.
Cool - I don't use them personally but nice to know.
Regards, Nick