On 16/04/13 20:26, Dimitar Zhekov wrote:

Hi,

When I run 'python waf configure' under Windows, it detects msvc before gcc, but 'python waf make' produces lots of:

cl : Command line warning D9002 : ignoring unknown option '-mms-bitfields'

warnings, and then stops with:

bibtex.c ...\geanylatex\src\templates.h(81) : error C2143: syntax error : missing ')' before '*' ...\geanylatex\src\templates.h(81) : error C2143: syntax error : missing '{' before '*' ...\geanylatex\src \templates.h(81) : error C2040: 'gpointer' : 'int' differs in levels of indirection from 'void *' ...\geanylatex\src \templates.h(81) : error C2143: syntax error : missing ';' before '*' ...\geanylatex\src \templates.h(81) : error C2059: syntax error : ')'

This is with geany-plugins 2013-03-12.

Info(gcc) says that "-m[no-]ms-bitfields is provided for the Microsoft Windows X86 compilers to match the native Microsoft compiler", so it's obviously useless for the MS compiler itself.

The errors may be caused by cl confusing 'template' with the C++ keyword, I haven't checked.

Do we support msvc in the first place?..

I'd say not yet. I don't have MSVC and so could not test it. Do you have any clue where the -mms-bitfields comes from? I couldn't find any reference in the whole repository.

If the errors are only because of a naming clash, this would be quite easy to fix I guess.

Btw, does Geany build with MSVC?

Regards, Enrico

Am 17.04.2013 02:29, schrieb Lex Trotman:

If the errors are only because of a naming clash, this would be quite
easy to fix I guess.


Btw, does Geany build with MSVC?

Note that as I understand it, it would not necessarily work to use a plugin compiled with msvc and a Geany compiled with gcc. It might, but no guarantee.

/Should/ work as the C ABI is standardized.

Best regards.

On Tue, 16 Apr 2013 22:21:25 +0200 Enrico Tröger enrico.troeger@uvena.de wrote:

On 16/04/13 20:26, Dimitar Zhekov wrote:

...

Hi,

When I run 'python waf configure' under Windows, it detects msvc before gcc, but 'python waf make' produces lots of:

cl : Command line warning D9002 : ignoring unknown option '-mms-bitfields'

warnings, and then stops with:

bibtex.c ...\geanylatex\src\templates.h(81) : error C2143: syntax error : missing ')' before '*' [...]

Do we support msvc in the first place?..

I'd say not yet.

Then can you, or somebody else familiar with waf, forbid the detection of msvc?

I don't have MSVC and so could not test it. Do you have any clue where the -mms-bitfields comes from? I couldn't find any reference in the whole repository.

gtk+: gtkmain.c: #ifdef G_PLATFORM_WIN32 check_sizeof_GtkWindow(): ... g_error("... this probably means that you have compiled your code with gcc without the -mms-bitfields switch, or [...] unsupported compiler.")

If the errors are only because of a naming clash, this would be quite easy to fix I guess.

Unless it barks on any C++ keyword used as an identifier. With a mixed C/C++ compiler, that's possible, and MS are not exactly famous for following the standards strictly...

Btw, does Geany build with MSVC?

Hmmm, never tried. I'll check it tomorrow (unless I forget).

On 18 April 2013 02:46, Dimitar Zhekov dimitar.zhekov@gmail.com wrote:

On Wed, 17 Apr 2013 10:29:55 +1000 Lex Trotman elextr@gmail.com wrote:

...

Note that as I understand it, it would not necessarily work to use a plugin compiled with msvc and a Geany compiled with gcc. It might, but no guarantee.

All gtk+ code must be compiled with gcc -mms-bitfields under Win~1, so any mix should work. The plugins never access Scintilla C++ directly, they use Geany's sci_wrappers.c functions.

Thats good, there is also the following warning on the GTK download:

"It is possible to use these packages also with Microsoft's compiler. However, the DLLs here use the msvcrt.dll run-time library. This means that also applications that use the DLLs should preferably use the msvcrt.dll run-time. Specifically, this means that you should not use newer versions of the Microsoft compiler than Visual C++ 6 without knowing exactly what you are doing."

You were warned :)

Cheers Lex

-- E-gards: Jimmy _______________________________________________ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel

On 18/04/13 19:36, Dimitar Zhekov wrote:

On Tue, 16 Apr 2013 22:21:25 +0200 Enrico Tröger enrico.troeger@uvena.de wrote:

...

Btw, does Geany build with MSVC?

No. The '-mms-bitfields' warnings aside, it fails with:

..\plugins\saveactions.c(30) : fatal error C1083: Cannot open include file: 'unistd.h': No such file or directory

So, we have Geany as geany-pplugins with do not compile with msvc, and the msvcrt.dll problem pointed by Lex. Disabling the msvc detection seems even more reasonable to me, for example:

from waflib.Tools.compiler_c import c_compiler
c_compiler['win32'] = ['gcc']

just before opt.tool_options('compiler_cc') in both wscript files.

I agree. I also vote for disabling msvc detection paired with a comment that it can be enabled again once someone steps up with a working patch for MSVC support and a good reasoning why it should be supported :).

Thanks for your efforts.

Regards, Enrico

On 19/04/13 01:31, Lex Trotman wrote:

On 19 April 2013 03:59, Enrico Tröger enrico.troeger@uvena.de wrote:

...

On 18/04/13 19:36, Dimitar Zhekov wrote:

...

On Tue, 16 Apr 2013 22:21:25 +0200 Enrico Tröger enrico.troeger@uvena.de wrote:

...

Btw, does Geany build with MSVC?

No. The '-mms-bitfields' warnings aside, it fails with:

..\plugins\saveactions.c(30) : fatal error C1083: Cannot open include file: 'unistd.h': No such file or directory

So, we have Geany as geany-pplugins with do not compile with msvc, and the msvcrt.dll problem pointed by Lex. Disabling the msvc detection seems even more reasonable to me, for example:

from waflib.Tools.compiler_c import c_compiler
c_compiler['win32'] = ['gcc']

just before opt.tool_options('compiler_cc') in both wscript files.

I agree. I also vote for disabling msvc detection paired with a comment that it can be enabled again once someone steps up with a working patch for MSVC support and a good reasoning why it should be supported :).

Sounds like a plan :)

"I love it when a plan comes together.", er, I mean committed as suggested to Geany and Geany-Plugins.

Regards, Enrico