Good day,
I followed the "Hacking Geany" guide to add Smalltalk support into Geany. I basically just plugged in the official Smalltalk lexer from the Scintilla project, so I guess it's not that big of a deal. Maybe it would be a good idea if it were merged into the official repository? I'd be thankful if it were, personally. I'm sending a patch because I don't have a Github account. It's a small patch anyway. I tested it on Windows after downloading the zip file from the master branch of the Github repository. By the way, the patch file has CRLF new lines.
Thanks in advance for everything. The documentation was pretty useful!
Geany is a volunteer project, nothing will happen unless "somebody" submits a pull request. Not saying it will be accepted, but if nobody has done it to date it likely means nobody uses smalltalk and it isn't going to happen otherwise.
Cheers Lex
On Thu, 14 Nov 2019 at 07:04, Snowflake the Pony snowflakethepony@hotmail.com wrote:
Good day,
I followed the "Hacking Geany" guide to add Smalltalk support into Geany. I basically just plugged in the official Smalltalk lexer from the Scintilla project, so I guess it's not that big of a deal. Maybe it would be a good idea if it were merged into the official repository? I'd be thankful if it were, personally. I'm sending a patch because I don't have a Github account. It's a small patch anyway. I tested it on Windows after downloading the zip file from the master branch of the Github repository. By the way, the patch file has CRLF new lines.
Thanks in advance for everything. The documentation was pretty useful!
Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Le 13/11/2019 à 22:24, Lex Trotman a écrit :
Geany is a volunteer project, nothing will happen unless "somebody" submits a pull request. Not saying it will be accepted, but if nobody has done it to date it likely means nobody uses smalltalk and it isn't going to happen otherwise.
I myself think a patch is fine, and this one looks quite good at first glance (assuming the lexer is Scintilla's upstream one). All I can notice is that:
* the scintilla/scintilla_changes.patch patch needs updating * there seem to be an indentation issue in src/filetypes.c * maybe comment_single shouldn't be set to an empty value
I didn't test, but apart from that it looks good (not tested yet).
Cheers, Colomban
Le 14/11/2019 à 13:17, Colomban Wendling a écrit :
[…]
- the scintilla/scintilla_changes.patch patch needs updating
- there seem to be an indentation issue in src/filetypes.c
- maybe comment_single shouldn't be set to an empty value
I didn't test, but apart from that it looks good (not tested yet).
I fixed the bits I mentioned and did rudimentary testing that shows it works well. The lexer is indeed a plain copy of Scintilla's one, so no problem here. IMO this is fine to go in, and I'll make a PR for review.
@Snowflake what credit should I use? Your name and email as see on this ML, or something else?
Cheers, Colomban
I fixed the bits I mentioned and did rudimentary testing that shows it works well. The lexer is indeed a plain copy of Scintilla's one, so no problem here. IMO this is fine to go in, and I'll make a PR for review.
@Snowflake what credit should I use? Your name and email as see on this ML, or something else?
Cheers, Colomban
Thank you very much! I had freed some time this Sunday to look over those issues you mentioned, but you beat me to it. Again, thanks!
Personally, I don't care much about credit, so I'd be fine without it. If it's strictly necessary, then this name and address are fine.
Le 16/11/2019 à 22:45, Snowflake the Pony a écrit :
I fixed the bits I mentioned and did rudimentary testing that shows it works well. The lexer is indeed a plain copy of Scintilla's one, so no problem here. IMO this is fine to go in, and I'll make a PR for review.
@Snowflake what credit should I use? Your name and email as see on this ML, or something else?
Cheers, Colomban
Thank you very much! I had freed some time this Sunday to look over those issues you mentioned, but you beat me to it. Again, thanks!
No problem. It's now visible at https://github.com/geany/geany/pull/2399.
Is there some command build commands for Smalltalk? E.g. a common compiler available on major platforms or such, so that we could provide a mostly sensible default set of commands. If there isn't it's no big deal, it's just nicer if we configure something useful by default, even if most users will end up either altering the configuration or plainly use external tools directly.
Cheers, Colomban
Is there some command build commands for Smalltalk? E.g. a common compiler available on major platforms or such, so that we could provide a mostly sensible default set of commands.
https://lists.geany.org/cgi-bin/mailman/listinfo/devel Most tools that I know of aren't very command-line oriented. The exception is GNU Smalltalk (gst), which is an interpreter. I guess something like this could be useful enough:
gst -f <sourcefile> <args>
Also, I apologize for replying to the wrong email (twice!). I haven't received any other email after this one, so it's the only one I can use to post replies. In any case, I think I'll just drop Hotmail at this point. Sorry, again.