On Wed, 27 Oct 2010 21:18:07 +0300 Dimitar Zhekov dimitar.zhekov@gmail.com wrote:
- handle_integer_setting() uses gboolean *setting. It works, because
gboolean is actually int, but I think that should be gint *.
Now fixed.
- ui_editable_insert_text_callback() checks only the first character
(assuming typing?), so you can, say, paste 1boza in Go to line.
I can't reproduce this using Go to Line.
GeanyInsertNum contains a callback with full check, similar what is required +-number.
- It would be nice to have the Document -> Indent Width -> #
commands bindable to keys. Personally I don't use Ctrl+# for sending selection to custom commands...
I think it would be better to have a single keybinding that prompted for the indent width rather than (re)assign those shortcuts.
Nick
On Thu, 28 Oct 2010 12:51:19 +0100 Nick Treleaven nick.treleaven@btinternet.com wrote:
- ui_editable_insert_text_callback() checks only the first character
(assuming typing?), so you can, say, paste 1boza in Go to line.
I can't reproduce this using Go to Line.
Type 1boza in a document, mark it, Ctrl-C, Go to Line, Ctrl-V. It must work, only gchar c = *new_text is checked with isdigit().
On Fri, 29 Oct 2010 19:13:42 +0300 Dimitar Zhekov dimitar.zhekov@gmail.com wrote:
- ui_editable_insert_text_callback() checks only the first character
(assuming typing?), so you can, say, paste 1boza in Go to line.
I can't reproduce this using Go to Line.
Type 1boza in a document, mark it, Ctrl-C, Go to Line, Ctrl-V. It must work, only gchar c = *new_text is checked with isdigit().
Oops, you're right about pasting.
Nick
On Fri, 29 Oct 2010 18:22:17 +0100 Nick Treleaven nick.treleaven@btinternet.com wrote:
- ui_editable_insert_text_callback() checks only the first character
(assuming typing?), so you can, say, paste 1boza in Go to line.
I can't reproduce this using Go to Line.
Type 1boza in a document, mark it, Ctrl-C, Go to Line, Ctrl-V. It must work, only gchar c = *new_text is checked with isdigit().
Oops, you're right about pasting.
Here is a proper check.
On Sat, 30 Oct 2010 16:45:06 +0300 Dimitar Zhekov dimitar.zhekov@gmail.com wrote:
On Fri, 29 Oct 2010 18:22:17 +0100 Nick Treleaven nick.treleaven@btinternet.com wrote:
- ui_editable_insert_text_callback() checks only the first character
(assuming typing?), so you can, say, paste 1boza in Go to line.
I can't reproduce this using Go to Line.
Type 1boza in a document, mark it, Ctrl-C, Go to Line, Ctrl-V. It must work, only gchar c = *new_text is checked with isdigit().
Oops, you're right about pasting.
Here is a proper check.
Committed, thanks.
Nick
On Thu, 28 Oct 2010 12:51:19 +0100 Nick Treleaven nick.treleaven@btinternet.com wrote:
On Wed, 27 Oct 2010 21:18:07 +0300 Dimitar Zhekov dimitar.zhekov@gmail.com wrote:
- It would be nice to have the Document -> Indent Width -> #
commands bindable to keys. Personally I don't use Ctrl+# for sending selection to custom commands...
I think it would be better to have a single keybinding that prompted for the indent width rather than (re)assign those shortcuts.
I'd really prefer separate keys... Well, maybe I'll write a short plugin, "Quick Indent" or something, that (1) adds these keybinding and (2) includes a "Redinent all documents" function, which will apply the current settings to all open files. Ever since per-document indent took place, we have no way to quickly reindent all open project files, and that bugs me.
On Sat, 30 Oct 2010 18:08:34 +0300 Dimitar Zhekov dimitar.zhekov@gmail.com wrote:
- It would be nice to have the Document -> Indent Width -> #
commands bindable to keys. Personally I don't use Ctrl+# for sending selection to custom commands...
I think it would be better to have a single keybinding that prompted for the indent width rather than (re)assign those shortcuts.
I'd really prefer separate keys... Well, maybe I'll write a short plugin, "Quick Indent" or something, that (1) adds these keybinding and
OK
(2) includes a "Redinent all documents" function, which will apply the current settings to all open files. Ever since per-document indent took place, we have no way to quickly reindent all open project files, and that bugs me.
Yes, I mentioned this at the time. I think such a function could/should be in the core. Patches welcome.
Nick
On Mon, 1 Nov 2010 15:05:47 +0000 Nick Treleaven nick.treleaven@btinternet.com wrote:
(2) includes a "Redinent all documents" function, which will apply the current settings to all open files. Ever since per-document indent took place, we have no way to quickly reindent all open project files, and that bugs me.
Yes, I mentioned this at the time. I think such a function could/should be in the core. Patches welcome.
I've now added a menu item 'Project->Apply Default Indentation'. Works for non-projects too. I'm thinking of renaming the Project menu to 'Session' and New -> New Project etc.
Nick