Attached is a patch to add a Unity Quicklist shortcut for Geany. The patch is from "svn diff".
A description of the reasons why and a screenshot of the results can both be found in my recent blog post: http://mhall119.com/2012/02/contributing-to-unity-for-non-developers-quickli...
Michael Hall mhall119@ubuntu.com
Hi,
Le 25/02/2012 23:01, Michael Hall a écrit :
Attached is a patch to add a Unity Quicklist shortcut for Geany. The patch is from "svn diff".
Isn't that the same report than in the pull request #27? [1] No need to post it twice :)
Though you made me answer your mail so maybe you got what you wanted ^^
A description of the reasons why and a screenshot of the results can both be found in my recent blog post: http://mhall119.com/2012/02/contributing-to-unity-for-non-developers-quickli...
Well, I've a few questions, remarks or criticisms:
1) The name *must* be translatable. IIRC you just need to prefix the entry's name with an underscore (_) for intltool to take care of translating it.
2) Is this a general-purpose change or a patch that only should be in Ubuntu? I mean, I don't know of any other distribution using Unity so I'm not 100% sure this should be applied "upstream"...
2.1) Doesn't GNOME-Shell has something similar that could be made to also work? Or does it already?
3) Is the action really useful? Launching the "geany" command while Geany is already running already starts a new instance.
Regards, Colomban
On 02/25/2012 06:00 PM, Colomban Wendling wrote:
- The name *must* be translatable. IIRC you just need to prefix the
entry's name with an underscore (_) for intltool to take care of translating it.
I wasn't sure if that's all that was needed. If it is, I will be happy to add it to my git branch.
- Is this a general-purpose change or a patch that only should be in
Ubuntu? I mean, I don't know of any other distribution using Unity so I'm not 100% sure this should be applied "upstream"...
To my knowledge Unity has been successfully ported to both ArchLinux and OpenSuse, and is in the process of being ported to Fedora as well. It may not be as popular outside of Ubuntu, but it does exist in other distros, so I'd rather get this upstream where everybody can benefit.
2.1) Doesn't GNOME-Shell has something similar that could be made to also work? Or does it already?
I don't know, they are working on a ApplicationMenu, but I think it's only activated when the program is running, and is something you have to provide in code.
- Is the action really useful? Launching the "geany" command while
Geany is already running already starts a new instance.
The default Unity action, when you have an instance of geany already running, is to switch to that instance when you click the icon again. If the --new-instance is a problem, I can remove it. If it doesn't make a difference, it might be better to be explicit about the intent of the shortcut.
Michael Hall mhall119@ubuntu.com
On 12-02-25 04:29 PM, Michael Hall wrote:
On 02/25/2012 06:00 PM, Colomban Wendling wrote:
- Is this a general-purpose change or a patch that only should be in
Ubuntu? I mean, I don't know of any other distribution using Unity so I'm not 100% sure this should be applied "upstream"...
To my knowledge Unity has been successfully ported to both ArchLinux and OpenSuse, and is in the process of being ported to Fedora as well. It may not be as popular outside of Ubuntu, but it does exist in other distros, so I'd rather get this upstream where everybody can benefit.
IMO, it's fine to add it as long as it doesn't cause any issues with non-Unity desktop environments. Have you tested it in Xfce/KDE/GNOME/etc. by any chance or are you pretty sure it won't harm?
Cheers, Matthew Brush
I haven't tested it, but anything outside of the [Desktop Entry] section shouldn't cause any harm, and the X- attribute in that section should also be ignored by any environment that doesn't want to use it.
Michael Hall mhall119@ubuntu.com
On 02/25/2012 08:05 PM, Matthew Brush wrote:
On 12-02-25 04:29 PM, Michael Hall wrote:
On 02/25/2012 06:00 PM, Colomban Wendling wrote:
- Is this a general-purpose change or a patch that only should be in
Ubuntu? I mean, I don't know of any other distribution using Unity so I'm not 100% sure this should be applied "upstream"...
To my knowledge Unity has been successfully ported to both ArchLinux and OpenSuse, and is in the process of being ported to Fedora as well. It may not be as popular outside of Ubuntu, but it does exist in other distros, so I'd rather get this upstream where everybody can benefit.
IMO, it's fine to add it as long as it doesn't cause any issues with non-Unity desktop environments. Have you tested it in Xfce/KDE/GNOME/etc. by any chance or are you pretty sure it won't harm?
Cheers, Matthew Brush _______________________________________________ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Am 26.02.2012 02:05, schrieb Matthew Brush:
On 12-02-25 04:29 PM, Michael Hall wrote:
On 02/25/2012 06:00 PM, Colomban Wendling wrote:
- Is this a general-purpose change or a patch that only should be in
Ubuntu? I mean, I don't know of any other distribution using Unity so I'm not 100% sure this should be applied "upstream"...
To my knowledge Unity has been successfully ported to both ArchLinux and OpenSuse, and is in the process of being ported to Fedora as well. It may not be as popular outside of Ubuntu, but it does exist in other distros, so I'd rather get this upstream where everybody can benefit.
IMO, it's fine to add it as long as it doesn't cause any issues with non-Unity desktop environments. Have you tested it in Xfce/KDE/GNOME/etc. by any chance or are you pretty sure it won't harm?
Going to test it for a couple of days on Xubuntu and Debian with Xfce...
Cheers, Frank