Hi,
I've finally found some time to integrate my GProject plugin into geany-plugins; for those who like git, the result is here:
https://gitorious.org/geany-plugins-gproject/geany-plugins-gproject
For those who dislike it, the patch is here:
I hope I've updated all the necessary files. The automake build should be working correctly; however, in the waf build I'm not sure how to integrate icon cache rebuild into the waf script. From what I could see no other plugin ships with its own icons and even though Geany's waf script contains the necessary code to rebuild the icon cache, I'm not sure how to integrate it properly into the plugin build system. Anyone willing to help?
Cheers,
Jiri
On Fri, 20 May 2011 22:04:40 +0200, Jiří wrote:
Hi,
I've finally found some time to integrate my GProject plugin into geany-plugins; for those who like git, the result is here:
https://gitorious.org/geany-plugins-gproject/geany-plugins-gproject
For those who dislike it, the patch is here:
I guess you waant to commit it yourself instead of depending on someone else, right? So, tell me your Sourceforge username and I'll add you to the project members.
I hope I've updated all the necessary files. The automake build should be working correctly; however, in the waf build I'm not sure how to integrate icon cache rebuild into the waf script. From what I could see no other plugin ships with its own icons and even though Geany's waf script contains the necessary code to rebuild the icon cache, I'm not sure how to integrate it properly into the plugin build system. Anyone willing to help?
Sure, I'll do once your plugin is in the repository.
Regards, Enrico
2011/5/22 Enrico Tröger enrico.troeger@uvena.de:
On Fri, 20 May 2011 22:04:40 +0200, Jiří wrote:
Hi,
I've finally found some time to integrate my GProject plugin into geany-plugins; for those who like git, the result is here:
https://gitorious.org/geany-plugins-gproject/geany-plugins-gproject
For those who dislike it, the patch is here:
I guess you waant to commit it yourself instead of depending on someone else, right? So, tell me your Sourceforge username and I'll add you to the project members.
Thanks Enrico, my username is "techet".
Regards, Jiri
On Mon, 23 May 2011 12:52:49 +0200, Jiří wrote:
2011/5/22 Enrico Tröger enrico.troeger@uvena.de:
On Fri, 20 May 2011 22:04:40 +0200, Jiří wrote:
Hi,
I've finally found some time to integrate my GProject plugin into geany-plugins; for those who like git, the result is here:
https://gitorious.org/geany-plugins-gproject/geany-plugins-gproject
For those who dislike it, the patch is here:
I guess you waant to commit it yourself instead of depending on someone else, right? So, tell me your Sourceforge username and I'll add you to the project members.
Thanks Enrico, my username is "techet".
I added you to the project, so you can write to the repository. Have fun :D.
In case of questions, just ask.
Regards, Enrico
2011/5/23 Enrico Tröger enrico.troeger@uvena.de:
On Mon, 23 May 2011 12:52:49 +0200, Jiří wrote:
2011/5/22 Enrico Tröger enrico.troeger@uvena.de:
On Fri, 20 May 2011 22:04:40 +0200, Jiří wrote:
Hi,
I've finally found some time to integrate my GProject plugin into geany-plugins; for those who like git, the result is here:
https://gitorious.org/geany-plugins-gproject/geany-plugins-gproject
For those who dislike it, the patch is here:
I guess you waant to commit it yourself instead of depending on someone else, right? So, tell me your Sourceforge username and I'll add you to the project members.
Thanks Enrico, my username is "techet".
I added you to the project, so you can write to the repository. Have fun :D.
Perfect! I've just committed the plugin. As I said, at the moment there's a problem with the waf script - it compiles fine but I don't know how to install the icons from the "icons" directory and how to refresh the icon cache during installation. Any hints how to do this with waf?
Cheers, Jiri
On Wed, 25 May 2011 00:41:22 +0200, Jiří wrote:
2011/5/23 Enrico Tröger enrico.troeger@uvena.de:
On Mon, 23 May 2011 12:52:49 +0200, Jiří wrote:
2011/5/22 Enrico Tröger enrico.troeger@uvena.de:
On Fri, 20 May 2011 22:04:40 +0200, Jiří wrote:
Hi,
I've finally found some time to integrate my GProject plugin into geany-plugins; for those who like git, the result is here:
https://gitorious.org/geany-plugins-gproject/geany-plugins-gproject
For those who dislike it, the patch is here:
I guess you waant to commit it yourself instead of depending on someone else, right? So, tell me your Sourceforge username and I'll add you to the project members.
Thanks Enrico, my username is "techet".
I added you to the project, so you can write to the repository. Have fun :D.
Perfect! I've just committed the plugin. As I said, at the moment there's a problem with the waf script - it compiles fine but I don't know how to install the icons from the "icons" directory and how to refresh the icon cache during installation. Any hints how to do this with waf?
I'll have a look on Sunday.
Regards, Enrico
On Thu, 26 May 2011 22:17:36 +0200, Enrico wrote:
On Wed, 25 May 2011 00:41:22 +0200, Jiří wrote:
2011/5/23 Enrico Tröger enrico.troeger@uvena.de:
On Mon, 23 May 2011 12:52:49 +0200, Jiří wrote:
2011/5/22 Enrico Tröger enrico.troeger@uvena.de:
On Fri, 20 May 2011 22:04:40 +0200, Jiří wrote:
Hi,
I've finally found some time to integrate my GProject plugin into geany-plugins; for those who like git, the result is here:
https://gitorious.org/geany-plugins-gproject/geany-plugins-gproject
For those who dislike it, the patch is here:
I guess you waant to commit it yourself instead of depending on someone else, right? So, tell me your Sourceforge username and I'll add you to the project members.
Thanks Enrico, my username is "techet".
I added you to the project, so you can write to the repository. Have fun :D.
Perfect! I've just committed the plugin. As I said, at the moment there's a problem with the waf script - it compiles fine but I don't know how to install the icons from the "icons" directory and how to refresh the icon cache during installation. Any hints how to do this with waf?
I'll have a look on Sunday.
So I had and added the necessary bits, I hope.
I verified the icon installation on Linux and it works. I couldn't test it on Windows as currently the SVN checkout on Windows is broken (see thread "GeanyPG breaks SVN checkout on Windows" for more information).
Two remarks: - why do you use these custom icons at all? At least the icons for Reload, Collapse and Expand can be taken from the stock icons. Not exactly sure about "Follow active editor", maybe there is something appropriate on http://developer.gnome.org/gtk/2.24/gtk-Stock-Items.html. Using the stock icons has the big advantage that these are provided by the icon theme of the user, so they fit better than your custom icons. Just an idea.
- #include <geany/geanyplugin.h>is wrong. On my system it didn't work neither with autotools nor with Waf. The include path is wrong, just omit the "geany" path part. Attached is a patch to fix this.
Regards, Enrico
2011/5/29 Enrico Tröger enrico.troeger@uvena.de:
So I had and added the necessary bits, I hope.
Thanks, looks good here.
I verified the icon installation on Linux and it works. I couldn't test it on Windows as currently the SVN checkout on Windows is broken (see thread "GeanyPG breaks SVN checkout on Windows" for more information).
I haven't tested the plugin under Windows at all and suspect it will need some modifications in order to work.
Two remarks:
- why do you use these custom icons at all? At least the icons for
Reload, Collapse and Expand can be taken from the stock icons. Not exactly sure about "Follow active editor", maybe there is something appropriate on http://developer.gnome.org/gtk/2.24/gtk-Stock-Items.html. Using the stock icons has the big advantage that these are provided by the icon theme of the user, so they fit better than your custom icons. Just an idea.
This is what I originally did. The problem is that the icons are different with different themes and there aren't any icons that are _semantically_ close to what I need. For instance I use the + and - icons for expansion/collapsing the tree - these icons are GTK_STOCK_ADD and GTK_STOCK_REMOVE but under some themes they look completely different and don't look like expand/collapse at all. The only stock icon I could use is GTK_STOCK_REFRESH but it would look strange if different icons in the toolbar were displayed with different themes. The same applies for the file icons too.
- #include <geany/geanyplugin.h>is wrong. On my system it didn't work
neither with autotools nor with Waf. The include path is wrong, just omit the "geany" path part. Attached is a patch to fix this.
Applied, thanks. I install geany into standard paths so the headers appear under /usr/local/lib/geany and were found by the compiler.
Regards, Jiri