Hi,
G_GNUC_WARN_UNUSED does not come in until gtk 2.10 so attached just defines it to nothing if it isn't defined so utils.h will build on gtk 2.8
Cheers Lex
Am 08.10.2010 06:16, schrieb Lex Trotman:
G_GNUC_WARN_UNUSED does not come in until gtk 2.10 so attached just defines it to nothing if it isn't defined so utils.h will build on gtk 2.8
Not sure, but do we need this macro at all?
Cheers, Frank
Le 08/10/2010 06:16, Lex Trotman a écrit :
Hi,
G_GNUC_WARN_UNUSED does not come in until gtk 2.10 so attached just defines it to nothing if it isn't defined so utils.h will build on gtk 2.8
Cheers Lex
This macro is in GLib, not GTK ;) And BTW, this is already done in geany.h:94, so perhaps better include it from utils.h? Or perhaps move it to utils.h, but having it twice seems a bit awkward.
Ah, and your patch seems to lack a #endif too ;)
Regards, Colomban
On Fri, 08 Oct 2010 15:06:36 +0200 Colomban Wendling lists.ban@herbesfolles.org wrote:
G_GNUC_WARN_UNUSED does not come in until gtk 2.10 so attached just defines it to nothing if it isn't defined so utils.h will build on gtk 2.8
Cheers Lex
This macro is in GLib, not GTK ;) And BTW, this is already done in geany.h:94, so perhaps better include it from utils.h? Or perhaps move it to utils.h, but having it twice seems a bit awkward.
Yes, all files should include geany.h before utils.h. I fixed geanywraplabel.c yesterday but forgot stash.c, now done.
Regards, Nick
On 9 October 2010 00:06, Colomban Wendling lists.ban@herbesfolles.org wrote:
Le 08/10/2010 06:16, Lex Trotman a écrit :
Hi,
G_GNUC_WARN_UNUSED does not come in until gtk 2.10 so attached just defines it to nothing if it isn't defined so utils.h will build on gtk 2.8
Cheers Lex
This macro is in GLib, not GTK ;)
Oh ok, G* then :-)
And BTW, this is already done in geany.h:94, so perhaps better include it from utils.h? Or perhaps move it to utils.h, but having it twice seems a bit awkward.
True, Nick has implemented a similar solution by reordering includes. Not my preferred way of doing it, but hacking does say geany.h first...
Ah, and your patch seems to lack a #endif too ;)
Oops, seems I deleted it accidently before doing the svn diff, too much of a rush.
Cheers Lex
Regards, Colomban _______________________________________________ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel