I've got a pull request for geany with two features:
1. Tab width: Now you can set a fixed width for the editor's tabs. Like we discussed in email, reallyLongFileNames can cause problems, so I added an option to have it behave as it does or to allow a fixed width.
2. Ctrl+Pg_Up and Ctrl+Pg_Down didn't effect the focus of the Terminal Emulator, which was annoying when wanting to switch tabs on the bottom pane.
I didn't see an easy way of separating the pull requests after the fact. It didn't occur to me to separate the changes into branches without pulling into master until upstream did, so sorry about that. I should have based the changes on separate branches both from geany's original master rather than all of my updates being pulled into master.
As a side note, I've noticed that the keyboard shortcut to focus the bottom pane/panel doesn't work correctly. I have to essentially focus something specifically (like Compiler/Messages/VTE) and then Ctrl+Pg_Up/Ctrl+Pg_Down on them.
I hope someone likes these features :-)
Thanks,
Steve
On 13-02-14 10:10 PM, Steven Blatnick wrote:
I didn't see an easy way of separating the pull requests after the fact. It didn't occur to me to separate the changes into branches without pulling into master until upstream did, so sorry about that. I should have based the changes on separate branches both from geany's original master rather than all of my updates being pulled into master.
You can just make the appropriate branches and then cherry-pick the good commits into them. Another way is to format-patches and apply them onto your new branches.
A couple more general things:
Don't merge master into your pull request branch unless you have a good reason, it just makes a bunch of useless noise and those merge commits would end up in Geany's "official" history or the committer has to strip them out.
Also, whenever adding settings and keybindings you should update the manual (geany.txt) to reflect the new/changed stuff.
As a side note, I've noticed that the keyboard shortcut to focus the bottom pane/panel doesn't work correctly. I have to essentially focus something specifically (like Compiler/Messages/VTE) and then Ctrl+Pg_Up/Ctrl+Pg_Down on them.
IMO, it'd be nice to make Geany not steal '<Ctrl>Tab' when focus is not in the documents, then you could use the "Switch to Message Window" keybinding to focus the message window area and use the standard '<Ctrl>Tab' to rotate between the tab pages down there. That being said, I didn't look into why Geany overrides '<Ctrl>Tab' everywhere in the UI, maybe there's a reason I don't see.
Just my 2¢
Cheers, Matthew Brush