Hi.
If anyone has some free time for me, please take a look at a message I sent in November [1]. There I attached two patches for Geany which were (and still are) necessary for XML Snippets plugin that was discussed in that thread. You can also read at [1] about what the patches do.
Now I attach the updated patches. Hope they will become a part of Geany and the plugin (not yet released anywhere) will no longer depend on these «third-party» patches.
[1] http://lists.uvena.de/pipermail/geany/2010-November/006210.html
-- Best regards, Eugene.
On Sun, 3 Apr 2011 15:05:21 +0400 Eugene Arshinov earshinov@gmail.com wrote:
If anyone has some free time for me, please take a look at a message I sent in November [1]. There I attached two patches for Geany which were (and still are) necessary for XML Snippets plugin that was discussed in that thread. You can also read at [1] about what the patches do.
Now I attach the updated patches. Hope they will become a part of Geany and the plugin (not yet released anywhere) will no longer depend on these «third-party» patches.
I've now fixed the bug with {ob}pc{cb} in a different way and cleaned up the original code so the cursor positions is handled quite simply, also fixing tabs+spaces mode cursor positions.
I'm not sure that exposing editor_snippets_make_replacements() is a good idea.
Regards, Nick
Hi Nick.
On Thu, 21 Apr 2011 14:21:39 +0100% Nick Treleaven nick.treleaven@btinternet.com wrote:
On Sun, 3 Apr 2011 15:05:21 +0400 Eugene Arshinov earshinov@gmail.com wrote:
If anyone has some free time for me, please take a look at a message I sent in November [1]. There I attached two patches for Geany which were (and still are) necessary for XML Snippets plugin that was discussed in that thread. You can also read at [1] about what the patches do.
Now I attach the updated patches. Hope they will become a part of Geany and the plugin (not yet released anywhere) will no longer depend on these «third-party» patches.
I've now fixed the bug with {ob}pc{cb} in a different way and cleaned up the original code so the cursor positions is handled quite simply, also fixing tabs+spaces mode cursor positions.
Okay, thank you for this change. I saw that your implementation is shorter and simpler than mine.
I'm not sure that exposing editor_snippets_make_replacements() is a good idea.
This is actually a bug in the patch… The plugin does not need this function. Updated patch (which only adds utils_find_open_xml_tag_pos) attached.
-- Best regards, Eugene.
On Fri, 22 Apr 2011 15:28:14 +0400 Eugene Arshinov earshinov@gmail.com wrote:
Updated patch (which only adds utils_find_open_xml_tag_pos) attached.
Ok, committed. I fixed a bug that <> gets reported as a tag.
Regards, Nick
On Sat, 23 Apr 2011 12:46:13 +0100% Nick Treleaven nick.treleaven@btinternet.com wrote:
On Fri, 22 Apr 2011 15:28:14 +0400 Eugene Arshinov earshinov@gmail.com wrote:
Updated patch (which only adds utils_find_open_xml_tag_pos) attached.
Ok, committed. I fixed a bug that <> gets reported as a tag.
Hi Nick, and sorry for the delay.
Thank you for fixing this error and committing the patch.
Can I now commit my XMLSnippets plugin to geany-plugins? I think I properly integrated it into the build system (it was easy as the plugin is a couple of files and does not depend on anything); it builds successfully on my machine with Autotools and Waf.
-- Best regards, Eugene
On Mon, 25 Apr 2011 14:23:32 +0400 Eugene Arshinov earshinov@gmail.com wrote:
Can I now commit my XMLSnippets plugin to geany-plugins? I think I properly integrated it into the build system (it was easy as the plugin is a couple of files and does not depend on anything); it builds successfully on my machine with Autotools and Waf.
Sure, go ahead.
Regards, Nick
On Mon, 25 Apr 2011 12:50:32 +0100% Nick Treleaven nick.treleaven@btinternet.com wrote:
On Mon, 25 Apr 2011 14:23:32 +0400 Eugene Arshinov earshinov@gmail.com wrote:
Can I now commit my XMLSnippets plugin to geany-plugins? I think I properly integrated it into the build system (it was easy as the plugin is a couple of files and does not depend on anything); it builds successfully on my machine with Autotools and Waf.
Sure, go ahead.
Hi.
Seems that I don't have access to geany-plugins. I remember changing something in the Addons plugin, but probably I sent a patch then. Can I have access?
-- Best regards, Eugene
On Mon, 25 Apr 2011 19:47:49 +0400 Eugene Arshinov earshinov@gmail.com wrote:
Can I now commit my XMLSnippets plugin to geany-plugins? I think I properly integrated it into the build system (it was easy as the plugin is a couple of files and does not depend on anything); it builds successfully on my machine with Autotools and Waf.
Sure, go ahead.
Hi.
Seems that I don't have access to geany-plugins. I remember changing something in the Addons plugin, but probably I sent a patch then. Can I have access?
Now added you to the project as statc - I had assumed you already had access ;-)
Regards, Nick
On Mon, 25 Apr 2011 17:17:15 +0100% Nick Treleaven nick.treleaven@btinternet.com wrote:
On Mon, 25 Apr 2011 19:47:49 +0400 Eugene Arshinov earshinov@gmail.com wrote:
Can I now commit my XMLSnippets plugin to geany-plugins? I think I properly integrated it into the build system (it was easy as the plugin is a couple of files and does not depend on anything); it builds successfully on my machine with Autotools and Waf.
Sure, go ahead.
Hi.
Seems that I don't have access to geany-plugins. I remember changing something in the Addons plugin, but probably I sent a patch then. Can I have access?
Now added you to the project as statc - I had assumed you already had access ;-)
I thought so, too. Now committed successfully, thanks.