Hi, I've found a bug causing the tag list to show 'No tags found' after editing and immediately saving with Ctrl-S. Maybe this commit is responsible?
On Sun, 24 Apr 2011 15:30:21 +0000 colombanw@users.sourceforge.net wrote:
Revision: 5735 http://geany.svn.sourceforge.net/geany/?rev=5735&view=rev Author: colombanw Date: 2011-04-24 15:30:20 +0000 (Sun, 24 Apr 2011)
Log Message:
Don't update the tag list when the user is typing
Reset the pending update delay when we get a Scintilla change not to reparse the tags when the user is actively typing.
This should not be a problem since the user is unlikely to care about the tags being updated if he's actively typing, and should avoid annoying delays when actively typing inside very large files.
Patch by Yura Siamashka, thanks.
Regards, Nick
Hi Nick,
Le 25/04/2011 19:20, Nick Treleaven a écrit :
I've found a bug causing the tag list to show 'No tags found' after editing and immediately saving with Ctrl-S. Maybe this commit is responsible?
Unfortunately I'm unable to reproduce the bug, is there anything more to do that edit and save instantaneously after?
However, there was actually a bug letting the idle updates update the tag list for the wrong document (if the updates actually took place after document switching). This should now be fixed, maybe it was related to you problem?
Regards, Colomban
On Tue, 26 Apr 2011 15:55:46 +0200 Colomban Wendling lists.ban@herbesfolles.org wrote:
Le 25/04/2011 19:20, Nick Treleaven a écrit :
I've found a bug causing the tag list to show 'No tags found' after editing and immediately saving with Ctrl-S. Maybe this commit is responsible?
Unfortunately I'm unable to reproduce the bug, is there anything more to do that edit and save instantaneously after?
However, there was actually a bug letting the idle updates update the tag list for the wrong document (if the updates actually took place after document switching). This should now be fixed, maybe it was related to you problem?
The bug still occurs with latest SVN. I can now reproduce it by starting Geany, loading a text file e.g. ChangeLog, then loading my user filetype_extensions.conf. Edit something in filetype_extensions.conf, the tag list stays OK. Save and it reads 'No tags found'.
Regards, Nick
On Tue, 26 Apr 2011 15:24:01 +0100 Nick Treleaven nick.treleaven@btinternet.com wrote:
The bug still occurs with latest SVN. I can now reproduce it by starting Geany, loading a text file e.g. ChangeLog, then loading my user filetype_extensions.conf. Edit something in filetype_extensions.conf, the tag list stays OK. Save and it reads 'No tags found'.
This bug now seems to be unrelated to the recent changes. I tried an older version of Geany SVN from about 2011/03/11 and it has the same problem.
The bug seems to only occur with the combination of files I mentioned above.
Regards, Nick
Le 26/04/2011 16:52, Nick Treleaven a écrit :
On Tue, 26 Apr 2011 15:24:01 +0100 Nick Treleaven nick.treleaven@btinternet.com wrote:
The bug still occurs with latest SVN. I can now reproduce it by starting Geany, loading a text file e.g. ChangeLog, then loading my user filetype_extensions.conf. Edit something in filetype_extensions.conf, the tag list stays OK. Save and it reads 'No tags found'.
This bug now seems to be unrelated to the recent changes. I tried an older version of Geany SVN from about 2011/03/11 and it has the same problem.
The bug seems to only occur with the combination of files I mentioned above.
OK, I see, really weird at first glance :D
The problem have nothing to do with tag changes, but maybe with document array sorting, not sure. Actually the problem is that when saving filetypes_extension.conf, we reloads it implicitly and we re-set the filetype of each document, thus updating the tag list. But we don't check we try to show the correct tag list, so if the last document updated isn't the current one, we will show a wrong tag list.
I've fixed this (r5742) by making symbols_update_tag_list() change the displayed symbol tree view only if it's the one of the current document. This also allowed me to drop a part of my previous change, since it'd be a duplicate now.
Cheers, Colomban
On Tue, 26 Apr 2011 18:28:52 +0200 Colomban Wendling lists.ban@herbesfolles.org wrote:
The bug seems to only occur with the combination of files I mentioned above.
OK, I see, really weird at first glance :D
Yes, sorry for not being clear at first.
The problem have nothing to do with tag changes, but maybe with document array sorting, not sure. Actually the problem is that when saving filetypes_extension.conf, we reloads it implicitly and we re-set the filetype of each document, thus updating the tag list. But we don't check we try to show the correct tag list, so if the last document updated isn't the current one, we will show a wrong tag list.
I've fixed this (r5742) by making symbols_update_tag_list() change the displayed symbol tree view only if it's the one of the current document. This also allowed me to drop a part of my previous change, since it'd be a duplicate now.
Seems to be fixed now, thanks :)
Regards, Nick