Hi,
I'd say let's make a 0.20.1 bugfix release soon. So we can release the fixes made since the 0.20 release for users.
If no one beats me by time, I'll create a 0.20.1 branch based on the 0.20 tag on Sunday and then we can backport relevant fixes.
Regards, Enrico
Le 04/05/2011 22:53, Enrico Tröger a écrit :
Hi,
I'd say let's make a 0.20.1 bugfix release soon. So we can release the fixes made since the 0.20 release for users.
Have you some particular fixes in mind? Just curious ^^
BTW, I'm not sure it's really important or our very concern, but it seems 0.20 has some weird problems when saving to a Windows machine from a Linux one (or whatever, I haven't investigated the problem), probably due to use of g_file_replace_contents() (which has other advantages...). A few links:
https://sourceforge.net/tracker/?func=detail&aid=3184594&group_id=15... https://sourceforge.net/tracker/?func=detail&aid=3126535&group_id=15...
Cheers, Colomban
On 5 May 2011 08:32, Colomban Wendling lists.ban@herbesfolles.org wrote:
Le 04/05/2011 22:53, Enrico Tröger a écrit :
Hi,
I'd say let's make a 0.20.1 bugfix release soon. So we can release the fixes made since the 0.20 release for users.
Have you some particular fixes in mind? Just curious ^^
BTW, I'm not sure it's really important or our very concern, but it seems 0.20 has some weird problems when saving to a Windows machine from a Linux one (or whatever, I haven't investigated the problem), probably due to use of g_file_replace_contents() (which has other advantages...). A few links:
https://sourceforge.net/tracker/?func=detail&aid=3184594&group_id=15... https://sourceforge.net/tracker/?func=detail&aid=3126535&group_id=15...
Yes its in GIO. I remember looking at the source when we were trying to figure out safer file saving without taking forever. in it there is:
#ifdef G_OS_WIN32 close file rename file #else rename file #endif
because windows can't rename a file thats open, the error that both are getting. The test is the *host* os but in the two cases above GIO was built for unix and the file was on windows so the test is wrong so it fails.
Unfortunately i you switch to using safe file saving g_file_set_contents has a similar error because windows can't rename over an existing file, so on windows the old file must be deleted first, but again the decision is based on the host not the target. (you can tell replace_contents or set_contents by the temp file name, replace has "outputstream" in it, set has the original file name)
You have to build Geany without GIO so it uses our unsafe code not replace_contents, I thought there was an option, but I can't find it.
Cheers Lex
On Thu, 05 May 2011 00:32:03 +0200, Colomban wrote:
Le 04/05/2011 22:53, Enrico Tröger a écrit :
Hi,
I'd say let's make a 0.20.1 bugfix release soon. So we can release the fixes made since the 0.20 release for users.
Have you some particular fixes in mind? Just curious ^^
Nope. Just anything which fixed issues since 0.20 and won't add new features or changes the plugin API/ABI.
BTW, I'm not sure it's really important or our very concern, but it seems 0.20 has some weird problems when saving to a Windows machine from a Linux one (or whatever, I haven't investigated the problem), probably due to use of g_file_replace_contents() (which has other advantages...). A few links:
https://sourceforge.net/tracker/?func=detail&aid=3184594&group_id=15... https://sourceforge.net/tracker/?func=detail&aid=3126535&group_id=15...
Sigh. It's weird that file saving is such a hard task nowadays. Unfortunately, I'm afraid I won't find time to work on this.
Regards, Enrico
Am 04.05.2011 22:53, schrieb Enrico Tröger:
I'd say let's make a 0.20.1 bugfix release soon. So we can release the fixes made since the 0.20 release for users.
If no one beats me by time, I'll create a 0.20.1 branch based on the 0.20 tag on Sunday and then we can backport relevant fixes.
A new relase is a good point I guess. But why not building a complete 0.21 from trunk or is it a bit early?
Cheers, Frank
On Fri, 06 May 2011 15:13:00 +0200, Frank wrote:
Am 04.05.2011 22:53, schrieb Enrico Tröger:
I'd say let's make a 0.20.1 bugfix release soon. So we can release the fixes made since the 0.20 release for users.
If no one beats me by time, I'll create a 0.20.1 branch based on the 0.20 tag on Sunday and then we can backport relevant fixes.
A new relase is a good point I guess. But why not building a complete 0.21 from trunk or is it a bit early?
IMO it's too early. There is many new stuff in trunk which probably needs a little more time to settle. However, if you guys want to set a release date to work towards, I won't be the blocker.
Regards, Enrico
On Wed, 4 May 2011 22:53:18 +0200, Enrico wrote:
Hi,
I'd say let's make a 0.20.1 bugfix release soon. So we can release the fixes made since the 0.20 release for users.
If no one beats me by time, I'll create a 0.20.1 branch based on the 0.20 tag on Sunday and then we can backport relevant fixes.
Branch created, happy backporting :). I'll try to backport my (very few) fixes within the next days.
Colomban, Nick, would you backport your changes yourself?
Regards, Enrico
Le 08/05/2011 17:20, Enrico Tröger a écrit :
On Wed, 4 May 2011 22:53:18 +0200, Enrico wrote:
Hi,
I'd say let's make a 0.20.1 bugfix release soon. So we can release the fixes made since the 0.20 release for users.
If no one beats me by time, I'll create a 0.20.1 branch based on the 0.20 tag on Sunday and then we can backport relevant fixes.
Branch created, happy backporting :). I'll try to backport my (very few) fixes within the next days.
Colomban, Nick, would you backport your changes yourself?
Done for my owns.
I didn't backport the following fixes because I though they maybe are either too big or have other "flaws", but if you think I should I can do it:
* "Properly convert template files to UTF-8 on loading" [1] that depends on "Move document encoding conversion with BOM support to encodings.[ch]" [2] * "Avoid triggering autocompletion on PHP open tags (closes #3199442)" [3] because it was quite controverted [4] (haven't had the time/will yet to investigate it further)
Cheers, Colomban
[1] http://git.geany.org/geany/commit/?id=7bb3e8c32d1fc66d51645f7143e433d6ae13b7... [2] http://git.geany.org/geany/commit/?id=ec13c7d8ed6a861e389e7b0c5b77b31c3d80ac... [3] http://git.geany.org/geany/commit/?id=2a73a0e77a9aa097890e5df1855bf9f3fcec8a... [4] http://lists.uvena.de/pipermail/geany-devel/2011-April/004474.html