This patch fixes keyboard accelerator on Resave Missing File dialog.
On 2 March 2010 05:25, Can Koy cankoy@ymail.com wrote:
This patch fixes keyboard accelerator on Resave Missing File dialog.
I have a couple of problems with this patch, sorry if they applied to some of your previous ones but I didn't have time to look at them before.
1. Terminology only, this is changing the mnemonic, not the keyboard accelerator, although the GTK docs are not totally consistent about it :-)
A mnemonic is the character you type (usually with Alt) to activate a visible menu or dialog item and must be unique only within a single menu or dialog, a keyboard accelerator is a keycode (like ctrl-shift-w) that activates functionality directly, visible or not and must be globally unique within Geany.
2. The standard mnemonic for close is always 'c' which is adhered to in most applications and other Geany dialogs, but this patch is changing this one from the standard, this is not good user interface practice, if 'c' clashes then the other should be changed, its 'closes' mnemonic
3. by changing it from the stock item there is no icon associated with the button, again non-standard and won't match the other buttons
Cheers Lex
On 2 March 2010 09:53, Can Koy cankoy@ymail.com wrote:
OK, you send a patch then.
Well, since the question is "Try to resave the file?" I'd suggest that GTK_STOCK_YES and GTK_STOCK_NO be used since they are a more direct answer to the question than apply/cancel are. And that makes the mnemonics different.
What do others think?
Cheers Lex
On Tue, 2 Mar 2010 13:07:55 +1100% Lex Trotman elextr@gmail.com wrote:
I completely agree. Yes/no is more natural in this case.
Best regards, Eugene.
On 2 March 2010 22:41, Eugene Arshinov earshinov@gmail.com wrote:
Nick pointed out in another post that this is contrary to the Gnome HIG and it requires reading the text to answer correctly. He suggests that the accept/yes should be _Save to indicate what should be done.
This agrees with the example save alert given in the HIG which has:
"Close _without saving", "_Cancel" and "_Save" as the buttons.
The HIG also points out that the question should be in the primary text, the secondary text is for extra information. So I suggest that there be no secondary text and primary text be "File "%s" was not found on disk,\ntry to resave?"
Cheers Lex
On Thu, 4 Mar 2010 08:15:44 +1100, Lex wrote:
Done.
Done.
I think this way it should be best. If not, complain :).
Regards, Enrico
On Tue, 2 Mar 2010 13:07:55 +1100 Lex Trotman elextr@gmail.com wrote:
I don't like Yes/No button text, and IIUC is counter to the Gnome HIG. I think to save the text should be 'Save', as on Windows for repetitive things I don't always read the message text and have sometimes pressed the wrong yes/no/ok button.
BTW I'm not worried about mnemonic conflicts, it's not like it activates the wrong button, just means you have more buttons to press.
Regards, Nick
Can,
BTW I have never even seen this dialog, so for finding it, and noticing the inconsistency, and trying to do something about it you deserve thanks for the effort.
Maybe you should be promoted to user interface quality manager :-)
Cheers Lex
On 2 March 2010 09:53, Can Koy cankoy@ymail.com wrote:
Lex, I'm not searching for things to fix/improve in Geany per se. As I've stated in my introduction mail, I've opted for fulfilling my needs which are mostly about keyboard usage; I favor "keep-hands-on-keyboard" scheme while editing. That dialog appears when the file corresponding to a document is renamed or deleted outside Geany.
Thanks, bye.