Hi,
How about some $subject? Namely:
Include stash_group_set_use_defaults() in plugin StashFuncs. I'm not using it any more, but it's a nice thing to have.
New stash_group_free_strings(), which frees any strings and string arrays in a group. Much easier than to track them individually, as in Geany (though if someone is willing to track the keyfile_groups prefs free-s and remove them, a call may be included in configuration_finalize).
On 04/04/2012 19:58, Dimitar Zhekov wrote:
Hi,
How about some $subject? Namely:
Include stash_group_set_use_defaults() in plugin StashFuncs. I'm not using it any more, but it's a nice thing to have.
I'm not convinced we should support that publicly. It puts a burden on the implementation for an unusual use case.
New stash_group_free_strings(), which frees any strings and string arrays in a group. Much easier than to track them individually, as in Geany (though if someone is willing to track the keyfile_groups prefs free-s and remove them, a call may be included in configuration_finalize).
Probably it should be named more generally, in case we support e.g. null-terminated integer lists. Maybe stash_group_free_settings().
Regards, Nick
On Thu, 05 Apr 2012 17:20:44 +0100 Nick Treleaven nick.treleaven@btinternet.com wrote:
On 04/04/2012 19:58, Dimitar Zhekov wrote:
Hi,
How about some $subject? Namely:
Include stash_group_set_use_defaults() in plugin StashFuncs. I'm not using it any more, but it's a nice thing to have.
I'm not convinced we should support that publicly. It puts a burden on the implementation for an unusual use case.
ACK.
New stash_group_free_strings(), which frees any strings and string arrays in a group. Much easier than to track them individually, as in Geany (though if someone is willing to track the keyfile_groups prefs free-s and remove them, a call may be included in configuration_finalize).
Probably it should be named more generally, in case we support e.g. null-terminated integer lists. Maybe stash_group_free_settings().
Renamed and changed the description. Updated patch attached.
On 05/04/2012 19:02, Dimitar Zhekov wrote:
New stash_group_free_strings(), which frees any strings and string
arrays in a group. Much easier than to track them individually, as in Geany (though if someone is willing to track the keyfile_groups prefs free-s and remove them, a call may be included in configuration_finalize).
Probably it should be named more generally, in case we support e.g. null-terminated integer lists. Maybe stash_group_free_settings().
Renamed and changed the description. Updated patch attached.
Thanks, applied. I added a note to the docs that it's not called by stash_group_free().
Ideally we would be using the function in Geany somewhere as an example.
Regards, Nick
On Fri, 06 Apr 2012 14:06:48 +0100 Nick Treleaven nick.treleaven@btinternet.com wrote:
On 05/04/2012 19:02, Dimitar Zhekov wrote:
New stash_group_free_strings(), which frees any strings and string
arrays in a group. Much easier than to track them individually, as in Geany (though if someone is willing to track the keyfile_groups prefs free-s and remove them, a call may be included in configuration_finalize).
Probably it should be named more generally, in case we support e.g. null-terminated integer lists. Maybe stash_group_free_settings().
Renamed and changed the description. Updated patch attached.
Thanks, applied. I added a note to the docs that it's not called by stash_group_free().
Ideally we would be using the function in Geany somewhere as an example.
Perhaps on the plugins group, since it's short and contains both string (freed in main?..) and string vector. Would require a static variable.