Hi all,
On 10/20/13 21:01, RPG wrote:
- add removing pairing brace by Shift+BackSpace
- do not add semicolon in #define-s
- add semicolon after class and struct
- now works with GTK3+ (thanks Matthew Brush for patch http://pastebin.geany.org/r2VKS/)
- added scrollbar for settings
- improve semicolon completion
- added help
- added Tab jump to enclosed char (thanks Thomas Martitz: https://github.com/kugel-/geany-plugins/commit/7f19c3035abf6f8a7fa66c7b4c1ef...)
now that we have a quite feature rich auto-close plugin (I didn't test/use it but it already looks more mature than what we have in Geany core), I wonder whether we could drop the now somewhat redundant and always buggy code in Geany core which provides the same feature.
Any opinions?
Pavel: I guess the auto-close plugin is at least as production ready as the current buggy code in Geany and so can be used as replacement?
Regards, Enrico
Hi all, now that we have a quite feature rich auto-close plugin (I didn't test/use it but it already looks more mature than what we have in Geany core), I wonder whether we could drop the now somewhat redundant and always buggy code in Geany core which provides the same feature.
Any opinions?
Pavel: I guess the auto-close plugin is at least as production ready as the current buggy code in Geany and so can be used as replacement?
Actually we have at least three implementations: 1) Geany itself 2) Addons plugin (implements enclosing and custom autoclose pairs) 3) Autoclose plugin
But autoclose plugin didn't tested by wide variety of users because it never was in release (it was appeared only in 1.24). So as it never was released, I'm not sure that it doesn't breaks someone's use case of Geany...
IIRC, Geany devs prefer plugins over editor patches.
-- Best regards, Pavel Roschin aka RPG
On 10/27/13 17:03, Pavel Roschin wrote:
Hi all, now that we have a quite feature rich auto-close plugin (I didn't test/use it but it already looks more mature than what we have in Geany core), I wonder whether we could drop the now somewhat redundant and always buggy code in Geany core which provides the same feature.
Any opinions?
Pavel: I guess the auto-close plugin is at least as production ready as the current buggy code in Geany and so can be used as replacement?
Actually we have at least three implementations:
- Geany itself
- Addons plugin (implements enclosing and custom autoclose pairs)
Ah, forgot that one. Do you think it's possible/reasonable to merge this into your plugin?
- Autoclose plugin
But autoclose plugin didn't tested by wide variety of users because it never was in release (it was appeared only in 1.24). So as it never was released, I'm not sure that it doesn't breaks someone's use case of Geany...
Ok, so it might be better to delay the removal of the Geany code until maybe one or two releases of G-P including autoclose.
IIRC, Geany devs prefer plugins over editor patches.
At least for me and especially in this case, this is true :).
Regards, Enrico
Ah, forgot that one. Do you think it's possible/reasonable to merge this into your plugin?
I has additional features (like customizing enclosing pairs) but I don't want to include them because these features are buggy and very rare. Customizing enclose pairs should be added into filetypes in future I think...
-- Best regards, Pavel Roschin aka RPG
On 13-10-27 09:27 AM, Enrico Tröger wrote:
On 10/27/13 17:03, Pavel Roschin wrote:
Hi all, now that we have a quite feature rich auto-close plugin (I didn't test/use it but it already looks more mature than what we have in Geany core), I wonder whether we could drop the now somewhat redundant and always buggy code in Geany core which provides the same feature.
Any opinions?
Pavel: I guess the auto-close plugin is at least as production ready as the current buggy code in Geany and so can be used as replacement?
Actually we have at least three implementations:
- Geany itself
- Addons plugin (implements enclosing and custom autoclose pairs)
Ah, forgot that one. Do you think it's possible/reasonable to merge this into your plugin?
- Autoclose plugin
But autoclose plugin didn't tested by wide variety of users because it never was in release (it was appeared only in 1.24). So as it never was released, I'm not sure that it doesn't breaks someone's use case of Geany...
Ok, so it might be better to delay the removal of the Geany code until maybe one or two releases of G-P including autoclose.
IIRC, Geany devs prefer plugins over editor patches.
At least for me and especially in this case, this is true :).
Not that I want this code in core, but autoclosing is a quite standard/expected editor feature (in SublimeText it's even on by default, and works quite like the new autoclose plugin). Maybe we should at least have this plugin in core plugins or something?
I'm conflicted between core code maintenance and Geany having basic editor features out-of-the-box :)
Cheers, Matthew Brush
On 13-10-27 09:27 AM, Enrico Tröger wrote:
On 10/27/13 17:03, Pavel Roschin wrote:
Hi all, now that we have a quite feature rich auto-close plugin (I didn't test/use it but it already looks more mature than what we have in Geany core), I wonder whether we could drop the now somewhat redundant and always buggy code in Geany core which provides the same feature.
Any opinions?
Pavel: I guess the auto-close plugin is at least as production ready as the current buggy code in Geany and so can be used as replacement?
Actually we have at least three implementations:
- Geany itself
- Addons plugin (implements enclosing and custom autoclose pairs)
Ah, forgot that one. Do you think it's possible/reasonable to merge this into your plugin?
- Autoclose plugin
But autoclose plugin didn't tested by wide variety of users because it never was in release (it was appeared only in 1.24). So as it never was released, I'm not sure that it doesn't breaks someone's use case of Geany...
Ok, so it might be better to delay the removal of the Geany code until maybe one or two releases of G-P including autoclose.
IIRC, Geany devs prefer plugins over editor patches.
At least for me and especially in this case, this is true :).
Not that I want this code in core, but autoclosing is a quite standard/expected editor feature (in SublimeText it's even on by default, and works quite like the new autoclose plugin). Maybe we should at least have this plugin in core plugins or something?
I'm conflicted between core code maintenance and Geany having basic editor features out-of-the-box :)
Cheers, Matthew Brush
Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
What is "core plugins"?
-- Best regards, Pavel Roschin aka RPG
Am 27.10.2013 21:22, schrieb Pavel Roschin:
What is "core plugins"?
The ones that ship with Geany (not geany-plugins). For example splitwindow.
Well, that's could be a good idea to have this plugin in core:)
-- Best regards, Pavel Roschin aka RPG
Agree with both Pavel and Matthew, let the plugin be released and mature a bit, which also gives time for the Geany devs to look at its maintainability, then if enough people think its a "basic" capability, move it to core plugins.
Cheers Lex
PS I don't think its "basic" but so long as its maintainable, I have no problem with it in core
On 28 October 2013 09:34, Pavel Roschin roshin@scriptumplus.ru wrote:
Am 27.10.2013 21:22, schrieb Pavel Roschin:
What is "core plugins"?
The ones that ship with Geany (not geany-plugins). For example
splitwindow.
Well, that's could be a good idea to have this plugin in core:)
-- Best regards, Pavel Roschin aka RPG _______________________________________________ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Am 28.10.2013 00:22, schrieb Lex Trotman:
Agree with both Pavel and Matthew, let the plugin be released and mature a bit, which also gives time for the Geany devs to look at its maintainability, then if enough people think its a "basic" capability, move it to core plugins.
I agree.
Cheers, Frank