Hi all.
I usually limit line length by 80 in my own projects, but in Geany 100 symbols is recommended. If the long line marker position preference was project-specific, I would not need to change it in the Preferences dialog every time I switch between Geany sources and one of my projects.
If making this preference project-specific makes sense for you, I can spend some time to implement it. Otherwise, I will just ignore the issue (I don't consider it important).
Best regards, Eugene.
Am Donnerstag, den 11.02.2010, 22:58 +0300 schrieb Eugene Arshinov:
Hi all.
I usually limit line length by 80 in my own projects, but in Geany 100 symbols is recommended. If the long line marker position preference was project-specific, I would not need to change it in the Preferences dialog every time I switch between Geany sources and one of my projects.
If making this preference project-specific makes sense for you, I can spend some time to implement it. Otherwise, I will just ignore the issue (I don't consider it important).
Best regards, Eugene.
Hi Eugene, I really think this feature would make sense for me too, so I'd appreciate this too, but I also don't consider it as that important, it's more a nice-to-have than a must-have for me. :)
Regards, Dominic
On Sat, 13 Feb 2010 03:45:15 +0100, Dominic wrote:
Am Donnerstag, den 11.02.2010, 22:58 +0300 schrieb Eugene Arshinov:
Hi all.
I usually limit line length by 80 in my own projects, but in Geany 100 symbols is recommended. If the long line marker position preference was project-specific, I would not need to change it in the Preferences dialog every time I switch between Geany sources and one of my projects.
If making this preference project-specific makes sense for you, I can spend some time to implement it. Otherwise, I will just ignore the issue (I don't consider it important).
Best regards, Eugene.
Hi Eugene, I really think this feature would make sense for me too, so I'd appreciate this too, but I also don't consider it as that important, it's more a nice-to-have than a must-have for me. :)
Full ACK. Eugene, if you still have time to besides your great work on the SM branch, we won't disturb you and are keen to see any patches :).
Regards, Enrico
On Sat, 13 Feb 2010 03:45:15 +0100 Dominic Hopf dmaphy@googlemail.com wrote:
I really think this feature would make sense for me too, so I'd appreciate this too, but I also don't consider it as that important, it's more a nice-to-have than a must-have for me. :)
I agree.
Cheers, Frank
On Sat, 13 Feb 2010 17:29:15 +0100% Frank Lanitz frank@frank.uvena.de wrote:
On Sat, 13 Feb 2010 03:45:15 +0100 Dominic Hopf dmaphy@googlemail.com wrote:
I really think this feature would make sense for me too, so I'd appreciate this too, but I also don't consider it as that important, it's more a nice-to-have than a must-have for me. :)
I agree.
Great. I did not even suppose this feature would seem useful to so many people :) I'll work on it this week.
Best regards, Eugene.
On Thu, 11 Feb 2010 22:58:24 +0300 Eugene Arshinov earshinov@gmail.com wrote:
I usually limit line length by 80 in my own projects, but in Geany 100 symbols is recommended. If the long line marker position preference was project-specific, I would not need to change it in the Preferences dialog every time I switch between Geany sources and one of my projects.
If making this preference project-specific makes sense for you, I can spend some time to implement it.
Sounds good. (IMO there are some more prefs that also make sense to be project specific but I haven't got around to working on this).
Regards, Nick
On 16 February 2010 03:11, Nick Treleaven nick.treleaven@btinternet.comwrote:
On Thu, 11 Feb 2010 22:58:24 +0300 Eugene Arshinov earshinov@gmail.com wrote:
I usually limit line length by 80 in my own projects, but in Geany 100 symbols is recommended. If the long line marker position preference was project-specific, I would not need to change it in the Preferences dialog every time I switch between Geany sources and one of my projects.
If making this preference project-specific makes sense for you, I can spend some time to implement it.
Sounds good. (IMO there are some more prefs that also make sense to be project specific but I haven't got around to working on this).
Agree, but just to be sure, the setting in a project file will override the current preference setting if a project is open? The current setting needs to be still available when no project is open.
Cheers Lex
Regards, Nick _______________________________________________ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
On Tue, 16 Feb 2010 07:59:57 +1100% Lex Trotman elextr@gmail.com wrote:
On 16 February 2010 03:11, Nick Treleaven nick.treleaven@btinternet.comwrote:
On Thu, 11 Feb 2010 22:58:24 +0300 Eugene Arshinov earshinov@gmail.com wrote:
I usually limit line length by 80 in my own projects, but in Geany 100 symbols is recommended. If the long line marker position preference was project-specific, I would not need to change it in the Preferences dialog every time I switch between Geany sources and one of my projects.
If making this preference project-specific makes sense for you, I can spend some time to implement it.
Sounds good. (IMO there are some more prefs that also make sense to be project specific but I haven't got around to working on this).
Agree, but just to be sure, the setting in a project file will override the current preference setting if a project is open? The current setting needs to be still available when no project is open.
Yeah, certainly.
Best regards, Eugene.
Hi.
I just implemented $subj. I can't be sure all decisions I made are right, so I request a review. There are a couple of screen shots, for those who don't like applying patches: [1], [2].
In the first shot you can see I had to change the preferences dialog. I made it so that it would be possible to determine the preferable style of the marker (line/background) at any moment. There are some cases when it is necessary: for example, a user may disable the marker globally, but turn it on for particular project. With prev. version of the dialog we wouldn't be able to decide which marker style to use.
I did not make style and color settings project-specific intentionally, that would be just useless.
I had to tamper GeanyEditor struct a bit. It seems to cause no troubles for plugins as GeanyEditor is not exported. Fields 'long_line_*' are renamed to corresponding 'long_line_global_*' to emphasize they got different semantics.
[1] Preferences Dialog: http://xmages.net/upload/839ca662.png [2] Project Properties: http://xmages.net/upload/602c3e80.png
Best regards, Eugene.
Am Sonntag, den 21.02.2010, 18:34 +0300 schrieb Eugene Arshinov:
[1] Preferences Dialog: http://xmages.net/upload/839ca662.png [2] Project Properties: http://xmages.net/upload/602c3e80.png
The screenshots look very cool!
On Sun, 21 Feb 2010 18:34:03 +0300 Eugene Arshinov earshinov@gmail.com wrote:
I just implemented $subj. I can't be sure all decisions I made are right, so I request a review. There are a couple of screen shots, for those who don't like applying patches: [1], [2].
Thanks ;-)
In the first shot you can see I had to change the preferences dialog. I made it so that it would be possible to determine the preferable style of the marker (line/background) at any moment. There are some cases when it is necessary: for example, a user may disable the marker globally, but turn it on for particular project. With prev. version of the dialog we wouldn't be able to decide which marker style to use.
OK, looks good.
...
I had to tamper GeanyEditor struct a bit. It seems to cause no troubles for plugins as GeanyEditor is not exported. Fields 'long_line_*' are renamed to corresponding 'long_line_global_*' to emphasize they got different semantics.
I think you mean GeanyEditorPrefs, not GeanyEditor. (Although there are no doc comments, editor_prefs is actually exported so we should break the ABI also, though perhaps it would be better to just append the new field instead of inserting).
The project fields should be made private.
Regards, Nick
On Wed, 24 Feb 2010 13:08:24 +0000 Nick Treleaven nick.treleaven@btinternet.com wrote:
I just implemented $subj. I can't be sure all decisions I made are right, so I request a review. There are a couple of screen shots, for those who don't like applying patches: [1], [2].
Thanks ;-)
Also for the project display setting I think you should use an enum rather than 0, 1, 2.
We should really use Scintilla's EDGE_NONE, EDGE_LINE, EDGE_BACKGROUND instead of 0,1,2 but this was an existing issue.
Regards, Nick
On Wed, 24 Feb 2010 13:08:24 +0000 Nick Treleaven nick.treleaven@btinternet.com wrote:
...
I had to tamper GeanyEditor struct a bit. It seems to cause no troubles for plugins as GeanyEditor is not exported. Fields 'long_line_*' are renamed to corresponding 'long_line_global_*' to emphasize they got different semantics.
I think you mean GeanyEditorPrefs, not GeanyEditor. (Although there are no doc comments, editor_prefs is actually exported so we should break the ABI also, though perhaps it would be better to just append the new field instead of inserting).
The project fields should be made private.
Now committed, thanks ;-)
Regards, Nick