Hi,
I have updated the list of Vala keywords. I also added Valadoc keywords to the 'docComment' value. There were some keywords that I didn't know about in the 'primary' value, so I left them to be safe.
Also still curious about the default tags I asked about in: http://lists.uvena.de/geany-devel/2011-February/003936.html
Cheers, Matthew Brush
On 03/24/11 20:21, mbrush@codebrainz.ca wrote:
Hi,
I have updated the list of Vala keywords. I also added Valadoc keywords to the 'docComment' value. There were some keywords that I didn't know about in the 'primary' value, so I left them to be safe.
Ignore that patch, I believe the attached one is correct. I'm still learning git/patch/contributing and I accidentally went 'git diff branch..master' instead of 'git diff master..branch' I think. Also my diff add/remove (green/red) syntax coloring seems to be backwards making it more confusing :)
I also accidentally removed a '#secondary' comment in the first patch that was there in the filetypes.vala, I guess some filetypes comment that and some don't.
Sorry about that.
Cheers, Matthew Brush
Le 25/03/2011 04:21, mbrush@codebrainz.ca a écrit :
Hi,
I have updated the list of Vala keywords. I also added Valadoc keywords to the 'docComment' value.
Thanks, I applied a slightly modified version of the patch from the other mail :)
There were some keywords that I didn't know about in the 'primary' value, so I left them to be safe.
Like which ones? Maybe we could simply get rid of them if they are wrong.
A few comments:
1) I see that you split "errordomain" in "error" and "domain", is there a good reason for that? "errordomain" is a valid keyword (to declare a new error domain, e.g. a new error type), but AFAIC neither "error" nor "domain" are... are they? 2) You dropped "throws" from primary keywords, why? 3) I also added "sealed"
Cheers, Colomban
On 03/25/11 08:42, Colomban Wendling wrote:
Le 25/03/2011 04:21, mbrush@codebrainz.ca a écrit :
There were some keywords that I didn't know about in the 'primary' value, so I left them to be safe.
Like which ones? Maybe we could simply get rid of them if they are wrong.
IIRC: constpointer, generic, callback
A few comments:
- I see that you split "errordomain" in "error" and "domain", is there
a good reason for that? "errordomain" is a valid keyword (to declare a new error domain, e.g. a new error type), but AFAIC neither "error" nor "domain" are... are they?
No, you're right. I think while editing I split the lines to make it easier to edit, I must've put the cursor right between error and domain and then hit enter. Thanks for noticing.
- You dropped "throws" from primary keywords, why?
I can only guess that while removing duplicates from my list and the original list, I mistakenly read it as 'throw' instead of 'throws'. Again, thanks for finding that.
- I also added "sealed"
Cool. I didn't know about that one. FWIW, I checked what I knew against this the page here, but I'm not sure if it's complete or up-to-date (following Vala's tradition of terrible documentation): http://live.gnome.org/Vala/Syntax
Cheers, Matthew Brush
Le 26/03/2011 00:20, Matthew Brush a écrit :
On 03/25/11 08:42, Colomban Wendling wrote:
Le 25/03/2011 04:21, mbrush@codebrainz.ca a écrit :
There were some keywords that I didn't know about in the 'primary' value, so I left them to be safe.
Like which ones? Maybe we could simply get rid of them if they are wrong.
IIRC: constpointer, generic, callback
Hum... me neither we should probably remove them.
- I also added "sealed"
Cool. I didn't know about that one. FWIW, I checked what I knew against this the page here, but I'm not sure if it's complete or up-to-date (following Vala's tradition of terrible documentation): http://live.gnome.org/Vala/Syntax
Thanks for the link. I personally checked the Vala source (vala/valatokentype.vala) and seen it, so added it.
Cheers, Colomban