The attached patch moves the stuff in the tools->VC menu into Current File Current Directory Current Basedirectory
This makes each menu cleaner.
Additionally, it allows adding new functionality without messing up the current single menu even more, such as revert for directory and basedirectory, or commit of single files etc in the future.
Code-wise it does a little cleanup. The creation of each submenu is in a seperate function, as well as the initialization of the hotkeys.
Hi
2009/1/20, Thomas Martitz thomas.martitz@fhtw-berlin.de:
The attached patch moves the stuff in the tools->VC menu into Current File Current Directory Current Basedirectory
This makes each menu cleaner.
I think submenu is not very good idea for geanyvc. Menu list is not very long, and adding submenu just hinder access.
Comments?
Best regards, Yura Siamshka
Yura Siamashka schrieb:
I think submenu is not very good idea for geanyvc. Menu list is not very long, and adding submenu just hinder access.
Comments?
Best regards, Yura Siamshka
I don't think it hinders access. If you use the mouse, then you already have a noticeable distance (moving the hand to the mouse + moving the cursor to the menu), this on top isn't much. If you don't use the mouse, most (if not all) items are accessible through hotkeys. That will not change.
However, if items get added (and I kinda plan to do that), the menu is rapidly growing to an confusing state. This patch aims to structure the menu in a logical way, to allow clean additions of features.
On Tue, 20 Jan 2009 11:52:52 +0100, Thomas Martitz thomas.martitz@fhtw-berlin.de wrote:
Yura Siamashka schrieb:
I think submenu is not very good idea for geanyvc. Menu list is not very long, and adding submenu just hinder access.
Comments?
Best regards, Yura Siamshka
I don't think it hinders access. If you use the mouse, then you
After using your patch a little bit, I must agree with Yura, the new submenus are more in the way than they help. Yes, they clear up the menu but also make it harder to reach the items.
I have two suggestions, most preferred one first (:D) : a) create the whole menu with GtkAction's and then put a XML file with the layout in the user's config directory. This way, the users can reorder the menu as they like and all will be happy. Bonus of this method is that creating and maintaining menu items is very easy and flexible. b) do a mix of submenus and toplevel menu items: commonly used menu items like 'diff from current file', 'diff from base dir', 'revert', 'commit' should go into the top level menu, others like 'blame', 'add', 'remove', 'log' could go into one or more submenus.
Just my 2cents.
Regards, Enrico
Enrico Tröger wrote:
I have two suggestions, most preferred one first (:D) : a) create the whole menu with GtkAction's and then put a XML file with the layout in the user's config directory. This way, the users can reorder the menu as they like and all will be happy. Bonus of this method is that creating and maintaining menu items is very easy and flexible. b) do a mix of submenus and toplevel menu items: commonly used menu items like 'diff from current file', 'diff from base dir', 'revert', 'commit' should go into the top level menu, others like 'blame', 'add', 'remove', 'log' could go into one or more submenus.
c) A dynamic "recent actions" list?
a) doesn't really appeal me :/
Hi
У Срд, 21/01/2009 у 18:42 +0100, Thomas Martitz піша:
Enrico Tröger wrote:
I have two suggestions, most preferred one first (:D) : a) create the whole menu with GtkAction's and then put a XML file with the layout in the user's config directory. This way, the users can reorder the menu as they like and all will be happy. Bonus of this method is that creating and maintaining menu items is very easy and flexible. b) do a mix of submenus and toplevel menu items: commonly used menu items like 'diff from current file', 'diff from base dir', 'revert', 'commit' should go into the top level menu, others like 'blame', 'add', 'remove', 'log' could go into one or more submenus.
c) A dynamic "recent actions" list?
Dynamic list is evil, I will have to read what I click with it. ;) Don't know why KDE people went crazy about it.
a) sounds good, but, honestly, I think it is overhead for simple list with 10-11 items. (Read: I won't do it, patch is welcome)
a) doesn't really appeal me :/
Why?
Best regards, Yura Siamashka
On Wed, 21 Jan 2009 21:40:37 +0100 Thomas Martitz thomas.martitz@fhtw-berlin.de wrote:
I'm unable to do it (too little knowledge of GTK things) :)
I agree that most users don't want to play around with an XML file to customize the interface, I can't really be bothered.
Personally I like submenus to organise many items, and just use keybindings to do common things. But I know others disagree ;-)
Regards, Nick
Nick Treleaven schrieb:
Personally I like submenus to organise many items, and just use keybindings to do common things. But I know others disagree ;-)
Regards, Nick
I wholeheartedly agree. This is the reason I started this. I've binded my most common VC actions to keys anyways. And the menu is going to get bigger with a growing feature set.
On Thu, 22 Jan 2009 16:39:20 +0000, Nick Treleaven nick.treleaven@btinternet.com wrote:
On Wed, 21 Jan 2009 21:40:37 +0100 Thomas Martitz thomas.martitz@fhtw-berlin.de wrote:
I'm unable to do it (too little knowledge of GTK things) :)
I agree that most users don't want to play around with an XML file to
I slowly recognise that not all share my enthusiasms for the GtkAction way of creating user interfaces :). It was just an idea.
Personally I like submenus to organise many items, and just use keybindings to do common things. But I know others disagree ;-)
Hmm, yeah. Probably it's the best this way. For me personally, it's just that I'm so used to do Tools->VC->Diff ..., after working for a few hours with Thomas' patch, I reverted it to get back the original menu even if it is less structured. It's just a habit, nothing more. Now, I probably will finally start using keybindings :).
Regards, Enrico
Enrico Tröger schrieb:
Hmm, yeah. Probably it's the best this way. For me personally, it's just that I'm so used to do Tools->VC->Diff ...,
And I'm used to Ctrl+[F1|F2|F3], so I don't care in which menu diff is at all ;)
On Thu, 22 Jan 2009 21:48:37 +0100, Thomas Martitz thomas.martitz@fhtw-berlin.de wrote:
Enrico Tröger schrieb:
Hmm, yeah. Probably it's the best this way. For me personally, it's just that I'm so used to do Tools->VC->Diff ...,
And I'm used to Ctrl+[F1|F2|F3], so I don't care in which menu diff is at all ;)
Yup, and that's easier and faster, no doubt. And I want to use keybindings for the VC actions since they were implemented, unfortunately my habits permitted this so far :).
I'm getting old, it seems *afraid*.
Regards, Enrico
Hi,
On Tue, 20 Jan 2009 12:17:44 +0200 "Yura Siamashka" yurand2@gmail.com wrote:
2009/1/20, Thomas Martitz thomas.martitz@fhtw-berlin.de:
The attached patch moves the stuff in the tools->VC menu into Current File Current Directory Current Basedirectory
This makes each menu cleaner.
I think submenu is not very good idea for geanyvc. Menu list is not very long, and adding submenu just hinder access.
Comments?
I like the general way how it is reorganized here, even though I'd do some minor changes. (Feedback about this later). When adding some more functions to the plugin, it might get overloaded with having all inside one submenu.
Cheers, Frank
On Tue, 20 Jan 2009 14:27:33 +0100 Frank Lanitz frank@frank.uvena.de wrote:
Hi,
On Tue, 20 Jan 2009 12:17:44 +0200 "Yura Siamashka" yurand2@gmail.com wrote:
2009/1/20, Thomas Martitz thomas.martitz@fhtw-berlin.de:
The attached patch moves the stuff in the tools->VC menu into Current File Current Directory Current Basedirectory
This makes each menu cleaner.
I think submenu is not very good idea for geanyvc. Menu list is not very long, and adding submenu just hinder access.
Comments?
I like the general way how it is reorganised here, even though I'd do some minor changes. (Feedback about this later).
Now my suggestions ;)
I'd move Update, Status and Commit to main menu since it's independent of the base directory. Maybe we can add in future some special flavors of commit that is working on file, folder and base folder. Same for status and Update.
Cheers, Frank
Frank Lanitz wrote:
Now my suggestions ;)
I'd move Update, Status and Commit to main menu since it's independent of the base directory.
They are?
Maybe we can add in future some special flavors of commit that is working on file, folder and base folder. Same for status and Update.
Cheers, Frank
Ok, it looks probably too empty :) Until the features are implemented they can be in the "top-level" submenu, so I agree :)
On Tue, 20 Jan 2009 01:43:34 +0100 Thomas Martitz thomas.martitz@fhtw-berlin.de wrote:
The attached patch moves the stuff in the tools->VC menu into Current File Current Directory Current Basedirectory
This makes each menu cleaner.
So let's try to make long discussion short ;) We got ... 2 comments against reorganising the menu 3 comments for reorganising the menu including the OP. I guess, this is not very clear ;)
Any further requests to speak?
Cheers, Frank
On Fri, 23 Jan 2009 00:40:17 +0100 Frank Lanitz frank@frank.uvena.de wrote:
On Tue, 20 Jan 2009 01:43:34 +0100 Thomas Martitz thomas.martitz@fhtw-berlin.de wrote:
The attached patch moves the stuff in the tools->VC menu into Current File Current Directory Current Basedirectory
This makes each menu cleaner.
So let's try to make long discussion short ;) We got ... 2 comments against reorganising the menu 3 comments for reorganising the menu including the OP. I guess, this is not very clear ;)
Any further requests to speak?
Well. I need to answer myself ;) I've created a branch for this change called GeanyVC_menu_redesign. You can check it out from
svn co https://geany-plugins.svn.sourceforge.net/svnroot/geany-plugins/branches/Gea...
I can't say, whether it will be really useful, but from my point of view it makes working on easier.
Regards, Frank
On Sat, 24 Jan 2009 02:34:54 +0100, Frank Lanitz frank@frank.uvena.de wrote:
On Fri, 23 Jan 2009 00:40:17 +0100 Frank Lanitz frank@frank.uvena.de wrote:
On Tue, 20 Jan 2009 01:43:34 +0100 Thomas Martitz thomas.martitz@fhtw-berlin.de wrote:
The attached patch moves the stuff in the tools->VC menu into Current File Current Directory Current Basedirectory
This makes each menu cleaner.
So let's try to make long discussion short ;) We got ... 2 comments against reorganising the menu 3 comments for reorganising the menu including the OP. I guess, this is not very clear ;)
Don't count my vote that much, I'd be fine with the submenus as well, that would finally encourage me to use keybindings :).
Any further requests to speak?
Well. I need to answer myself ;)
Just be more patient...:)
Regards, Enrico
On Sat, 24 Jan 2009 13:11:35 +0100 Enrico Tröger enrico.troeger@uvena.de wrote:
On Sat, 24 Jan 2009 02:34:54 +0100, Frank Lanitz frank@frank.uvena.de wrote:
On Fri, 23 Jan 2009 00:40:17 +0100 Frank Lanitz frank@frank.uvena.de wrote:
On Tue, 20 Jan 2009 01:43:34 +0100 Thomas Martitz thomas.martitz@fhtw-berlin.de wrote:
The attached patch moves the stuff in the tools->VC menu into Current File Current Directory Current Basedirectory
This makes each menu cleaner.
So let's try to make long discussion short ;) We got ... 2 comments against reorganising the menu 3 comments for reorganising the menu including the OP. I guess, this is not very clear ;)
Don't count my vote that much, I'd be fine with the submenus as well, that would finally encourage me to use keybindings :).
At least, you are also a user and this is the only thing that counts ;)
Cheers, Frank
On Sat, 24 Jan 2009 02:34:54 +0100 Frank Lanitz frank@frank.uvena.de wrote:
Well. I need to answer myself ;) I've created a branch for this change called GeanyVC_menu_redesign. You can check it out from
svn co https://geany-plugins.svn.sourceforge.net/svnroot/geany-plugins/branches/Gea...
I can't say, whether it will be really useful, but from my point of view it makes working on easier.
Changes of that branch merged to trunk. Happy testing ;)
Cheers, Frank