On 4 June 2012 03:04, Nick Treleaven git-noreply@geany.org wrote:
Branch: refs/heads/master Author: Nick Treleaven nick.treleaven@btinternet.com Committer: Nick Treleaven nick.treleaven@btinternet.com Date: Sun, 03 Jun 2012 17:04:03 Commit: 7b3b65e27df77be862714e2de69aa9f61764a91b https://github.com/geany/geany/commit/7b3b65e27df77be862714e2de69aa9f61764a9...
Log Message:
Add workaround for users with an invisible selection style
This is likely to be the case for any users that copied the system selection style line as this was incorrectly set before, but not applied.
Hi Nick,
Based on your answer on my ML question is this necessary?
Now that we always apply the settings, a selection style of false,false will reset to the Scintilla default "The default is to show the selection by changing the background to light gray and leaving the foreground the same as when it was not selected". So false, false shouldn't be invisible.
Of course it might be invisible on particular backgrounds, but so might c0c0c0.
Or have I still misunderstood something?
Cheers Lex
Modified Paths:
src/highlighting.c
Modified: src/highlighting.c 6 files changed, 6 insertions(+), 0 deletions(-) =================================================================== @@ -790,6 +790,12 @@ static void styleset_common(ScintillaObject *sci, guint ft_id) sci_set_property(sci, "fold.at.else", "1");
style = &common_style_set.styling[GCS_SELECTION];
- if (!style->bold && !style->italic)
- {
- g_warning("selection style is set to invisible - ignoring!");
- style->italic = TRUE;
- style->background = 0xc0c0c0;
- }
/* bold (3rd argument) is whether to override default foreground selection */ SSM(sci, SCI_SETSELFORE, style->bold, invert(style->foreground)); /* italic (4th argument) is whether to override default background selection */
@@ Diff output truncated at 100000 characters. @@
This E-Mail was brought to you by github_commit_mail.py (Source: TBD). _______________________________________________ Geany-commits mailing list Geany-commits@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-commits
On 04/06/2012 07:59, Lex Trotman wrote:
Based on your answer on my ML question is this necessary?
Now that we always apply the settings, a selection style of false,false will reset to the Scintilla default "The default is to show the selection by changing the background to light gray and leaving the foreground the same as when it was not selected". So false, false shouldn't be invisible.
Of course it might be invisible on particular backgrounds, but so might c0c0c0.
Or have I still misunderstood something?
Try it yourself - here I get an invisible selection if neither override is set. Possibly a Scintilla bug - the Scintilla default is not restored on calling SCI_SETSELBACK when the first argument is 0/FALSE.
On 12-06-04 08:30 AM, Nick Treleaven wrote:
On 04/06/2012 07:59, Lex Trotman wrote:
Based on your answer on my ML question is this necessary?
Now that we always apply the settings, a selection style of false,false will reset to the Scintilla default "The default is to show the selection by changing the background to light gray and leaving the foreground the same as when it was not selected". So false, false shouldn't be invisible.
Of course it might be invisible on particular backgrounds, but so might c0c0c0.
Or have I still misunderstood something?
Try it yourself - here I get an invisible selection if neither override is set. Possibly a Scintilla bug - the Scintilla default is not restored on calling SCI_SETSELBACK when the first argument is 0/FALSE.
I didn't look at exactly what was changed, but I can confirm that the selection colours are properly changed now when the scheme is changed, unlike before. The only thing now is I see the message with all geany-themes:
Geany-WARNING **: selection style is set to invisible - ignoring!
But having the selection fixed is worth it the console noise :)
Thanks, Matthew Brush
On 5 June 2012 01:30, Nick Treleaven nick.treleaven@btinternet.com wrote:
On 04/06/2012 07:59, Lex Trotman wrote:
Based on your answer on my ML question is this necessary?
Now that we always apply the settings, a selection style of false,false will reset to the Scintilla default "The default is to show the selection by changing the background to light gray and leaving the foreground the same as when it was not selected". So false, false shouldn't be invisible.
Of course it might be invisible on particular backgrounds, but so might c0c0c0.
Or have I still misunderstood something?
Try it yourself - here I get an invisible selection if neither override is set. Possibly a Scintilla bug - the Scintilla default is not restored on calling SCI_SETSELBACK when the first argument is 0/FALSE.
Hmm, the code certainly uses the text fg/bg if the flag isn't true Editor.cxx:2379 so I asked Neil for clarification of the docs which might be read either way, he confirms it is intended this way.
So we need to do something like this. Since we are in string freeze I guess all we can do is a fixed value, we can't add any user settings or change the message.
I guess we need to advertise the change of colour scheme behavior for the release, otherwise we will get lots of complaints about the messages (like Matthews) when people use customised schemes without one of the flags being true.
Cheers Lex
Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
On 05/06/2012 06:10, Lex Trotman wrote:
On 5 June 2012 01:30, Nick Treleavennick.treleaven@btinternet.com wrote:
On 04/06/2012 07:59, Lex Trotman wrote:
Based on your answer on my ML question is this necessary?
Now that we always apply the settings, a selection style of false,false will reset to the Scintilla default "The default is to show the selection by changing the background to light gray and leaving the foreground the same as when it was not selected". So false, false shouldn't be invisible.
Of course it might be invisible on particular backgrounds, but so might c0c0c0.
Or have I still misunderstood something?
Try it yourself - here I get an invisible selection if neither override is set. Possibly a Scintilla bug - the Scintilla default is not restored on calling SCI_SETSELBACK when the first argument is 0/FALSE.
Hmm, the code certainly uses the text fg/bg if the flag isn't true Editor.cxx:2379 so I asked Neil for clarification of the docs which might be read either way, he confirms it is intended this way.
So we need to do something like this. Since we are in string freeze I guess all we can do is a fixed value, we can't add any user settings or change the message.
Debug messages are not translated. The string freeze only prevents us changing translated strings.
I guess we need to advertise the change of colour scheme behavior for the release, otherwise we will get lots of complaints about the messages (like Matthews) when people use customised schemes without one of the flags being true.
I doubt we'll get lots of complaints - most people don't even read console messages. Those people should now fix their color schemes. I could lower the severity to an info message.
Regards, Nick
[..]
Debug messages are not translated. The string freeze only prevents us changing translated strings.
Ok.
I guess we need to advertise the change of colour scheme behavior for the release, otherwise we will get lots of complaints about the messages (like Matthews) when people use customised schemes without one of the flags being true.
I doubt we'll get lots of complaints - most people don't even read console messages.
Heh, you might be right about that.
Those people should now fix their color schemes. I could lower the severity to an info message.
Don't think it makes much difference, up to you. But we should add it to the incompatibilities section of NEWS iaw http://thread.gmane.org/gmane.editors.geany.devel/6590/focus=6594. I'll add with anything else mentioned in the thread.
Cheers Lex
Regards, Nick
Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
On 07/06/2012 00:11, Lex Trotman wrote:
Those people should now fix their color schemes. I could lower the
severity to an info message.
Don't think it makes much difference, up to you. But we should add it
Info messages are not shown on the console with recent GLib AIUI.
to the incompatibilities section of NEWS iaw http://thread.gmane.org/gmane.editors.geany.devel/6590/focus=6594.
There isn't an incompatibility here due to the workaround if I use g_info instead of g_warning (which I probably should have done anyway).
I'll add with anything else mentioned in the thread.
On 8 June 2012 22:10, Nick Treleaven nick.treleaven@btinternet.com wrote:
On 07/06/2012 00:11, Lex Trotman wrote:
Those people should now fix their color schemes. I could lower the
severity to an info message.
Don't think it makes much difference, up to you. But we should add it
Info messages are not shown on the console with recent GLib AIUI.
to the incompatibilities section of NEWS iaw http://thread.gmane.org/gmane.editors.geany.devel/6590/focus=6594.
There isn't an incompatibility here due to the workaround if I use g_info instead of g_warning (which I probably should have done anyway).
Ok, thats a solution then.
Cheers Lex
I'll add with anything else mentioned in the thread.
Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel