On Tue, 22 Sep 2009 15:53:21 +1000 Lex Trotman elextr@gmail.com wrote:

Hi,

A suggestion on the reflow block function.

Currently it appears to use the long-lines marker column as its right edge, but I would have expected it to use the line breaking column so that it is consistent with newly typed input.

What do others think?

Can you give an example as I'm not sure what you refer to with line breaking column.

Thanks, Frank

Hi.

The truth is that I did not notice the former setting until now, so I did not consider it when writing initial split-and-join-lines patch.

My opinion is that _like breaking column_ should be used when document->line breaking is checked, otherwise _long line marker_ should be used:

// split_lines() function, keybindings.c gint edge; if (editor->line_breaking) edge = editor_prefs.line_break_column; else if (editor->long_line_type != 2) /* long-line marker is enabled */ edge = editor_prefs.long_line_column; else /* nothing to do */ return;

BUT, I don't know a case when it's useful to set line break column and long-line column to different values. As to me, I'd prefer this to be one setting.

Best regards, Eugene.

On Tue, 22 Sep 2009 17:51:06 +1000 Lex Trotman elextr@gmail.com wrote:

Hi Frank,

I'm talking about the two settings in:

Preferences->editor->features: Line Breaking column

and

Preferences->editor->display: Long line marker

The former is where lines are broken when typing with Menu->Document->line breaking checked.

Cheers Lex

2009/9/22 Frank Lanitz frank@frank.uvena.de:

...

On Tue, 22 Sep 2009 15:53:21 +1000 Lex Trotman elextr@gmail.com wrote:

...

Hi,

A suggestion on the reflow block function.

Currently it appears to use the long-lines marker column as its right edge, but I would have expected it to use the line breaking column so that it is consistent with newly typed input.

What do others think?

Can you give an example as I'm not sure what you refer to with line breaking column.

Thanks, Frank -- Frank Lanitz frank@frank.uvena.de _______________________________________________ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel

---

Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel

2009/9/22 Frank Lanitz frank@frank.uvena.de:

On Tue, 22 Sep 2009 14:49:39 +0400 Eugene Arshinov earshinov@gmail.com wrote:

...

BUT, I don't know a case when it's useful to set line break column and long-line column to different values. As to me, I'd prefer this to be one setting.

Me too. Maybe that's the reason why I never recognized this berfore.

Yes, the defaults are the same so its likely not to notice. But they have different uses.

For code I use long lines set to 100 and no automatic breaking (since it *never* happens in the right place in code :-) ( "100 or so" also happens to be Geany's recommended code line length)

For text (eg Geany.txt) I use line break on at 70 and auto break on, since 70 or so is the recommended maximum text line size for readability. Thats why I would like reflow to go to the same limit. I use it only in text not in code.

I think Eugene's suggestion of using line break when auto breaking is on and long line otherwise is a good one. It provides the best of both worlds without much complexity.

Cheers Lex

Regards, Frank -- Frank Lanitz frank@frank.uvena.de _______________________________________________ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel

2009/9/23 Nick Treleaven nick.treleaven@btinternet.com:

On Tue, 22 Sep 2009 22:32:50 +1000 Lex Trotman elextr@gmail.com wrote:

...

...

...

BUT, I don't know a case when it's useful to set line break column and long-line column to different values. As to me, I'd prefer this to be one setting.

Me too. Maybe that's the reason why I never recognized this berfore.

Yes, the defaults are the same so its likely not to notice. But they have different uses.

For code I use long lines set to 100 and no automatic breaking (since it *never* happens in the right place in code :-) ( "100 or so" also happens to be Geany's recommended code line length)

For text (eg Geany.txt) I use line break on at 70 and auto break on, since 70 or so is the recommended maximum text line size for readability.  Thats why I would like reflow to go to the same limit. I use it only in text not in code.

Me too.

...

I think Eugene's suggestion of using line break when auto breaking is on and long line otherwise is a good one.  It provides the best of both worlds without much complexity.

Sounds good.

Ok, here is Eugene's change as a patch.

Cheers Lex

Regards, Nick _______________________________________________ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel